Re: maven: d3.legend.js mods

Hi, > So, I added this to the servlets LICENSE Perfect! Justin

Re: maven: d3.legend.js mods

Hi, > the license of the file is still MIT … we didn’t change anything with this. > And it is referenced in the LICENSE file as being MIT licensed. The only > thing I don’t quite know, is if it’s enough to reference the local path to > the file in the LICENSE file. Sounds fine to me. Thanks,

Re: maven: d3.legend.js mods

Hi, > having a deeper look into the differences, I decided to just put the original > file back in there. > In general, I think it’s a bad idea to include other licensed code and to > change its code. We should avoid things like that in the future. > Do we now have to add a part to the NOTICE

Re: maven: d3.legend.js mods

Hi Dale, having a deeper look into the differences, I decided to just put the original file back in there. In general, I think it’s a bad idea to include other licensed code and to change its code. We should avoid things like that in the future. Do we now have to add a part to the NOTICE file

Re: maven: d3.legend.js mods

Cool! > On Oct 17, 2017, at 9:51 AM, Christofer Dutz > wrote: > ... > I would be more than happy to help out with the release (test drive). I would > even suggest that we could even do this in a shared video session so I could > do the release-test-drive and you

Re: maven: d3.legend.js mods

-drive and you could see what I’m doing and I could explain everything and answer questions. Do you think that would be a good idea? Chris Von: Dale LaBossiere <dml.apa...@gmail.com> Datum: Dienstag, 17. Oktober 2017 um 15:47 An: Christofer Dutz <christofer.d...@c-ware.de> Betreff: R

Re: maven: d3.legend.js mods

Chris, do you want to look into whether or not changes can be made to allow “pure” d3.legend use, or do you just want to reinstate our d3.legend in the repo? — Dale > On Oct 4, 2017, at 1:49 PM, Dale LaBossiere wrote: > > Chris, > > Sure enough, with the downloaded

Re: maven: d3.legend.js mods

I’ll take a look, a bit later, and see if I can deduce precisely what the mods are intended to accomplish and how the console looks w/o it. I agree it would be great to be able to remove it from the repo. w/o looking... - COUNTEROP and STREAMSCOPE are the little gray squares that show up

Re: maven: d3.legend.js mods

Hi Dale, Having another look at the code and the running example, it seems as if this conditionally sets the width of something depending on the title. I did have a look at the running application and for me the application seems to work nicely. Chris Am 03.10.17, 23:45 schrieb "Dale

Re: maven: d3.legend.js mods

Oh yeah … I remember seeing that difference. I guess it would probably be the best option to modify the rest of the application to work with the d3.legend.js instead of patching the library to work with our application. This way we could keep the MIT code out of our repo, which is a rather

maven: d3.legend.js mods

Hi Chris, I picked up the d3.legend.js refactoring (7d8a69f ) and it causes this error in Eclipse: Plugin execution not covered by lifecycle configuration: com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget