Hi,
This vote passed with the following result:
+1 (binding): Ray Auge, Carsten Ziegeler, JB Onofré, Pierre de Rop, Karl Pauls,
Guillaume Nodet, David Bosschaert
I’m promoting the artifacts to Maven Central and update Jira.
Thanks all for you vote.
Regards
JB
> Le 5 avr. 2020 à 07:54,
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611259277
This pull request **introduces 3 alerts** and **fixes 3** when merging
91270ac1d1b0ce733d9ab723726d32fcbf650f4f into
stbischof removed a comment on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611253641
dsff
This is an automated message from the Apache Git Service.
To respond to
stbischof commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611253641
dsff
This is an automated message from the Apache Git Service.
To respond to the
stbischof opened a new pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on
stbischof closed pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611242467
This pull request **introduces 3 alerts** and **fixes 3** when merging
b1849f7fd13193db5824e2236409285ecb36d592 into
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611231842
This pull request **introduces 3 alerts** and **fixes 3** when merging
baf14c47eb1e8306fa180071583994817b66f8e0 into
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611223682
This pull request **introduces 3 alerts** and **fixes 3** when merging
ce7063afb351b0eb476259052b825fea5644a031 into
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611213889
This pull request **introduces 3 alerts** and **fixes 3** when merging
c51e3b897f6e22eb7616172651e97cfb4dfff910 into
[
https://issues.apache.org/jira/browse/FELIX-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078673#comment-17078673
]
Scott Lewis commented on FELIX-6190:
[~cziegeler]: I agree this looks like the same problem. FYI
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611155140
This pull request **introduces 3 alerts** and **fixes 3** when merging
89715aaa65a3c76c5fa5078ede8216edd36bcd16 into
[
https://issues.apache.org/jira/browse/FELIX-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Watson resolved FELIX-6251.
---
Fix Version/s: scr-2.1.18
Assignee: Tom Watson
Resolution: Fixed
> Possible
[
https://issues.apache.org/jira/browse/FELIX-6251?focusedWorklogId=418632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418632
]
ASF GitHub Bot logged work on FELIX-6251:
-
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/FELIX-6251?focusedWorklogId=418631=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418631
]
ASF GitHub Bot logged work on FELIX-6251:
-
Author: ASF GitHub Bot
tjwatson merged pull request #15: FELIX-6251 - Fix NPE in DependencyManager for
references to m_tracker
URL: https://github.com/apache/felix-dev/pull/15
This is an automated message from the Apache Git Service.
To respond
tjwatson opened a new pull request #15: FELIX-6251 - Fix NPE in
DependencyManager for references to m_tracker
URL: https://github.com/apache/felix-dev/pull/15
Need to ensure the tracker is not null. Also calls to tracked can
return null and need to be handled without an NPE
rombert commented on issue #11: [FELIX-6246] Packaged External Library Packages
inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#issuecomment-610906851
Perhaps it's worthwhile to remove all usages of commons-lang3 that are
"trivial" and replaceable
Thinking about it again: Also verifications can make sense in order
to check if a config attribute was (or was not) requested by a
certain piece of code - e.g. sometimes the config object is stored
as is as state, then you might check if a method doThis() calls
config.configForThis()
On
True, that's another option but there is no auto-complete for
'myproperty'
and the code is more verbose than just using
@Mock
MyAnnotation annotation
...
when(annotation.myproperty()).thenReturn("myvalue")
// while all the other default values are automatically returned
// (that's the part
amitjoy commented on issue #11: [FELIX-6246] Packaged External Library Packages
inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#issuecomment-610868951
@ghenzler @rotty3000 I agree with you all. It makes sense to get rid of the
dependency. But it
ghenzler edited a comment on issue #11: [FELIX-6246] Packaged External Library
Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#issuecomment-610865187
I'm also in favour of getting rid of the dependency altogether rather than
trying to embed
ghenzler commented on issue #11: [FELIX-6246] Packaged External Library
Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#issuecomment-610865187
I'm also in favour of getting rid of the dependency altogether rather than
trying to embed it.
Why not using the converter instead? Do you really want to verify interactions
with the annotations?
Usually I use
Converter c = Converters.standardConverter();
Map map = new HashMap<>();
map.put("myproperty", "myvalue");
MyAnnotation annotation = c.convert(map).to(MyAnnotation.class);
Konrad
Hi all,
if you are interested to make @Mock work better with Metatype config
annotations, feel free to join (and support) the discussion in [1].
Best Regards
Georg
[1] https://github.com/mockito/mockito/issues/1900
Hi all,
so I went ahead with this, see documentation [5] on how it works. Any
feedback is appreciated (best before the release :))
-Georg
[5]
https://github.com/apache/felix-dev/blob/master/healthcheck/README.md#monitoring-health-checks
On 2020-03-28 23:31, Georg Henzler wrote:
Hi
[
https://issues.apache.org/jira/browse/FELIX-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077995#comment-17077995
]
Georg Henzler commented on FELIX-6245:
--
[~rombert] Correct, it's all on master now (but not released
[
https://issues.apache.org/jira/browse/FELIX-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler updated FELIX-6245:
-
Fix Version/s: healthcheck.api 2.0.4
> Allow to depend on a health status of a given tag like
[
https://issues.apache.org/jira/browse/FELIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler updated FELIX-6250:
-
Fix Version/s: healthcheck.core 2.0.8
> Introduce HealthCheckMonitor to keep track of HC status
[
https://issues.apache.org/jira/browse/FELIX-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077992#comment-17077992
]
Robert Munteanu edited comment on FELIX-6245 at 4/8/20, 9:29 AM:
-
Looks
[
https://issues.apache.org/jira/browse/FELIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler resolved FELIX-6250.
--
Resolution: Fixed
Fixed via https://github.com/apache/felix-dev/pull/12/commits (in particular
[
https://issues.apache.org/jira/browse/FELIX-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077992#comment-17077992
]
Robert Munteanu commented on FELIX-6245:
Looks good, thanks [~henzlerg]! (Maybe you want to set a
[
https://issues.apache.org/jira/browse/FELIX-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Georg Henzler resolved FELIX-6245.
--
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/FELIX-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077928#comment-17077928
]
Carsten Ziegeler commented on FELIX-6190:
-
[~scottslewis] This looks like the same problem. Would
34 matches
Mail list logo
