Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
paulrutter commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584151474 ## http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java: ## @@ -253,9 +253,12 @@ private void initializeJetty() throws Exception

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
paulrutter commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584151474 ## http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java: ## @@ -253,9 +253,12 @@ private void initializeJetty() throws Exception

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
enapps-enorman commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584068475 ## http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java: ## @@ -253,9 +253,12 @@ private void initializeJetty() throws Exception

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
enapps-enorman commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584068475 ## http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java: ## @@ -253,9 +253,12 @@ private void initializeJetty() throws Exception

Re: [PR] FELIX-6692 Add Jetty WebSocket support for jetty 11.x [felix-dev]

2024-04-29 Thread via GitHub
paulrutter commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2082525693 If we go along with this PR and #310, i think the following changes would need to be made to this PR: * Rename `org.apache.felix.jetty.websocket.enable` to `org.apache.felix.jet

[jira] [Commented] (FELIX-6692) Add Jetty WebSocket support

2024-04-29 Thread BlueConic
[ https://issues.apache.org/jira/browse/FELIX-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841890#comment-17841890 ] Paul Rütter (BlueConic) commented on FELIX-6692: New Jetty12 based PR her

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
paulrutter commented on PR #310: URL: https://github.com/apache/felix-dev/pull/310#issuecomment-2082110334 @enapps-enorman @cziegeler I took the unit tests from #309 and adjusted these to run on Jetty12. All succeed now. I think we have a solid solution in place now. Let me know wh

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-29 Thread via GitHub
paulrutter commented on PR #310: URL: https://github.com/apache/felix-dev/pull/310#issuecomment-2082030662 ``` ## [class org.apache.felix.http.samples.whiteboard.TestWebsocketServletBundleContext$TestWebSocket] Opened session: WebSocketSession[to=PT30S,WebSocketCoreSession@7946968{SERVE