Ok, i'll go ahead and commit ...
2016-05-19 21:30 GMT+02:00 David Jencks :
> Now I did :-)
>
> I’m basically OK with this. I have a couple minor questions that I think
> we can resolve later unless you want to respond now.
>
> 1. I think Coercions should stay in the same package as Annotations
Now I did :-)
I’m basically OK with this. I have a couple minor questions that I think we
can resolve later unless you want to respond now.
1. I think Coercions should stay in the same package as Annotations since
this is basically an implementation of the forthcoming object converter spec.
Did you had a chance to look at it ?
Guillaume
Le mardi 3 mai 2016, Guillaume Nodet a écrit :
>
>
> 2016-05-03 19:12 GMT+02:00 David Jencks >:
>
>> Hi Guillaume,
>>
>> Somehow I missed the issue being filed. I’d appreciate it if you could
>> hold off committing this until I have affirmativel
2016-05-03 19:12 GMT+02:00 David Jencks :
> Hi Guillaume,
>
> Somehow I missed the issue being filed. I’d appreciate it if you could
> hold off committing this until I have affirmatively reviewed the proposal.
> I’ll try to get to it soon, but can’t promise.
>
There's no rush. I'm currently wor
Hi Guillaume,
Somehow I missed the issue being filed. I’d appreciate it if you could hold
off committing this until I have affirmatively reviewed the proposal. I’ll try
to get to it soon, but can’t promise.
thanks
david jencks
> On May 3, 2016, at 7:54 AM, Guillaume Nodet wrote:
>
> I've
I've raised FELIX-5243 about refactoring some SCR code but haven't had any
feedback.
The commits are visible at:
https://github.com/gnodet/felix/commits/FELIX-5243
Unless someone complains, and given it's only refactoring and should not
alter the code itself (and all tests pass), I'll push those