Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Guillaume Nodet
Can those annotations be moved to a gogo specific package ? Something like org.apache.felix.gogo.annotation I'd rather even have them in a separate module, but i think that would cause problem because the coercion mechanism do actually use those. I think those annotations are still experimental,

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Richard S. Hall
On 5/27/10 6:24 PM, Guillaume Nodet wrote: Can those annotations be moved to a gogo specific package ? Something like org.apache.felix.gogo.annotation I'd rather even have them in a separate module, but i think that would cause problem because the coercion mechanism do actually use those. I

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Richard S. Hall
On 5/27/10 6:24 PM, Guillaume Nodet wrote: Can those annotations be moved to a gogo specific package ? Something like org.apache.felix.gogo.annotation I'd rather even have them in a separate module, but i think that would cause problem because the coercion mechanism do actually use those. I

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Guillaume Nodet
On Fri, May 28, 2010 at 00:48, Richard S. Hall he...@ungoverned.org wrote: On 5/27/10 6:24 PM, Guillaume Nodet wrote: Can those annotations be moved to a gogo specific package ? Something like org.apache.felix.gogo.annotation I'd rather even have them in a separate module, but i think that

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Richard S. Hall
On 5/27/10 7:25 PM, Guillaume Nodet wrote: On Fri, May 28, 2010 at 00:48, Richard S. Hallhe...@ungoverned.org wrote: On 5/27/10 6:24 PM, Guillaume Nodet wrote: Can those annotations be moved to a gogo specific package ? Something like org.apache.felix.gogo.annotation I'd rather

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-27 Thread Guillaume Nodet
On Fri, May 28, 2010 at 01:37, Richard S. Hall he...@ungoverned.org wrote: On 5/27/10 7:25 PM, Guillaume Nodet wrote: On Fri, May 28, 2010 at 00:48, Richard S. Hallhe...@ungoverned.org wrote: On 5/27/10 6:24 PM, Guillaume Nodet wrote: Can those annotations be moved to a gogo specific

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-04 Thread Guillaume Nodet
A few things that would be missing imho to make that interesting: * parameters annotation to mark parameters as optional or multi-valued * flag and option could be merged (they are the same, maybe use an enum value on the annotation to differentiate them and maybe have a smart default value

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-04 Thread Richard S. Hall
On 5/4/10 2:33, Guillaume Nodet wrote: A few things that would be missing imho to make that interesting: * parameters annotation to mark parameters as optional or multi-valued Currently, flags are always optional, whereas options are only optional if a default value is specified. We

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-04 Thread Derek Baum
I'm interested to see how your experiment develops. Meanwhile, an alternative approach to writing RFC-147 commands is presented here: https://www.osgi.org/bugzilla/show_bug.cgi?id=53 I'm happy to donate this 500-line Options class to Felix, if there is any interest. Derek On 4 May 2010 14:07,

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-04 Thread Richard S. Hall
On 5/4/10 10:07, Derek Baum wrote: I'm interested to see how your experiment develops. Meanwhile, an alternative approach to writing RFC-147 commands is presented here: https://www.osgi.org/bugzilla/show_bug.cgi?id=53 I'm happy to donate this 500-line Options class to Felix, if there is any

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-04 Thread Peter Kriens
I guess we should have tried this out in a sandbox but this experiment seems rather harmless for existing users and potentially very powerful. And this experiment is timely because I do have to update RFC 147. Will do different next time :-) On 4 mei 2010, at 08:33, Guillaume Nodet wrote: A

[gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-03 Thread Guillaume Nodet
What are those annotations suppose to actually provide ? It seems all they can do is provide some basic help to the user, but does not really help the user writing complex commands and dealing with complex arguments. Have a look at an existing example:

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-03 Thread Richard S. Hall
On 5/3/10 14:51, Guillaume Nodet wrote: What are those annotations suppose to actually provide ? It seems all they can do is provide some basic help to the user, but does not really help the user writing complex commands and dealing with complex arguments. Have a look at an existing example:

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-03 Thread Guillaume Nodet
On Mon, May 3, 2010 at 21:17, Richard S. Hall he...@ungoverned.org wrote: On 5/3/10 14:51, Guillaume Nodet wrote: What are those annotations suppose to actually provide ? It seems all they can do is provide some basic help to the user, but does not really help the user writing complex

Re: [gogo] Parameter annotations (Re: svn commit: r940514 - in /felix/trunk/gogo/runtime/src/main/java/org/osgi/service/command: Flag.java Option.java)

2010-05-03 Thread Richard S. Hall
On 5/3/10 16:56, Guillaume Nodet wrote: On Mon, May 3, 2010 at 21:17, Richard S. Hallhe...@ungoverned.org wrote: On 5/3/10 14:51, Guillaume Nodet wrote: What are those annotations suppose to actually provide ? It seems all they can do is provide some basic help to the user, but