Re: SCR could not obtain state lock after 5 seconds

2012-09-11 Thread Pierre De Rop
please, see FELIX-3661 thanks; /pierre On Tue, Sep 11, 2012 at 10:58 PM, Pierre De Rop wrote: > it's coming soon :-) > > > On Tue, Sep 11, 2012 at 7:25 PM, David Jencks wrote: > >> cant wait :-) >> >> thanks >> david jencks >> >> On Sep 11, 201

Re: SCR could not obtain state lock after 5 seconds

2012-09-11 Thread Pierre De Rop
it's coming soon :-) On Tue, Sep 11, 2012 at 7:25 PM, David Jencks wrote: > cant wait :-) > > thanks > david jencks > > On Sep 11, 2012, at 5:37 AM, Pierre De Rop wrote: > > > Hi David, > > > > So, I have finished to run our non regression tests and the locking > problem > > seems to be resolved,

Re: SCR could not obtain state lock after 5 seconds

2012-09-11 Thread David Jencks
cant wait :-) thanks david jencks On Sep 11, 2012, at 5:37 AM, Pierre De Rop wrote: > Hi David, > > So, I have finished to run our non regression tests and the locking problem > seems to be resolved, but sorry, because now it seems that I'm getting > other kind of problems regarding component f

Re: SCR could not obtain state lock after 5 seconds

2012-09-11 Thread Pierre De Rop
Hi David, So, I have finished to run our non regression tests and the locking problem seems to be resolved, but sorry, because now it seems that I'm getting other kind of problems regarding component factories. Since this thread is now becoming too large, I will post a new one about this new prob

Re: SCR could not obtain state lock after 5 seconds

2012-09-10 Thread Pierre De Rop
thanks, it works. So, I have restarted to run our non regression tests, and will have the results probably on next wednesday. regards; /pierre On Fri, Sep 7, 2012 at 6:18 PM, David Jencks wrote: > Yes, the illegal state exception was pretty dumb. fixed. Not sure why > I didn't see it

Re: SCR could not obtain state lock after 5 seconds

2012-09-07 Thread David Jencks
Yes, the illegal state exception was pretty dumb. fixed. Not sure why I didn't see it thanks! david jencks On Sep 7, 2012, at 1:22 AM, Pierre De Rop wrote: > I just updated the trunk, and ran a mvn test, and indeed, found an lllegal > state exception: > (notice the "should not be calle

Re: SCR could not obtain state lock after 5 seconds

2012-09-07 Thread Pierre De Rop
I just updated the trunk, and ran a mvn test, and indeed, found an lllegal state exception: (notice the "should not be called" trace): . log level: 4 D=Fri Sep 07 10:15:35 CEST 2012, T=Thread-1: [org.apache.felix.scr.integration.components.concurrency.B] Activating component log level: 4 D=Fri

Re: SCR could not obtain state lock after 5 seconds

2012-09-07 Thread David Jencks
I fixed the problems I was working on I saw one case in your concurrency test of an IllegalMonitorStateException and added some code that I hope will log the cause. Since then, of course :-), I haven't seen the problem recur. I'm running tests here with our project with the patch to FELIX-

Re: SCR could not obtain state lock after 5 seconds

2012-09-07 Thread Pierre De Rop
Hi David, no problems, don't worry , I'm using the current released scr version in production, and I'm just doing some extensive non-regression tests with the trunk. So, I will try to make some integration tests for the jira issue you created. But for now, I'm continuing with my own tests ... Un

Re: SCR could not obtain state lock after 5 seconds

2012-09-06 Thread David Jencks
I opened https://issues.apache.org/jira/browse/FELIX-3658 for the first problem and think I have a simple fix. For the second problem, it looks like whenever you disable a component its component id is set to -1. So the problem must be something with re-enabling it. I haven't looked further.

Re: SCR could not obtain state lock after 5 seconds

2012-09-06 Thread David Jencks
Hi Pierre. so many problems :-) These are 2 unrelated problems, to each other and to the problem I found. I sure wonder why we didn't see these before thanks david jencks On Sep 6, 2012, at 1:22 PM, Pierre De Rop wrote: > Hi David, > > I don't know if it's related to the problem you a

Re: SCR could not obtain state lock after 5 seconds

2012-09-06 Thread Pierre De Rop
Hi David, I don't know if it's related to the problem you are talking about, but I just noticed a problem which might also be related to ServiceFactory. here it is: When you have a delayed component "A", which is activated because another component "B" has a dependency on it (dynamic, cardinalit

Re: SCR could not obtain state lock after 5 seconds

2012-09-06 Thread David Jencks
Looking forward to any review :-) I've found an additional problem with ServiceFactory components that I'm trying to fix david jencks On Sep 6, 2012, at 2:54 AM, Pierre De Rop wrote: > Hi David, > > I'm happy to see that the test helped, and it seems that fixing this issue > was not an e

Re: SCR could not obtain state lock after 5 seconds

2012-09-06 Thread Pierre De Rop
Hi David, I'm happy to see that the test helped, and it seems that fixing this issue was not an easy task, congratulation ! [?] For now, I can't reply to your question about the bind/unbind/updated method, because I have not yet fully reviewed your fix, but this is an excellent exercise for me an

Re: SCR could not obtain state lock after 5 seconds

2012-09-05 Thread David Jencks
I finally got everything to work :-) (see caveats in the bug report). The itest was extremely helpful :-) One of the changes I made that perhaps could use some review is that once the bind/unbind/updated methods are set, they are never cleared from the dependency manager. I don't think this is

Re: SCR could not obtain state lock after 5 seconds

2012-09-02 Thread David Jencks
Excellent! I've been working on my idea how to fix this, but I'm still at the stage of getting the existing integration tests to pass. At least some stuff works :-) Looking forward to trying out your test case... david jencks On Sep 2, 2012, at 6:58 AM, Pierre De Rop wrote: > Hi, > > I comm

Re: SCR could not obtain state lock after 5 seconds

2012-09-02 Thread Felix Meschberger
Hi Thanks alot. I can confirm: This also breaks the build on my box as expected. Regards Felix Am 02.09.2012 um 07:58 schrieb Pierre De Rop: > Hi, > > I committed in revision 1379968 a (candidate) integration test, which seems > to reproduce the problem. > Hope it will help. > > regards; > /p

Re: SCR could not obtain state lock after 5 seconds

2012-09-02 Thread Pierre De Rop
Hi, I committed in revision 1379968 a (candidate) integration test, which seems to reproduce the problem. Hope it will help. regards; /pierre On Fri, Aug 31, 2012 at 2:08 PM, Pierre De Rop wrote: > Hi Felix, > > ok, I will try to do it. > > regards; > /pierre > > On Fri, Aug 31, 2012 at 1:58 PM

Re: SCR could not obtain state lock after 5 seconds

2012-08-31 Thread Pierre De Rop
Hi Felix, ok, I will try to do it. regards; /pierre On Fri, Aug 31, 2012 at 1:58 PM, Felix Meschberger wrote: > Hi, > > Am 31.08.2012 um 02:20 schrieb Pierre De Rop: > > > Hi David, > > > > I have progressed and it seems that now I can reproduce the problem, > using > > a sample code. > > It's

Re: SCR could not obtain state lock after 5 seconds

2012-08-29 Thread Pierre De Rop
Hi David, So, with the last fix for FELIX-3639, I finally reproduced the initial deadlock problem. First, here is the "could not obtain lock" exception, including the root exception, showing the thread which is currently holding the writelock: --

Re: SCR could not obtain state lock after 5 seconds

2012-08-10 Thread Pierre De Rop
Hi David; So I tested the latest scr commits but this time I then have another different problem and my components don't startup: I'm now having the following exception: (please see the last "Caused by: java.lang.IllegalStateException: getServiceActive", at the end of the stacktraces) -> 2012-0

Re: SCR could not obtain state lock after 5 seconds

2012-08-10 Thread Pierre De Rop
Hi David, I will restart my scenario with what you just committed and I will give the results tomorrow because I only reproduce the problem with our nightly automatic tests. For now, I have reproduced the problem (not with what you just committed, but with the previous trunk version) and this tim

Re: SCR could not obtain state lock after 5 seconds

2012-08-09 Thread David Jencks
OK, I went ahead and committed a bunch of work including a revised locking scheme (which has been in a patch to FELIX-3456 for a couple months) and the new attempt to track how locks are obtained and do a thread dump when a lock problem occurs. I haven't been able to actually generate a lock pr

Re: SCR could not obtain state lock after 5 seconds

2012-08-09 Thread Pierre De Rop
Hi David; It's also my case, I see the problem only occasionally, in some automatic tests, where many JVM might be starting concurrently, on the same host. So, yes, If you commit the improved code, I could then retry my automatic tests, to see if we find something. What is the improved code exact

Re: SCR could not obtain state lock after 5 seconds

2012-08-09 Thread Felix Meschberger
Hi Am 09.08.2012 um 16:09 schrieb David Jencks: > I've been wondering if trunk code would show these deadlocks I have some > improved code in a jira and occasionally it also seems to show this problem. > (I've personally never seen it locally, it shows up occasionally in automated > builds

Re: SCR could not obtain state lock after 5 seconds

2012-08-09 Thread David Jencks
I've been wondering if trunk code would show these deadlocks I have some improved code in a jira and occasionally it also seems to show this problem. (I've personally never seen it locally, it shows up occasionally in automated builds at work) I've added some more stuff that ought to log ap