On Sun, Jan 26, 2020 at 1:42 PM Nazeer Hussain Shaik <
nazeerhussain.sh...@gmail.com> wrote:
> Guys,
>
> I agree to create branch protection. But I don't agree saying "I broke
> more than fixed".
> I was trying to help fix those two integration issues and was preparing
> the Fineract 1.4.0 release
Guys,
I agree to create branch protection. But I don't agree saying "I broke more
than fixed".
I was trying to help fix those two integration issues and was preparing the
Fineract 1.4.0 release. I don't see any issue with the code changes (just
test data preparation)
Unfortunately I didn't observe
Hi Michael,
you can create Infra ticket for adding branch protection to develop branch.
Same thing has been done for Fineract-CN repositories by this ticket:
https://issues.apache.org/jira/browse/INFRA-19492
Kind regards
Juhan
Kontakt Michael Vorburger () kirjutas kuupäeval P, 26.
jaanuar 2020 k
Hi Micheal,
I have pushed revert commit on my changes.
Thanks,
Nazeer
On Sun, Jan 26, 2020 at 4:54 PM Nazeer Hussain Shaik <
nazeerhussain.sh...@gmail.com> wrote:
> Hi,
> Yesterday I ran all integration tests after change with some different
> Sunday dates. I see all integration tests were pass
Hi,
Yesterday I ran all integration tests after change with some different
Sunday dates. I see all integration tests were passing. with below command.
*./gradlew clean integrationTest*
I have committed the changes because the changes are around test data
preparation. I will try to rollback my comm
Ok I will roll back the commit
On Sun, Jan 26, 2020, 16:27 Michael Vorburger wrote:
> As far as I saw (only looked quickly), Nazeer actually accidentally broke
> more than was fixed... ;-) The "fix" for FINERACT-820 fails to pass
> Checkstyke. (Which is brand new, Nazeer see the recent post anno
As far as I saw (only looked quickly), Nazeer actually accidentally broke
more than was fixed... ;-) The "fix" for FINERACT-820 fails to pass
Checkstyke. (Which is brand new, Nazeer see the recent post announcing it
on this list.)
BTW that commit was pushed without going through a PR. IMHO no comm
Hi All,
Our Fineract 1.x integration tests still failing on Sundays?
https://issues.apache.org/jira/browse/FINERACT-820 has been closed. Has the
problem finally gone away?
Is anyone willing to look into this?
On Sun, Jan 26, 2020 at 10:24 AM Travis CI wrote:
> apache
>
> /
>
> fineract
>
> <
