Re: git commit: [flex-sdk] [refs/heads/release4.11.0] - Correcting setButtonEnabled ASDOC comments. Better descriptions, corrected params, etc

2013-10-15 Thread Justin Mclean
Hi, > Auto pilot... just rebased my merge. Should I revert that and redo the > merge? Looks OK to me. Justin

Re: git commit: [flex-sdk] [refs/heads/release4.11.0] - Correcting setButtonEnabled ASDOC comments. Better descriptions, corrected params, etc

2013-10-15 Thread Mark Kessler
Auto pilot... just rebased my merge. Should I revert that and redo the merge? -Mark On Tue, Oct 15, 2013 at 8:15 PM, wrote: > Updated Branches: > refs/heads/release4.11.0 c47ef1790 -> b612cd772 > > > Correcting setButtonEnabled ASDOC comments. Better descriptions, > corrected params, etc >

Re: Apache Flex 4.11.0 RC2

2013-10-15 Thread OmPrakash Muppirala
On Oct 15, 2013 3:36 PM, "Justin Mclean" wrote: > > Hi, > > Unless there's any objections I'll make RC2 in 24 hours. > > Thanks, > Justin I want to make the change to the Installer for the osmf 2.0 related changes. This will make it easier for non pmc members to test the RC. I should be able to

Re: Apache Flex 4.11.0 RC2

2013-10-15 Thread Alex Harui
FYI, I need to test out the FocusManager change with an overnight mustella run. Last night's run blew up for some unexpected reason. In theory that will be about 18 hours from now. I'm currently working on that copy/paste bug. -Alex On 10/15/13 3:35 PM, "Justin Mclean" wrote: >Hi, > >Unless

Apache Flex 4.11.0 RC2

2013-10-15 Thread Justin Mclean
Hi, Unless there's any objections I'll make RC2 in 24 hours. Thanks, Justin

RE: Debugging Mustella tests in Flash Builder

2013-10-15 Thread Maurice Amsellem
Hi, I have updated the WIKI with instructions to debug Mustella tests for FlashBuilder and IDEA. Maybe the FDB section can be removed (who uses FDB ?) https://cwiki.apache.org/confluence/display/FLEX/Mustella+Overview Thanks to om for the FB detailed steps. Maurice -Message d'origine--

Re: [FlexJS] how much of Google closure goodies do we plan to use?

2013-10-15 Thread Alex Harui
On 10/15/13 12:09 PM, "Sharma, Pratyoosh" wrote: >Ok, makes sense. So if you happen to use PopUp control, the draggable >titlebar bead will be tied to it as a part of component code itself. Yes, preferably via a default custom style property so there isn't an actual class dependency on the impl

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Checked in to develop. Updated Branches: refs/heads/develop 05cc8f3e9 -> c556895ee REFIX FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed [Mustella test pass] - gumbo/components/DataGrid/Properties - gumbo/components/DataGrid/Styles This was tough... The good side is

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Alex Harui
OK, sounds good to me. Thanks for sticking with it. -Alex On 10/15/13 1:18 PM, "Maurice Amsellem" wrote: >Alex, some good news : > >I found some time to run/debug the tests again and discovered that the >way we handled updateCaretForDataProviderChange was not good. >The way it's done now is th

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Alex, these are not needed anymore, see my last email. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 15 octobre 2013 22:19 À : dev@flex.apache.org Objet : Re: Build failed in Jenkins: flex-sdk_mustella #470 Hi Maurice, I created the png.xml files

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Alex Harui
Hi Maurice, I created the png.xml files and ran the tests and they appear to show a difference in the z-order of the header renderers. I will send you the png.xml files directly as I have some other commits that I can't push just yet. Put the png.xml file next to the .png file and run the tests.

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Alex, some good news : I found some time to run/debug the tests again and discovered that the way we handled updateCaretForDataProviderChange was not good. The way it's done now is the following: - setting a flag and calling invalidateDisplayList() - in updateDisplayList call caretRowIndex upda

Re: [FlexJS] New Wiki Writeup

2013-10-15 Thread Emmanuel Durand
Thanks Alex for this update and your work on this project. Do you know if there is any project to create a Javascript emulator of the FlashPlayer ? Thanks On Tue, Oct 15, 2013 at 12:35 AM, Alex Harui wrote: > Hi, > > I found some time to update the wiki information on FlexJS. It is here > [1]

RE: [FlexJS] how much of Google closure goodies do we plan to use?

2013-10-15 Thread Sharma, Pratyoosh
Ok, makes sense. So if you happen to use PopUp control, the draggable titlebar bead will be tied to it as a part of component code itself. Module support will be interesting & probably a relatively more complex problem to solve & though I am quite new to closure, there seems to be quite a good

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Erik de Bruin
Ok, just thought I'd mention it ;-) EdB On Tue, Oct 15, 2013 at 8:50 PM, Maurice Amsellem wrote: > Erik, > > The tests are passing because I have undone one the fixes that have broken > them. > > (FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed ) > > We are currently

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Erik, The tests are passing because I have undone one the fixes that have broken them. (FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed ) We are currently trying to make that fix again in a different way that does not break the tests again, possibly fixing also the tes

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Thanks you for the explanation. -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : mardi 15 octobre 2013 19:10 À : dev@flex.apache.org Objet : Re: Build failed in Jenkins: flex-sdk_mustella #470 On 10/15/13 9:52 AM, "Maurice Amsellem" wrote: >>I will try to gener

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Erik de Bruin
Build 471 passed all tests... is this player version related, or are you chasing ghosts? EdB On Tue, Oct 15, 2013 at 7:09 PM, Alex Harui wrote: > > > On 10/15/13 9:52 AM, "Maurice Amsellem" > wrote: > >>>I will try to generate and check in png.xml files for the two failing >>>tests >> >>Not s

Re: [FlexJS] how much of Google closure goodies do we plan to use?

2013-10-15 Thread Alex Harui
Interesting. I was thinking that the opt-in for drag/drop code is in the definition of the component itself. Either you would take some base container and somehow add the dragging bead to it, or choose a base class that had it baked in, maybe a subclass of Panel called DraggablePanel. I didn't e

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Alex Harui
On 10/15/13 9:52 AM, "Maurice Amsellem" wrote: >>I will try to generate and check in png.xml files for the two failing >>tests > >Not sure to understand what png.xml files are ? the baseline pngs ? A png.xml file is an XML description of the display list. We use them when different player vers

RE: [Mustella] FP crash on VM

2013-10-15 Thread Kessler CTR Mark J
I don't know about capturing the crash but could kill the processes from a script. [1] http://technet.microsoft.com/en-us/library/cc725602.aspx -Mark -Original Message- From: Erik de Bruin [mailto:e...@ixsoftware.nl] Sent: Tuesday, October 15, 2013 10:00 AM To: dev@flex.apache.org Sub

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
>I will try to generate and check in png.xml files for the two failing tests Not sure to understand what png.xml files are ? the baseline pngs ? >If you have more cycles you can then see if it makes the tests pass and then >check in, or if you are completely out of time if you can post the patch

Re: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Alex Harui
I will try to generate and check in png.xml files for the two failing tests. If you have more cycles you can then see if it makes the tests pass and then check in, or if you are completely out of time if you can post the patch I'll try it with the png.xml files. On 10/15/13 2:40 AM, "Maurice Amse

Re: [Mustella] FP crash on VM

2013-10-15 Thread Alex Harui
In mustella/as3/ContinueAfterRuntimeException is a Windows C++ app we used to use to kill off the player. The code will probably need some fixing but it might serve as a starting point to have a watchdog to try to kill the player task. Then maybe you won't need to restart Jenkins? -Alex On 10/

RE: [FlexJS] how much of Google closure goodies do we plan to use?

2013-10-15 Thread Sharma, Pratyoosh
Makes sense, however there are practical considerations. There are 2 ways in which people enable dragging on components: Style 1: PopUp.createPopUp(PopUpComponent: PopupContent,parentComponent: this,Title: "Component Popup Test", dragEnabled: true, Modal:true);//default for dragEnabled can be t

[Mustella] FP crash on VM

2013-10-15 Thread Erik de Bruin
Hi, After about a week of continuous runs, the Flash Player crashes (sometimes after a day, sometimes it lasts 2 whole weeks). This hangs the Mustella run until I catch it. Does anyone know of a way to capture the crash and reset and restart the Jenkins jobs? We're talking Win2008 here. Thanks,

Re: How to prevent IDEA from opening SWF files

2013-10-15 Thread Alexander Doroshko
You shouldn't add SWF files to Ignored as a workaround. If you ignore SWF files then IntelliJ doesn't decompile them and can't resolve classes from playerglobal.swc and others (because all swc files contain library.swf inside with the compiled code). Workaround is not to expand this folder in t

RE: How to prevent IDEA from opening SWF files

2013-10-15 Thread Maurice Amsellem
Thanks Alexander, I posted a comment on the issue to notify of a strange side effect when applying the workaround (adding "*.swf" to the Ignore files an folders). Maurice -Message d'origine- De : Alexander Doroshko [mailto:alexander.doros...@jetbrains.com] Envoyé : mardi 15 octobre 20

Re: How to prevent IDEA from opening SWF files

2013-10-15 Thread Alexander Doroshko
Thank you, the issue is fixed in IntelliJ IDEA 13 branch (http://youtrack.jetbrains.com/issue/IDEA-114904). I wish anybody reported it earlier so that the fix could go to 12.1.x. On 15.10.2013 10:50, Maurice Amsellem wrote: Sorry, I didn't use the right word. I mean IDEA becomes frozen during a

RE: Build failed in Jenkins: flex-sdk_mustella #470

2013-10-15 Thread Maurice Amsellem
Hi, quick status of failing tests: 1) gumbo/components/DataGrid/Properties/DataGrid_requireSelection_test001 requireSelection_test15 mustella\tests\gumbo\components\DataGrid\SWFs\components\DataGrid_comp3.mxml resetDP() method is incorrect. It creates a temp var that is never used, and the d

Re: Changes I want to make before RC2

2013-10-15 Thread OmPrakash Muppirala
On Mon, Oct 14, 2013 at 3:16 PM, OmPrakash Muppirala wrote: > Just putting it out there so that I get some more time: > > 1. Fixes for 640 dpi and 480 dpi skins (will finish this tonight) > I am done with this. Please test and let me know if you would like to see some more tweaks. > 2. Updat

RE: Debugging Mustella tests in Flash Builder

2013-10-15 Thread Maurice Amsellem
I have adapted the script below to IDEA. - Create a Mustella project and set the sources to the test case to test Eg. flex-sdk\mustella\tests\components\DataGrid\DataGrid_SparkSkin - Check "Skip Compilation" - Start the mini_run to generate the DataGridApp.SWF. - Create a mustell Run configurat