Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Alex Harui
On 4/5/17, 10:03 AM, "Harbs" wrote: >That would be great. > >We need better test coverage. If we could get easy test setup for FlexJS, >that would be a huge win. Not sure how you define "easy" but we've had mustella running on FlexJS for quite a while now. It allows

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Peter, I just tried your changes and check MDLExample and MDLDynamicTabsExample. In MDLExample: TextFields are not displayed In MDLDynamicTabsExample: I see that switching between tabs, once I add Tab dynamically is broken. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this

Re: [FlexJS, Maven] Build library project type to js only swc

2017-04-05 Thread piotrz
Chris, Thank you that was it. I was able to build library, but the swc result do not contain information which I required. In generated swc I see all js files, but in catalog.xml library tag is empty and I don't see components tag as it is in other swc inside FlexJS SDK etc, I have only in tag

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Peter Ent
I have decided not to merge today. I ran an example with DataGrid embedded within a Container and sized to width="100%" and it did not respond properly to the resize. I know what happened, just working on how to make it work correctly. ‹peter On 4/5/17, 1:35 PM, "piotrz"

Re: [FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread Alex Harui
Most of source forge download is for font embedding. At one point you mentioned the possibility that you could write new font transcoder. That would truly be an awesome thing. Get Outlook for Android From: Christofer Dutz

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Peter I just merged falcon develop branch to your chart-work. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61027.html Sent from the Apache Flex

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Thanks Peter. I'm ok with merge then. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Merge-feature-chart-work-into-develop-tp61019p61026.html Sent from the Apache Flex Development mailing list

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Peter Ent
I just changed Menu to extend DataContainer and now that works fine, for me, in MDLExample. Thank you for reminding me. ‹peter On 4/5/17, 11:37 AM, "piotrz" wrote: >Hi Peter, > >I didn't check MDLExample after your last push, but didn't you mention >that >MDL Menu is

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Christofer Dutz
Hi Harbs, Have you had a look at the Integration Test project in FlexJS? I doubt it would get much simpler: - The Maven build automatically: o Downloads, configures and starts a tomcat server o Deploys all examples as web applications o As soon as the server is up and the applications as

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Harbs
That would be great. We need better test coverage. If we could get easy test setup for FlexJS, that would be a huge win. > On Apr 5, 2017, at 12:33 PM, Christofer Dutz > wrote: > > I would start writing some simple Selenium Tests for these applications

Re: [FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread Christofer Dutz
I would eventually like to get rid of the dependency to the artifacts downloaded from SourceForge. Right now, I don’t quite remember what they are needed for. But I’ll wait till things are blue again as I currently can’t quality asure anything. I just did a quick check and it should be enough

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Christofer Dutz
Hi Peter, If it improves things, I am fine with this merge. If it adds more areas that need fixing then I don’t. As soon as things start to work again, I would start writing some simple Selenium Tests for these applications to ensure they are tested in the future. Chris Am 05.04.17, 17:37

Re: [FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread piotrz
Hi Peter, I didn't check MDLExample after your last push, but didn't you mention that MDL Menu is blank ? If it's not working I would say -1 till we have it look ok. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

[FlexJS] Merge feature/chart-work into develop

2017-04-05 Thread Peter Ent
Hi, I would like to merge the feature/chart-work into the develop branch in about 5 hours from now which would make it 4:30pm EDT (9:30pm UTC, I think). Does anyone have a strong objection to that? To recap: The thrust of this feature branch was to get Charts working, but that lead to

Re: [FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread Alex Harui
On 4/5/17, 5:09 AM, "Christofer Dutz" wrote: >Hi, > >Well I addressed this in the Pipeline build. This is one job and it fails >if any of the builds in the pipeline fail. If you committed something and >it fails, the chances are high, that it’s related to your

Re: [FlexJS, Maven] Build library project type to js only swc

2017-04-05 Thread Harbs
Make sure you include js.swc as an external library. > On Apr 5, 2017, at 1:48 AM, piotrz wrote: > > Hi Harbs, > > It look like to me that Maven is doing everything what you are showing me in > build.xml at some point automatically. > > Cause generated by maven

Re: [FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread Christofer Dutz
Hi, Well I addressed this in the Pipeline build. This is one job and it fails if any of the builds in the pipeline fail. If you committed something and it fails, the chances are high, that it’s related to your changes. I usually double check the build after committing things. But I guess the

Re: [FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread yishayw
Probably a good idea. I have two concerns. One is how to make it clear to the committer that s/he needs to make things work. When the build is broken it's at least clear that it needs to be fixed ASAP. The other is how to identify the faulty component. If Falcon is broken problems might manifest

[FlexJS] [Discuss] Automate stabilizing 'develop'?

2017-04-05 Thread Christofer Dutz
Hi, As we are now in our 13th day of red builds I would like to propose an automated approach in keeping develop operational. How about implementing an automatism, that automatically creates a new feature branch, if the build on develop fails for more than a day and then reverts develop back

Re: [FlexJS] flex-asjs build failing

2017-04-05 Thread Christofer Dutz
I just updated the RAT exclusions in compiler and framework to be more resilient against activation/deactivation of maven profiles. However it still has problems when running Maven after running ANT. Chris Am 05.04.17, 12:35 schrieb "Christofer Dutz" : Hi

Re: [FlexJS] flex-asjs build failing

2017-04-05 Thread yishayw
Yes, I did. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-FlexJS-flex-asjs-build-failing-tp61000p61012.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

RE: [FlexJS] flex-asjs build failing

2017-04-05 Thread Yishay Weiss
I did. Sent from Mail for Windows 10 From: Yishay Weiss Sent: Wednesday, April 5, 2017 1:37 PM To: dev@flex.apache.org Subject: RE: [FlexJS] flex-asjs build failing Hi Chris, You’re

RE: [FlexJS] flex-asjs build failing

2017-04-05 Thread Yishay Weiss
Hi Chris, You’re right. That’s why I said to ignore that mail. I was mixing Ant and Maven. The font download problem is on a Maven only env. Yishay From: Christofer Dutz Sent: Wednesday, April 5, 2017 1:35 PM To: dev@flex.apache.org

Re: [FlexJS] flex-asjs build failing

2017-04-05 Thread Christofer Dutz
Did you download the two jars in JCE libs into %JAVA_HOME%/jre/lib/security? Chris Am 05.04.17, 10:13 schrieb "yishayw" : Ignore this mail. Fontkit download is still failing. yishayw wrote > I think I got passed the fontkit problem by copying the

Re: [FlexJS] flex-asjs build failing

2017-04-05 Thread Christofer Dutz
Hi Yishay, I guess that problem is related to running the build in Ant and Maven. I think the Ant build used to download stuff into the “source” directories so you had checked in stuff and not checked in stuff. I would assume the complaints are related to that. Another reason could be that you

Re: AW: AW: [FlexJS] flex-asjs build failing

2017-04-05 Thread yishayw
Ignore this mail. Fontkit download is still failing. yishayw wrote > I think I got passed the fontkit problem by copying the contents of > > %JAVA_HOME%/../jre/lib/security > to > %JAVA_HOME%/lib/security > > (Copying it to %JAVA_HOME%/jre/lib/security didn't make a different to > me.)

Re: AW: AW: [FlexJS] flex-asjs build failing

2017-04-05 Thread yishayw
I think I got passed the fontkit problem by copying the contents of %JAVA_HOME%/../jre/lib/security to %JAVA_HOME%/lib/security (Copying it to %JAVA_HOME%/jre/lib/security didn't make a different to me.) Apparently there's a bunch of files other than local_policy.jar and US_export_policy.jar

Re: [FlexJS, Maven] Build library project type to js only swc

2017-04-05 Thread Christofer Dutz
Hi Piotr, You can tell Maven to skip the flash compilation by setting the configuration option “skipAS” to true. You can tell Maven to skip js by setting the configuration option “skipJS” to true. Think that was what you were looking for, correct? Chris Am 05.04.17, 07:48 schrieb "piotrz"

Re: [FlexJS, Maven] Build library project type to js only swc

2017-04-05 Thread Alex Harui
FWIW, this should also be easier in the dual branch since there will then be a SWC for SWF and a SWC for JS and you could just skip the SWC for SWF. Someday, I hope to get back to the merge after getting these dependencies issues and the build fixed. -Alex On 4/4/17, 10:48 PM, "piotrz"