Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread Josh Tynjala
I could not find a way to parse extra command line arguments with an npm install command. If you could figure that out, that would be better! - Josh On May 30, 2017 6:56 PM, "OmPrakash Muppirala" wrote: Awesome! I had this as a TODO. I can at least help with testing this out now. I can also p

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread OmPrakash Muppirala
Awesome! I had this as a TODO. I can at least help with testing this out now. I can also push the bits to the npm registry when we go live with the release. Also, what if we pass them as command line args? Do you mind if I make this change? Thanks, Om On May 30, 2017 11:47 AM, "Josh Tynjala"

Re: [FlexJS] Is TLF Branch Building

2017-05-30 Thread Alex Harui
OK, I pushed it. On 5/29/17, 12:08 PM, "Harbs" wrote: >Push it. > >I’ll need to migrate to dual at some point and now is as good a time as >any. > >> On May 29, 2017, at 7:11 PM, Alex Harui >>wrote: >> >> Harbs, Yishay, >> >> I got through the nasty bug but hit another. But I'm wondering if

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread Alex Harui
Excellent! Very helpful. I am still fixing issues of Dual and the TLF branch. It found some good bugs. -Alex On 5/30/17, 11:46 AM, "Josh Tynjala" wrote: >I got the npm version of FlexJS 0.8.0 working with a couple of minor >fixes. >It looks good to go for the release! > >I also simplified ho

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread Josh Tynjala
I got the npm version of FlexJS 0.8.0 working with a couple of minor fixes. It looks good to go for the release! I also simplified how to test the npm version locally from the flex-utilities repo to make it download nightly builds (previously, you needed to manually change some JS code): cd flex-

Re: [FlexJS] Accordion broken

2017-05-30 Thread Peter Ent
OK, thanks. Alex some alternative layouts I can try. —peter On 5/30/17, 11:35 AM, "Harbs" wrote: >The reasons it’s broken is (at least) thee-fold: > >1. Panels contain content and need to be collapsed despite the fact that >content exists. >2. The Collapse bead can only infer that it’s collapsed

Re: [FlexJS] Accordion broken

2017-05-30 Thread Harbs
The reasons it’s broken is (at least) thee-fold: 1. Panels contain content and need to be collapsed despite the fact that content exists. 2. The Collapse bead can only infer that it’s collapsed by the fact that the size is the collapsed size — which only makes sense if the size is set. 3. The ti

Re: [FlexJS] Accordion broken

2017-05-30 Thread Harbs
Something like this: This is the markup of an Accordion which used to work, which doesn’t anymore.

Re: [FlexJS] Accordion broken

2017-05-30 Thread Peter Ent
Hi, Do you have a quick example of how to use the FlexJS Accordion? The ASDoc on it is thin. The children of the Flex SDK Accordion were navigation components that supported things like title so each section could be labeled. I don't see an AccordionChild or something similar that can be used with

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread Josh Tynjala
Isn't this going to be the first release of FlexJS that includes MDL and Express? Both of these new component sets are a pretty big deal. Let's make sure that they get proper recognition in the RELEASE_NOTES! - Josh

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

2017-05-30 Thread piotrz
Hi Josh, That's a good point! Could you please add that information ? If not I will do this but much later today. Thanks! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-Falco

Re: [FlexJS] Accordion broken

2017-05-30 Thread Peter Ent
I am looking into it. I will also create an example for Accordion so it will be easier to test it in the future. ‹peter On 5/30/17, 6:39 AM, "Harbs" wrote: >It seems like the new layouts totally broke Accordion. > >Accordion relied on absolute sizing to handle expanding and collapsing of >conten

[FlexJS] Accordion broken

2017-05-30 Thread Harbs
It seems like the new layouts totally broke Accordion. Accordion relied on absolute sizing to handle expanding and collapsing of content. I tried to add a new layout which is basically a copy of the old OneFlexibleVerticalLayout and use that for accordion, but that does not seem to work either