Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Alex Harui
This was first published in 2012. https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype PAYG and avoiding just-in-case code is mentioned in that document. As are Beads. Thanks, -Alex On 6/5/17, 11:33 PM, "Greg Dove" wrote: >Harbs, a quick comment from the sidelines on: "PA

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Harbs
The wiki from 4 years ago is very helpful in understanding architectural decisions: https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype If you have suggestions to make things clearer then by all means

Re: [FlexJS] DataBinding Problem

2017-06-05 Thread Alex Harui
I have local changes that fixes Binding in Accordion by changing the lifecycle of the underlying Panel that AccordionItemRenderer subclasses. I'll push them before I shut down for the day. I want to try to fix the TitleBar height issue on JS first. The reasoning is that ItemRenderers are supposed

Re: [FlexJS] DataBinding Problem

2017-06-05 Thread piotrz
Alex, I was thinking about that more and more. I think the way how MXMLBeadViewDataBinding decided what binding has been chosen in case of TitleBarView is ok. - We probably shouldn't change anything in that matter. Exchange model - That's more global thing - cause if we allow for this in case of

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Greg Dove
Harbs, a quick comment from the sidelines on: "PAYG is already well understood" I don't really think that is the case, at least it has not been for me. I had a more general notion of PAYG that was nothing to do with beads at all, and was limited to guesswork/my own interpretation of it at the begi

Re: [FlexJS] DataBinding Problem

2017-06-05 Thread yishayw
It's actually MXMLBeadViewDataBinding. The simplest solution may be to avoid using binding in TitleBarView and explicitly listen to TitleBar's "modelChanged" event and TitleBarModel's "titleChange" event. But any other solution is fine by me. -- View this message in context: http://apache-flex-

Re: [FlexJS] Accordion broken

2017-06-05 Thread yishayw
Not sure I understand. Is release Accordion working with the example I posted [1]? I just fetched and logged flex-asjs and couldn't see any accordion related changes. Can you send a commit id? Thanks. [1] https://paste.apache.org/QUj1 -- View this message in context: http://apache-flex-deve

Finding tools in the toolbox

2017-06-05 Thread Harbs
One of the most difficult part of dealing with FlexJS and beads is knowing what beads are available and what beads are interchangeable. I think we need a system to programmatically be able to look up bead and strand relationships. This could be used by documentation as well as tooling to give h

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Harbs
We’ve all already been implementing things as Alex states. He architected the framework and it’s a good architecture. No need to change things. We need consistent architecture. We can’t have a free-for-all... Percentage of code really has nothing to do with it. Unless something is functionality

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread piotrz
Another thing - How to resolve this thread ? 1) Setting strand to null - let say that is fine and there is no NO for that - Am I right ? 2) Some code which maybe can be extracted to separate bead. For 2 I have an ide: 1 - Revert back 2 - Create Separate bead for cleaning 3 - Create in Express be

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread piotrz
+1 for documenting it and stick with it. - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect-tp62092p62128.html Sent from the Apache Flex Development mailing list a

Re: Private properties are undefined in JS and null in AS

2017-06-05 Thread Justin Mclean
Hi, > Are you using a Sonar Cube plugin for ActionScript? Using a JS review of > AS is likely to be inaccurate, IMO. It’s AS see [1] > it may turn out that at runtime, there is no difference > between "==" and "===" for ints. For int the is less of a difference but as discussed it depends if J

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Justin Mclean
Hi, > If you have a different vision, you can execute that vision in another > component set or fork FlexJS entirely. Please do not impose your vision > on my vision. Since when is this your project Alex or that the project has to only include your vision? That is not the Apache way. I would p

Re: [FlexJS] DataBinding Problem

2017-06-05 Thread Alex Harui
SimpleBinding is tuned for simple cases. It doesn't expect the object it is watching to change, just its properties. GenericBinding will watch for that, but the DataBinding implementation has to choose GenericBinding. It should be ok for objects to share models as long as it is done "early" in t

Re: [FlexJS] more on undefined / non initialised values

2017-06-05 Thread Justin Mclean
Hi, > I believe in AS, there is no way to have > > if (b === false) > > Have any semantically different meaning than > > if (b) One will check for false the other true so they have opposite meaning. You'll also note I stated “b == false” not “b === false”. Currently for an unini

Re: [FlexJS] DataBinding Problem

2017-06-05 Thread piotrz
Hi Yishay, I did spent some time on this but cannot find so far why binding is not working after model change. I think it should be. There is SimpleBinding class involve in all of this. Array _bindings [1] seems to contains everything what needed, but maybe we should react somewhere on "modelCha

Re: [FlexJS] List

2017-06-05 Thread Peter Ent
Yes. I think people expect lists to scroll by default. Sorry I missed that when I made those changes. —peter On 6/5/17, 1:43 PM, "Harbs" wrote: >That’s what I did for my app css. Changing it to ScrollingViewport fixed >it. > >I did not know whether I should change defaults.css in Basic. It sound

Re: dual issues

2017-06-05 Thread Harbs
In compilerOptions. Here’s my tasks.json file: { // See https://go.microsoft.com/fwlink/?LinkId=733558 // for the documentation about the tasks.json format "version": "0.1.0", "command": "asconfigc", "isShellCommand": true, "args": [

Re: [FlexJS] List

2017-06-05 Thread Harbs
That’s what I did for my app css. Changing it to ScrollingViewport fixed it. I did not know whether I should change defaults.css in Basic. It sounds like you are saying yes. > On Jun 5, 2017, at 5:25 PM, Peter Ent wrote: > > That had to be accidental. I see in defaults.css that List has a View

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread piotrz
Something cutted my email. If the answer to that question is yes - Let's have it. That is how I'm thinking about FlexJS. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInput

Re: Private properties are undefined in JS and null in AS

2017-06-05 Thread Josh Tynjala
> Again, think of the allowed patterns when coming from AS, not all possible JS patterns. I keep seeing you say something like this, Alex. However, Justin is pointing out perfectly valid AS patterns that are failing in our generated JS. - Josh On Mon, Jun 5, 2017 at 8:37 AM, Alex Harui wrote:

Odgovor: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

2017-06-05 Thread Silvije Mudri
 Bok na.   Poslano s pametnog telefona BlackBerry 10.   Originalna poruka   Šalje: Piotr Zarzycki Poslano: ponedjeljak, 5. lipnja 2017. 17:26 Prima: dev@flex.apache.org Odgovor za: dev@flex.apache.org Predmet: Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text wh

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread piotrz
Hi, Ahh I saw your commit and respond to it, but somehow miss this discussion. It seems to be again different thoughts and view of what is PAYG. PAYG for me is: Whenever I can extract something (code - one thing) into separate class called - Bead - which can be reusable or switch ON/OFF something

Re: Private properties are undefined in JS and null in AS

2017-06-05 Thread Alex Harui
On 6/4/17, 1:52 AM, "Justin Mclean" wrote: >Hi, > >> Here is a link [1] to you saying "I’m a strong believer in getting it to >> work first, then optimise it, premature optimisation wastes time and >>often >> makes incorrect assumptions.” > >That’s exactly what I’m doing. I has something that w

Re: [FlexJS] more on undefined / non initialised values

2017-06-05 Thread Alex Harui
Sounds like there is no one right answer, so we should offer choices in compiler output. To me, if there are valid and common AS coding patterns that don't require initialization, I would happily use them and make changes where warnings detect unsafe usage. IOW, for var b:Boolean; I believe in

Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - set input type back to text when bead is removed

2017-06-05 Thread Piotr Zarzycki
Hi Justin, Can it be close as part of separate bead ? What actually are you doing here ? Piotr 2017-06-05 5:19 GMT+02:00 : > set input type back to text when bead is removed > > > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo > Commit: http://git-wip-us.apache.org/repos/asf/fle

Re: [FlexJS] Removing PasswordInputBead has no effect

2017-06-05 Thread Alex Harui
On 6/4/17, 9:46 PM, "Justin Mclean" wrote: >Hi, > >Sorry autocorrect seems to have got the better of me - correcting: > >I think you are forgetting the optimisation that goes on, yes the source >code has a few more lines of code, but hardly double the size. > >Perhaps we can come up with some r

Re: [FlexJS] Layout of NumericStepper is broken

2017-06-05 Thread Alex Harui
Run the FlexJSStore example and go to the Products tab. NumericStepper looks fine to me there. -Alex On 6/5/17, 7:49 AM, "piotrz" wrote: >Hi Peter, > >It is Windows 10 and Chrome 59.0.3071.82 >I tried also on Firefox: 53.0.3 (32 bits) > >Piotr > > > >- >Apache Flex PMC >piotrzarzyck...@gma

Re: [FlexJS] Layout of NumericStepper is broken

2017-06-05 Thread piotrz
Hi Peter, It is Windows 10 and Chrome 59.0.3071.82 I tried also on Firefox: 53.0.3 (32 bits) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Layout-of-NumericStepper-is-broken-tp62108p62110.html

Re: [FlexJS] Layout of NumericStepper is broken

2017-06-05 Thread Peter Ent
I'm looking into it. The SWF and JS versions are different. There's a border around it, which is specified in the defaults.css. I'm not sure why that is there; maybe I put it there awhile ago I just don't remember. It looks better without it. The SWF version, for me, has some extra graphics in the

[FlexJS] Layout of NumericStepper is broken

2017-06-05 Thread piotrz
Hi, I just tried NumericStepper on our release branch and it looks horrible. I have following code [1], can someone look into that ? I will raise jira later. [1] https://paste.apache.org/wbLN Piotr

Re: [FlexJS] List

2017-06-05 Thread Peter Ent
That had to be accidental. I see in defaults.css that List has a Viewport rather than ScrollingViewport. Just change that and lists should default to scrolling. Need to watch the DataGrid because its lists should not scroll - they just grow and the enclosing container scrolls them all together. ‹

Re: [FlexJS] Accordion broken

2017-06-05 Thread Peter Ent
I haven't sync'd anything since Friday, but I don't seem to be having the measurement problem you are talking about. I changed the Accordion children to VContainer and added the TitleBarModel. Now I see the TitleBar (although it is blank) and the segment contents. When I expose or hide the segment

Re: dual issues

2017-06-05 Thread Josh Tynjala
Are you setting debug in an argument passed to asconfigc, like this? asconfigc --debug=false Or is it specified in asconfig.json in the compilerOptions section? Both will work, but the asconfigc command line option will always override whatever is in asconfig.json. In VSCode, the generated tasks

Fwd: [jira] [Updated] (FLEX-35321) LayoutManager initializes components which are no longer on stage

2017-06-05 Thread Mihai Chira
Hi all, I just want to make sure that my assumptions about LayoutManager are sound. This behavior (which I would personally catalogue as a bug) is causing our application some problems: dialogues initialised after they've been removed from stage, thus triggering their mediators' onRegister method (

[FlexJS] List

2017-06-05 Thread Harbs
It looks like List defaults to overflow: hidden while it used to allow scrolling by default. Was this an intentional change?