Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi - > On Jun 12, 2017, at 12:41 PM, Alex Harui wrote: > > I'm confused. Can I get a summary? > > Are there some files that are being caught by RAT? If so, what are they? > > Are we sure the process should be that the RM should switch away from > SNAPSHOT before

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Justin - you did state that you consider this acceptable for this release and > that we can clean it up for the next. Yes I stated that in my vote and that would be acceptable. Thanks, Justin

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi - > On Jun 12, 2017, at 3:34 PM, Justin Mclean wrote: > > Hi, > >> Are there some files that are being caught by RAT? If so, what are they? > > I mentioned them in my vote email. [1] 3 patch files don’t have ASF headers. We may need to revisit the project’s

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Are there some files that are being caught by RAT? If so, what are they? I mentioned them in my vote email. [1] 3 patch files don’t have ASF headers. > IMO, the main thing folks want from Maven are the JARs which aren't an > official ASF release anyway. Seems like we should vote on a

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Replying to Yishay and Alex: Last time I took the release source bundle, changed the versions and ran a release build. Even if this worked, it was just a hack and technically we published release artifacts that are different than the version we voted on. So, someone who downloads the release

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Can you run the player from the command line? From a batch file? Get Outlook for Android From: yishayw Sent: Monday, June 12, 2017 12:38:53 PM To: dev@flex.apache.org Subject: Re: [VOTE] Release Apache FlexJS 0.8.0

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Guys, Can we please have this discussion in [Discuss] thread? Thank you! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/VOTE-Release-Apache-FlexJS-0-8-0-RC1-tp62273p62360.html Sent from the Apache

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

>Is it set to C:\dev\flashflashplayer_25_sa_debug.exe Yes. >Does the player open up and try to run the flex unit test? No. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/VOTE-Release-Apache-FlexJS-0-8-0-RC1-tp62273p62359.html Sent from the Apache Flex

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Is it set to C:\dev\flashflashplayer_25_sa_debug.exe Does the player open up and try to run the flex unit test? There might be some issue with it being launched from Ant. -Alex On 6/12/17, 12:31 PM, "yishayw" wrote: >It's set to C:\dev\flash where

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Actually, it's set to C:\dev\flash\flashplayer_25_sa_debug.exe which exists. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/VOTE-Release-Apache-FlexJS-0-8-0-RC1-tp62273p62357.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

It's set to C:\dev\flash where flashplayer_25_sa_debug.exe exists. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/VOTE-Release-Apache-FlexJS-0-8-0-RC1-tp62273p62356.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

I'm confused. Can I get a summary? Are there some files that are being caught by RAT? If so, what are they? Are we sure the process should be that the RM should switch away from SNAPSHOT before the vote? If a major problem is found in that RC, wouldn't we have deployed bad artifacts under the

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Is FLASHPLAYER_DEBUGGER environment variable set properly? -Alex On 6/12/17, 12:13 PM, "yishayw" wrote: >I can, I guess there was a network glitch. The recurring problem is that >unit >tests don't run and I get a socket timeout: >

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

I can, I guess there was a network glitch. The recurring problem is that unit tests don't run and I get a socket timeout: C:\dev\flexjs\flex-asjs\frameworks\projects\Basic\src\test\flex\build.xml:154: java.util.concurrent.ExecutionException: Socket timeout waiting for flexunit report at

Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

I think there are two separate issues. "Proxy and Wrappers" and "Content Areas". Panel and ScrollingViewports on certain platforms require "Content Areas", a separate DOM widget that actually holds the children. Right now we override addElement and add a $addElement. I think that's probably as

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

See if you can get to archive.apache.org via the browser. -Alex On 6/12/17, 7:42 AM, "yishayw" wrote: >I keep getting the below message when running the approval script. I >closed >all browsers prior to running the script. Any tips? > >BUILD FAILED

Re: [FlexJS] more on undefined / non initialised values

Sounds like the Google Closure compiler can optimize out unnecessary initialization, so I think the plan of finishing up adding initialization is the right change for the our compiler. At least, that how I understand the situation, -Alex On 6/12/17, 8:16 AM, "Peter Ent"

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Doesn't this logic mean that all the releases up to now have been invalid? It seems to me there is some interest in the extended community to see a release out. Looking at the RELEASE_NOTES I see lots of nice new features and bug fixes, which would be beneficial to people who want to start using

Re: [FlexJS] more on undefined / non initialised values

Perhaps we can look to other languages for guidance. For example, in Swift: var val:Boolean is illegal. It MUST be initialized or declared to be optional: var val:Boolean = false var val:Boolean? The Swift people felt that leaving variables uninitialized and defaulted caused too many issues

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

I keep getting the below message when running the approval script. I closed all browsers prior to running the script. Any tips? BUILD FAILED C:\dev\release\ApproveFlexJS.xml:742: java.net.UnknownHostException: archive.apache.org at

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

I tried the approval XML script. +1 Package https://dist.apache.org/repos/dist/dev/flex/flexjs/0.8.0/rc1/apache-flex-fl exjs-0.8.0-src.tar.gz Java 1.7 OS: Mac OS X x86_64 10.12.5 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is

Re: [2/4] git commit: [flex-asjs] [refs/heads/develop] - LayoutBase Fix for strand set to null in remove bead, plus performance improvements in js

Maybe I'm misunderstanding again. This is what a developer should do so that the contents of the panel are laid out horizontally. I constructed Panel as a subclass of Group so that I could take advantage of VerticalFlexLayout so that Container content area of the Panel would grow to

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi Piotr, No … all good ( I’d be happy to document things that help someone that wants to dig into Maven. Right now, most of my free dev-time is going to other Apache projects so my time is limited, but documenting this a little should be ok. Chris Am 12.06.17, 13:25 schrieb "piotrz"

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Chris, I hope I didn't offend you or something. I would like to understand it clearly in order to do this if you will not be available in the next release cause of other tasks. Do we have your steps on confluence ? If not will you have some time to put there as part of release process ? Thanks,

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

It should be between the Last call and opening the vote. It is equal to “cutting the release candidate”. So, the LAST CALL thread is finished and the RM writes that he’s going to cut a release … AFTER THAT he does these steps and THEN he opens the vote thread. I never said anything else than

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Chris, I'm a bit confused. You have said that I shouldn't do this as part of VOTING, LAST CALL: "No, The removing the SNAPSHOT, tagging and setting the new version should be, more or less, one step. " Now you are saying just opposite. So again when I should do this (Last Call, Voting) step ?

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

-1 (binding) For the same reason Chris reported. Thanks 2017-06-12 11:24 GMT+02:00 Christofer Dutz : > Hi, > > I must report a “-1” too … > > I could successfully build the framework part with the following command: > mvn clean install -s ~/.m2/settings-test.xml >

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

-1 (binding) For the same reason Chris reported. Thanks 2017-06-12 11:08 GMT+02:00 Christofer Dutz : > Hi, > > I must report a “-1” (binding) … > > but in my case the typedefs are building correctly. Unfortunately, the > build produces SNAPSHOT versions and relies on

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

No, the steps should be done as part of creating the RC not after the vote. Otherwise you would be releasing something different than what was voted on. I remember is doing that for the 0.7.0 and we got quite a lot of questions from the different bots doing their checks. Chris Von meinem

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Ok. So all your steps are required for post VOTING. I didn't have problems when I was building sources downloaded by ApproveFlexJS script, but I will try again at home to make sure that I didn't have -Dskip.rat. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

No, The removing the SNAPSHOT, tagging and setting the new version should be, more or less, one step. The maven-release-plugin handles almost all of this in one step. So if your do a release:prepare all of this should happen. You can then have others checkout the tag and if all give their go,

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Chris, I still didn't get clear answer to my question. I would like to understand it in order to do this in the next release. I will try to clarify my questions: 1) Once release manager make "Last Call" - Should I remove SNAPSHOT from all poms on release branch ? 2) Should I do 1 during VOTING ?

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Actually not by removing the credentials … by using an empty settings.xml or none at all and having a default. My settings-test.xml only contains the location of the maven local repo and no other settings therefore Maven defaults to its built-in defaults (I did manually provide the artifacts

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Hi, I must report a “-1” too … I could successfully build the framework part with the following command: mvn clean install -s ~/.m2/settings-test.xml -Pbuild-examples,build-distribution -DdistributionTargetFolder=target/distribution

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > mvn clean install -Drat.skip=true -s ~/.m2/settings-test.xml > > (My settings-test.xml simply excludes the Apache snapshot repo) So by just removing this right? apache.snapshots.https jmclean X If so I’m still getting this: error: patch failed:

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

2017-06-12 11:03 GMT+02:00 Christofer Dutz : > > But not being able to release stuff to Maven-Central is reason enough for > a -1 … sorry for that … next RC should also handle the version numbers of > the maven pom as I described them in my last post to this thread. > >

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, I must report a “-1” (binding) … but in my case the typedefs are building correctly. Unfortunately, the build produces SNAPSHOT versions and relies on SNAPSHOT versions. We can’t publish this to the Apache Release repo and not have these released to Maven-Central. This is a major issue

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Ok … so I setup a build that doesn’t accidentally pull in SNAPSHOTS from the Apache repo: mvn clean install -Drat.skip=true -s ~/.m2/settings-test.xml (My settings-test.xml simply excludes the Apache snapshot repo) One thing I found (no this is not going to be a legal thing … I am reporting

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, Locally I have been using Maven for 4 months or so to build Falcon / FlexJS and haven’t run into any major issues expect when the dual branch was first merged and in the last couple of days so obviously something has changed recently that stops this from working. Thanks, Justin

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Carlos, We had pretty long discussion on ApacheCon about that. I hope we will get the point where Maven will be the main builder for the framework. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi Piotrz, sorry, but I almost sure we decided to put maven as main way of building. I know how to build with ant with the approve xml, and did it other times for other releases, but I think is totally wrong with what we agreed in this list. Maybe I'm wrong but if not, It's almost strange to me

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Hi, Sorry -1 (binding) as unable to compile from source. Will change to +1 once I can and test build. It looks like this may be an issue with the typedef code bundled in the falcon RC1 release so it may be that that RC needs to change rather than this RC? I checked: - signatures and hashes

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Flex-typedefs code should be packaged in the -falconjx packages. I can see in that in the falcon source release when when I try to compile it I get the following error: error: patch failed: js/target/downloads/svg.js:401 error: js/target/downloads/svg.js: patch does not apply Thanks,

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi Chris, But you are saying what should happened once we are after release, not during Release Cut and Voting ? During that time we should still use SNAPSHOT ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

You were probably getting the SNAPSHOTS from the Apache SNAPSHOT repo. Ok … I promised not to invest any more of my time in issues related to the double-build-system, guess I’ll make an exception … 1) In order to have a proper Maven release, the versions of the maven build should be changed to

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, Here’s the link to the latest failure onto build server and you can see it’s typedef related. https://builds.apache.org/job/FlexJS%20Framework%20(maven)/953/console Thanks, Justin

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > I didn't get it and I was building by Maven straight from the sources > downloaded by ApproveFlexJS script. Are these the same sources that are in the release? Perhaps there’s an issue there BTW I’m also see the issue on develop branch and so is the apache build server. Thanks,

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi Justin, I didn't get it and I was building by Maven straight from the sources downloaded by ApproveFlexJS script. Can you try build typedefs and later SDK - what will happen ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] more on undefined / non initialised values

Justin seems to have observed the Google compiler stripping these out. It seems like a good idea to do some research on how extensively it does so. If we can rely on goog to do this work for us, then I’m fine with that. Either way, the performance implications one way or the other are