Re: [FlexJS] [Typedefs] [Maven] build issues

2017-06-07 Thread Christofer Dutz
The only 100% safe option in my opinion would be to create a tool to do the patching. This tool might simply be a wrapper around some open-source patch tool with a suitable license and provide a Maven goal to do the patching. For Ant a matching wrapper should make sure the patches are applied eq

Re: [FlexJS] [Typedefs] [Maven] build issues

2017-06-06 Thread Justin Mclean
Hi, > I think others may have experienced this also, at least I have seen similar > things mentioned previously. I’ve run into this issue before on OSX and it been discussed on list - was not able to find the root cause however. Thanks, Justin

AW: [FlexJS] [Typedefs] [Maven] build issues

2017-06-06 Thread Christofer Dutz
pache.org> Betreff: [FlexJS] [Typedefs] [Maven] build issues I have had a few issues with maven build of typedefs (in develop) over recent times. I think others may have experienced this also, at least I have seen similar things mentioned previously. For me this seems to be related to patches being

[FlexJS] [Typedefs] [Maven] build issues

2017-06-06 Thread Greg Dove
I have had a few issues with maven build of typedefs (in develop) over recent times. I think others may have experienced this also, at least I have seen similar things mentioned previously. For me this seems to be related to patches being applied when the content that is being downloaded is al

Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Josh Tynjala
I'd be cool with that! I don't like adding that extra argument to addEventListener() calls. - Josh On Sat, Mar 18, 2017 at 1:45 PM, Harbs wrote: > Thanks. > > I noticed that it was a general problem after I posted this question. > > Maybe we should patch the extern file? > > > On Mar 18, 2017,

Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Harbs
Thanks. I noticed that it was a general problem after I posted this question. Maybe we should patch the extern file? > On Mar 18, 2017, at 10:24 PM, Josh Tynjala wrote: > > It's not optional on the base interface where addEventListener() and > removeEventListener() are defined. I think it's Ev

Re: [FlexJS Typedefs]FileReader

2017-03-18 Thread Josh Tynjala
It's not optional on the base interface where addEventListener() and removeEventListener() are defined. I think it's EventTarget. Since subclasses and implementers of interfaces aren't allowed to change the signature of a method in ActionScript, externc uses the original signature and ignores the o

[FlexJS Typedefs]FileReader

2017-03-18 Thread Harbs
I found what looks like a bug in the FileReader typedefs: The following in fileapi.js: /** * @param {boolean=} opt_useCapture * @override * @return {undefined} */ FileReader.prototype.addEventListener = function(type, listener, opt_useCapture) {}; /** * @param {boolean=} opt_useCapture

Re: [FLEXJS, TYPEDEFS]

2016-07-29 Thread Justin Mclean
Hi, If fr any reason you want to turn off rat you can always do this: mvn -Drat.skip=true Justin

AW: AW: [FLEXJS, TYPEDEFS]

2016-07-28 Thread Christofer Dutz
: [FLEXJS, TYPEDEFS] Sound good to me, Chris I used ant super-clean first inside asjs, and then the maven build worked fine. :) The only thing that didn't seem to work for me then for the maven instructions was setting distributionTargetFolder - , I can verify this is valid, I can see the value

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-28 Thread Greg Dove
l be stuck adding exceptions for quite some time. > > > Chris > > > Von: Greg Dove > Gesendet: Mittwoch, 27. Juli 2016 21:55:39 > An: dev@flex.apache.org > Betreff: Re: AW: [FLEXJS, TYPEDEFS] > > Lastly Chris, after running thro

AW: AW: [FLEXJS, TYPEDEFS]

2016-07-28 Thread Christofer Dutz
ually cleans up everything). Otherwise we'll be stuck adding exceptions for quite some time. Chris Von: Greg Dove Gesendet: Mittwoch, 27. Juli 2016 21:55:39 An: dev@flex.apache.org Betreff: Re: AW: [FLEXJS, TYPEDEFS] Lastly Chris, after running through the m

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-27 Thread Greg Dove
point of view. I could however add it to the release profile, but >> then we would start encountering problems as soon as I would build a >> release candidate, which would be unfortunate. So could you guys please >> report the full relative paths of stuff RAT is complaining about

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-27 Thread Greg Dove
s please > report the full relative paths of stuff RAT is complaining about after > using Ant and I would take care of adding exclusions. > > > Chris > > > Von: Greg Dove > Gesendet: Mittwoch, 27. Juli 2016 07:29:28 > An: dev@flex.apache.org > Betreff: Re: AW: [FLEXJS

AW: AW: [FLEXJS, TYPEDEFS]

2016-07-26 Thread Christofer Dutz
sendet: Mittwoch, 27. Juli 2016 07:29:28 An: dev@flex.apache.org Betreff: Re: AW: [FLEXJS, TYPEDEFS] Chris, I also encountered similar issues with the frameworks build, and started adding extra tags for the rat {insert maven-esque word for "task"/plugin here} to ignore things like intellij f

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-26 Thread Greg Dove
iles not having Apache Headers in them ... usually the >> target/rat.txt file will contain a list of the violating files. >> >> >> Chris >> >> ____ >> Von: Peter Ent >> Gesendet: Dienstag, 26. Juli 2016 17:40:58 >> An: dev@flex

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-26 Thread Greg Dove
eaders in them ... usually the > target/rat.txt file will contain a list of the violating files. > > > Chris > > > Von: Peter Ent > Gesendet: Dienstag, 26. Juli 2016 17:40:58 > An: dev@flex.apache.org > Betreff: Re: AW: [FLEXJS, TYPEDEFS

AW: AW: [FLEXJS, TYPEDEFS]

2016-07-26 Thread Christofer Dutz
Chris Von: Peter Ent Gesendet: Dienstag, 26. Juli 2016 17:40:58 An: dev@flex.apache.org Betreff: Re: AW: [FLEXJS, TYPEDEFS] Hi, I just finished installing and running maven. I was able to build flex-falcon "utils" but when I went to build the compiler, it fa

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-26 Thread Peter Ent
> >Von: Peter Ent >Gesendet: Montag, 25. Juli 2016 20:05:49 >An: Alex Harui; dev@flex.apache.org >Betreff: Re: [FLEXJS, TYPEDEFS] > >Got this to work with help from Alex. I had FALCONJX_HOME pointing to an >old directory: flex-falcon/compile

AW: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Christofer Dutz
By the way ... did you give the Maven build a try? Chris Von: Peter Ent Gesendet: Montag, 25. Juli 2016 20:05:49 An: Alex Harui; dev@flex.apache.org Betreff: Re: [FLEXJS, TYPEDEFS] Got this to work with help from Alex. I had FALCONJX_HOME pointing to an old

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Peter Ent
be.com>>, "dev@flex.apache.org<mailto:dev@flex.apache.org>" mailto:dev@flex.apache.org>> Subject: Re: [FLEXJS, TYPEDEFS] Try ant all in falcon again. Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message-- From: Peter Ent Date: Mon, Jul 25

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Alex Harui
Try ant all in falcon again. Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message-- From: Peter Ent Date: Mon, Jul 25, 2016 7:56 AM To: dev@flex.apache.org; Subject:Re: [FLEXJS, TYPEDEFS] Running ant in flex-typedefs/jquery does not give the error and builds successfull

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Peter Ent
Running ant in flex-typedefs/jquery does not give the error and builds successfully. I do not have FLEX_FALCON environment var set at all. —peter On 7/25/16, 10:51 AM, "Alex Harui" wrote: >Go to flex-typedefs/jquery and run 'ant'. Do you get the same errors? If >so, do you have a FLEX_FALCON e

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Alex Harui
Go to flex-typedefs/jquery and run 'ant'. Do you get the same errors? If so, do you have a FLEX_FALCON environment variable pointing somewhere other than flex-falcon? -Alex On 7/25/16, 7:34 AM, "Peter Ent" wrote: >Yes, I had done that as well. So this time I did: > >typedefs: ant wipe >falco

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Harbs
Did you try clean all and ant all in flex-asjs? On Jul 25, 2016, at 5:34 PM, Peter Ent wrote: > Yes, I had done that as well. So this time I did: > > typedefs: ant wipe > falcon:ant wipe-all; ant all > > Get same errors below. > > On 7/25/16, 10:27 AM, "Alex Harui" wrote: > >> Did you

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Peter Ent
Yes, I had done that as well. So this time I did: typedefs: ant wipe falcon:ant wipe-all; ant all Get same errors below. On 7/25/16, 10:27 AM, "Alex Harui" wrote: >Did you also do a "wipe" in flex-typedefs? IIRC, that was the repo that >was on the wrong branch and could have left cruft.

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Alex Harui
Did you also do a "wipe" in flex-typedefs? IIRC, that was the repo that was on the wrong branch and could have left cruft. -Alex On 7/25/16, 7:23 AM, "Peter Ent" wrote: >So back to this. > >This morning I did a new pull from flex-falcon/typedefs/asjs just to be >certain, I think a couple of ne

Re: [FLEXJS, TYPEDEFS]

2016-07-25 Thread Peter Ent
So back to this. This morning I did a new pull from flex-falcon/typedefs/asjs just to be certain, I think a couple of new things came down. I did ant wipe-all in falcon followed by ant all. I get this error at the end of the build (below). Is falcon supposed to be built first? I'm assuming typede

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Alex Harui
I just did ant wipe-all and ant all in Falcon and it worked for me. Did you run 'ant wipe' in flex-typedefs after switching to the develop branch? Since that was the repo that was on the wrong branch it might have some cruft in it that is messing up the flex-falcon build. -Alex On 7/22/16, 1:33

Re: AW: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
--- Ursprüngliche Nachricht >Von: Peter Ent >Datum: 22.07.16 22:33 (GMT+01:00) >An: dev@flex.apache.org >Betreff: Re: [FLEXJS, TYPEDEFS] > >No joy. I did switch to develop branch of flex-typedefs. > >I sync'd with Falcon and did an ant all; that failed so I

AW: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Christofer Dutz
Could you eventually give the Maven build a try? Chris Von meinem Samsung Galaxy Smartphone gesendet. Ursprüngliche Nachricht Von: Peter Ent Datum: 22.07.16 22:33 (GMT+01:00) An: dev@flex.apache.org Betreff: Re: [FLEXJS, TYPEDEFS] No joy. I did switch to develop branch of

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
No joy. I did switch to develop branch of flex-typedefs. I sync'd with Falcon and did an ant all; that failed so I did a ant wipe-all and then ant all. That fails: download: [get] Getting: https://raw.githubusercontent.com/google/closure-compiler/master/contrib/ex terns/jquery-1.9.js

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
OK, thanks. On 7/22/16, 3:44 PM, "Alex Harui" wrote: >Did you switch to the develop branch in flex-typedefs? If you used the >standard folder naming and structure, the scripts should find it. You may >need to sync and build flex-falcon first. > >-Alex > >On 7/22/16, 12:13 PM, "Peter Ent" wro

Re: [FLEXJS, TYPEDEFS]

2016-07-22 Thread Alex Harui
Did you switch to the develop branch in flex-typedefs? If you used the standard folder naming and structure, the scripts should find it. You may need to sync and build flex-falcon first. -Alex On 7/22/16, 12:13 PM, "Peter Ent" wrote: >Just sync'd flex-asjs repo. Must have missed the email abo

[FLEXJS, TYPEDEFS]

2016-07-22 Thread Peter Ent
Just sync'd flex-asjs repo. Must have missed the email about it now requiring flex-typedefs. Cloned that and tried to build it using ant: /Users/pent/dev/flex-typedefs/build.xml:52: The following error occurred while executing this line: /Users/pent/dev/flex-typedefs/js/build.xml:29: src '/Us