Re: [GitHub] flex-falcon pull request: Compiler fixes related to js.swc

UNSUBSCRIBE On Tue, Jan 5, 2016 at 12:50 PM, adufilie wrote: > Github user adufilie commented on the pull request: > > https://github.com/apache/flex-falcon/pull/5#issuecomment-169110068 > > Object.prototype.toString() is included in the es3.js extern file, but > it

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user Harbs commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169267474 In my experience, there's two ways to automatically close the pull request: 1. including a comment: "This closes #5". (or whatever the pull request number is) when

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie closed the pull request at: https://github.com/apache/flex-falcon/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169336626 The patch didn't apply correctly. Commits were included that should have been replaced. I've created a new pull request to revert the bad commits and re-apply this

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169362450 @Harbs: Yes, that has been working for me, but for some reason, when I pulled the last set of changes there was a merge conflict and after resolving them, the system

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169368242 Sorry, I meant "git reset", not revert. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

GitHub user adufilie opened a pull request: https://github.com/apache/flex-falcon/pull/5 Compiler fixes related to js.swc You can merge this pull request into a Git repository by running: $ git pull https://github.com/adufilie/flex-falcon patch-4 Alternatively you can review

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169096483 Where was the toString() missing? That change seems to be breaking the CreateJS externs build. The classes generated from the externs generally don't include

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169106519 Wasn't toString() on Object? Then it doesn't need to exist on most other objects. But we do need to allow Number, int and uint to have their own toString() with

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169102408 toString() was missing in every class except Number, int, uint. I've found the problem and will add another commit here shortly. Sorry about that. --- If your

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169119427 I'm pretty sure it is that way so your subclasses of Object can override toString() although they can't add parameters to toString(). --- If your project is set up

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user joshtynjala commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169117059 Hmmm... strangely, toString() is not marked with the AS3 namespace in the API reference. However, if I recall correctly, it is AS3 instead of public in the

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169114711 Also, with the getStaticField/getInstanceField changes, 5 files of unit tests have compile errors. They are: TestAnnotationEnum, TestConstructor, TestExternChrome,

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user joshtynjala commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169118912 Okay, it appears that Number and other classes with custom toString() methods put it in the AS3 namespace. You can see that with [Number.toString() in the API

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169259473 I think the github integration scripts didn't quite work. Can you manually close the pull request? --- If your project is set up for it, you can reply to this email

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169221139 Ok, I've reworked and updated the patch. I managed to move all the toString-related special-case code into a single if statement. Please try again. --- If your

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169258856 Yes, there some subtle things to the extern compiler. Thanks for sticking with it. Everything passes for me and I pushed it to the repo. --- If your project is set

Re: [GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Have you tried making a commit with this magic line in the git comment? *This closes #5* This has worked for me in the past. Thanks, Om On Tue, Jan 5, 2016 at 11:44 PM, aharui wrote: > Github user aharui commented on the pull request: > >

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169212882 At one point I had it working, but you're right, it currently isn't. I must've been modifying the wrong set of files when I was testing overriding toString().

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169223531 The one piece I didn't realize before was that since these classes are serving the purpose of an external interface, subclasses need not include override methods

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169160089 Flash Builder does not show toString() in its content assist for Object, and there is no error in the editor. =) --- If your project is set up for it, you can

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user joshtynjala commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169158834 I guess, since Object is dynamic, calling toString() should still compile if you try to call it on something typed as Object (even if it's not defined). That

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user joshtynjala commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169116121 > The other issue was that there was a hard-coded thing in MethodReference.java to output an "AS3" namespace for a toString() override. Using the AS3

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169140272 I believe the patched code does the right thing. From the AS3 language reference: >Note: Methods of the Object class are dynamically created on Object's

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user teotigraphix commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169141901 On a side note; When i wrote this externc, I had the same opinion as @adufilie. It was about getting the javascript out of valid AS, that was it. The

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169180297 No, we just want to make sure we have the same behavior that AS coders expect. I'll try to apply the correct set of your patches and see what happens. --- If your

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user joshtynjala commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169161037 Yes, I see that too. Weird. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user adufilie commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169167951 ActionScript gives an error if you try to use toString() on a non-dynamic class that does not define it explicitly. Is there a reason we should make it behave

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169167331 What happens for some non-dynamic class that extends Object? Does it get a toString() even if it doesn't define a custom toString() function? Does the compiler let

[GitHub] flex-falcon pull request: Compiler fixes related to js.swc

Github user aharui commented on the pull request: https://github.com/apache/flex-falcon/pull/5#issuecomment-169200272 Still not working. Maybe the patches didn't applied correctly, but createjs.Text.toString() is still being generated even though there is a