RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-19 Thread Maurice Amsellem
now. Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : mardi 19 novembre 2013 01:47 À : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Got it: In Mustella FakeSoftKeyboard.as , line #71

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-19 Thread Erik de Bruin
d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : mardi 19 novembre 2013 01:47 À : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Got it: In Mustella FakeSoftKeyboard.as , line #71: if (!(comp.needsSoftKeyboard

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread OmPrakash Muppirala
@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Hi, Playing 'bad cop' here: did you run the mobile Mustella tests before pushing the commits? EdB On Mon, Nov 18, 2013 at 8:41 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: Analysing the failures

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
d'origine- De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de OmPrakash Muppirala Envoyé : lundi 18 novembre 2013 09:06 À : dev@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 On Sun, Nov 17, 2013 at 11:56 PM, Maurice Amsellem

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Alex Harui
Bruin' Cc : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Yes, but didn't run all the mobile tests, only TextInput, TextArea and StageText. -Message d'origine- De : Erik de Bruin [mailto:e...@ixsoftware.nl] Envoyé : lundi 18 novembre

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
2013 17:09 À : dev@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Sorry, I haven't had time to follow the details. The baselines should not be removed if they are correct for StageTextInputSkin. We may need additional tests for the new skin classes

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
) is not tested. If it was, it would have failed. WDYT? Maurice -Message d'origine- De : Maurice Amsellem Envoyé : lundi 18 novembre 2013 17:23 À : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 Sorry, I haven't had time to follow the details

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Alex Harui
On 11/18/13 8:25 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: the code paths these tests used to verify are still there Sorry, I send the email too quick. In fact, the only visual differences between old and new baselines are because of sub-pixel diff. The rendering is the same.

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
in all situations, and put the other ones in the deprecated status. WDYT? Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : lundi 18 novembre 2013 18:22 À : dev@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 On 11/18

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
 : lundi 18 novembre 2013 18:38 À : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 I haven't seen the image diffs, so I don't know what you mean by sub-pixel. There are two common cases: 1) a few pixels are different in corners and edges because

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Alex Harui
On 11/18/13 9:38 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: Anyway, I checked the xml DL, and the coordinates/extents are exactly the same, expect that the new skin has a bitmap, so there is no computation error and nothing we can really do about that, apart from updating the

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Alex Harui
On 11/18/13 11:19 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: So does the old StyleableStageText really have less memory requirement even in that case? Not so sure... I don't know the code that well, but my understanding is that, if you don't have popups, you can save on memory.

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
a little bit tricky, I hope to be done soon. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : lundi 18 novembre 2013 20:47 À : dev@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 On 11/18/13 11:19 AM, Maurice

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-18 Thread Maurice Amsellem
2013 00:39 À : dev@flex.apache.org Objet : RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369 FYI, I am still struggling with the last Mutella failure: mobile/SoftKeyboard/properties/SK_StageText_Properties SoftKeyboard_StageText_property_resizeForSoftKeyboard_false: Failed

[dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-17 Thread Maurice Amsellem
Analysing the failures... -Message d'origine- De : flex.muste...@gmail.com [mailto:flex.muste...@gmail.com] Envoyé : lundi 18 novembre 2013 05:38 À : comm...@flex.apache.org; e...@ixsoftware.nl; jmcl...@apache.org; Maurice Amsellem Objet : Build failed in Jenkins:

Re: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-17 Thread Erik de Bruin
Hi, Playing 'bad cop' here: did you run the mobile Mustella tests before pushing the commits? EdB On Mon, Nov 18, 2013 at 8:41 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: Analysing the failures... -Message d'origine- De : flex.muste...@gmail.com

RE: [dev] Build failed in Jenkins: flex-sdk_mustella-mobile #369

2013-11-17 Thread Maurice Amsellem
Yes, but didn't run all the mobile tests, only TextInput, TextArea and StageText. -Message d'origine- De : Erik de Bruin [mailto:e...@ixsoftware.nl] Envoyé : lundi 18 novembre 2013 08:47 À : Maurice Amsellem Cc : dev@flex.apache.org Objet : Re: [dev] Build failed in Jenkins: flex