Re: 120 and 640 dpi support

2013-08-20 Thread OmPrakash Muppirala
A restart and a clean build fixed everything for me. Sorry for the noise. I will do a release build and test it with my current mobile apps and send out a report this evening. Thanks, Om On Mon, Aug 19, 2013 at 7:49 PM, OmPrakash Muppirala bigosma...@gmail.comwrote: That helps, thanks for

Re: 120 and 640 dpi support

2013-08-20 Thread OmPrakash Muppirala
I have run into at least one major problem. Some of the FXG assets use the viewHeight and viewWidth properties. This causes the asset to not scale. So I am seeing artifacts in my mobile app in the new dpis (120, 480 and 640) I am going to try removing these properties because we want them to

Re: 120 and 640 dpi support

2013-08-19 Thread OmPrakash Muppirala
I am done creating the new skins for both 120 and 640 dpi. But when I do a release build, I am see that my Flash Player debugger freezes when running the basicTests. The version is flashplayer11_1r102_63_win_sa_debug_32bit.exe and the branch is: 'NewDPIBuckets'. Anyone has any advice?

Re: 120 and 640 dpi support

2013-08-19 Thread Alex Harui
Helloworld.swf seems too small. On 8/19/13 10:13 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: I am done creating the new skins for both 120 and 640 dpi. But when I do a release build, I am see that my Flash Player debugger freezes when running the basicTests. The version is

Re: 120 and 640 dpi support

2013-08-19 Thread OmPrakash Muppirala
And the RSL swfs' versions are wrong too, right? On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui aha...@adobe.com wrote: Helloworld.swf seems too small. On 8/19/13 10:13 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: I am done creating the new skins for both 120 and 640 dpi. But when I

Re: 120 and 640 dpi support

2013-08-19 Thread Alex Harui
I didn't think basictests ran in RSL config. I always thought it was merged-into-code. -Alex On 8/19/13 2:18 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: And the RSL swfs' versions are wrong too, right? On Mon, Aug 19, 2013 at 2:15 PM, Alex Harui aha...@adobe.com wrote:

Re: 120 and 640 dpi support

2013-08-19 Thread OmPrakash Muppirala
Can you try building the 'NewDPIBuckets' branch and see if you hit this issue as well? I am simply doing an 'ant release' - nothing other than the new mobile skins has changed AFAIK. Thanks, Om On Mon, Aug 19, 2013 at 2:21 PM, Alex Harui aha...@adobe.com wrote: I didn't think basictests ran

Re: 120 and 640 dpi support

2013-08-19 Thread Alex Harui
Im deep in a compiler issue right now. First step is to try ant clean main checkintests. Does it fail in that case? -Alex On 8/19/13 3:49 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: Can you try building the 'NewDPIBuckets' branch and see if you hit this issue as well? I am simply

Re: 120 and 640 dpi support

2013-08-19 Thread Justin Mclean
Hi, JFYI - Synced the NewDPIBuckets branch and was able to do a ant clean main checkintests with no issues, Checkin tests passed, on OSX btw. Thanks, Justin

Re: 120 and 640 dpi support

2013-08-19 Thread Justin Mclean
Hi, Also no issue with ant release - although the build number is 0 because it was not specified. [mxmlc] Loading configuration file /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/flex-config.xml [mxmlc] Required RSLs: [mxmlc] framework_0.swf [mxmlc]

Re: 120 and 640 dpi support

2013-08-19 Thread Justin Mclean
Hi, And it did run to completion without any issues - know that doesn't help you sorry. release: BUILD SUCCESSFUL Total time: 76 minutes 20 seconds Justin

Re: 120 and 640 dpi support

2013-08-19 Thread OmPrakash Muppirala
That helps, thanks for testing. I am going to try my luck with develop branch and see if it is still broken for me. Anyone else on Windows willing to test and confirm? Thanks, Om On Aug 19, 2013 7:42 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, And it did run to completion without

Re: 120 and 640 dpi support

2013-08-18 Thread Justin Mclean
Hi, I've just checked in the ones you missed - can you fix so that they are 120 dpi? Thanks, Justin

Re: 120 and 640 dpi support

2013-08-18 Thread OmPrakash Muppirala
Will do. Thanks! On Sun, Aug 18, 2013 at 9:53 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, I've just checked in the ones you missed - can you fix so that they are 120 dpi? Thanks, Justin

Re: 120 and 640 dpi support

2013-08-13 Thread OmPrakash Muppirala
I tried building the NewDPIBuckets branch and am getting the following build errors: Not sure if I missed some skins during the conversion. Justin, can you please take a look? == mobilecomponents: bundles-clean: clean: configModLinux: configModOther: compile:

Re: 120 and 640 dpi support

2013-08-13 Thread Justin Mclean
Hi, Not sure if I missed some skins during the conversion. Justin, can you please take a look? Yep looks that way. Which dpi did you base the 120 and 640 off? The code changes I made assumed 320 as it contains extra skins then 240 and that makes it also in line with 480. Justin

Re: 120 and 640 dpi support

2013-08-13 Thread OmPrakash Muppirala
I just used the assets you had copied over. Here is the assumption I made based on your commit comments. 120 dpi is based off of 240 (*0.5) 640 dpi is based off of 320 (*2) Thanks, Om On Tue, Aug 13, 2013 at 4:02 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, Not sure if I missed

Re: 120 and 640 dpi support

2013-08-12 Thread Alex Harui
On 8/11/13 6:25 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, Tests are done and check into the NewDPIBuckets branch and all pass. If someone could review that would be great as I'm not 100% sure the scaling tests are actually working. I'm not clear that mustella will run the mobile

Re: 120 and 640 dpi support

2013-08-11 Thread Justin Mclean
Hi, I've checked in the skins for the 120dpi and 640dpi themes. Anything else I can help with? Sure if you can try out the 160 and 640 dpi skins on some existing mobile projects you have and see what they look like. I'll get the mobile tests working. Justin

Re: 120 and 640 dpi support

2013-08-11 Thread OmPrakash Muppirala
On Sun, Aug 11, 2013 at 6:09 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, I've checked in the skins for the 120dpi and 640dpi themes. Anything else I can help with? Sure if you can try out the 160 and 640 dpi skins on some existing mobile projects you have and see what they

Re: 120 and 640 dpi support

2013-08-11 Thread Justin Mclean
Hi, Any plans to merge it into develop so I can just get the nightly build and test it? We should really only merge after it's been completed/tested. I am trying to avoid building the sdk on the branch if possible. Any particular reason why? I thought the whole point with changes like this

Re: 120 and 640 dpi support

2013-08-11 Thread OmPrakash Muppirala
On Sun, Aug 11, 2013 at 9:46 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, Any plans to merge it into develop so I can just get the nightly build and test it? We should really only merge after it's been completed/tested. Agreed. I am trying to avoid building the sdk on the

Re: 120 and 640 dpi support

2013-08-11 Thread Justin Mclean
Hi, Mostly, my laziness :-) I have too many things going on right now - so building manually from the branch would be disruptive. Took me about 10 min and 8 min of that was waiting for it to build while I did something else. :-) You can always have more than one tree/more than one SDK set up

Re: 120 and 640 dpi support

2013-08-10 Thread OmPrakash Muppirala
I've checked in the skins for the 120dpi and 640dpi themes. Anything else I can help with? Thanks, Om On Fri, Aug 9, 2013 at 11:52 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, And also changes required in the CSS in the mobile theme default.css. Justin

Re: 120 and 640 dpi support

2013-08-09 Thread Justin Mclean
Hi, Please assign the 120 and 640 dpi JIRA tickets to me. I will have some bandwidth to work on them in the next week. Already started - there's a NewDPIBucket branch, I'll check it in and you can take over if you want. It actually simpler than the 480 as the 640 is just double the 320 (so

Re: 120 and 640 dpi support

2013-08-09 Thread OmPrakash Muppirala
I see the changes you made in the new branch. Is resizing the fxg files the only thing remaining? I have seen some developers observe that using 160 dpi skins and letting it scale up improves the performance of mobile apps. This makes sense because the higher the dpi increases, the FXG files

Re: 120 and 640 dpi support

2013-08-09 Thread Justin Mclean
Hi, And also changes required in the CSS in the mobile theme default.css. Justin

Re: 120 and 640 dpi support

2013-08-09 Thread Justin Mclean
Hi, I see the changes you made in the new branch. Is resizing the fxg files the only thing remaining? Nope you have to change all the action script skins as well. There's about 100 odd files there that need changes and you need to look carefully as it not always a simple doubling (from 320)