Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread OmPrakash Muppirala
On Wed, Nov 13, 2013 at 9:12 PM, Alex Harui aha...@adobe.com wrote: On 11/13/13 8:26 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: I think I get it, but I guess I will need some pseudo code to understand completely. What exactly does 'hang it on a strand' man in this context?

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread Alex Harui
On 11/14/13 10:57 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Wed, Nov 13, 2013 at 9:12 PM, Alex Harui aha...@adobe.com wrote: On 11/13/13 8:26 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: I think I get it, but I guess I will need some pseudo code to understand

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread OmPrakash Muppirala
On Thu, Nov 14, 2013 at 11:45 AM, Alex Harui aha...@adobe.com wrote: On 11/14/13 10:57 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Wed, Nov 13, 2013 at 9:12 PM, Alex Harui aha...@adobe.com wrote: On 11/13/13 8:26 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: I

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread Peter Ent
On 11/14/13 2:55 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Thu, Nov 14, 2013 at 11:45 AM, Alex Harui aha...@adobe.com wrote: On 11/14/13 10:57 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Wed, Nov 13, 2013 at 9:12 PM, Alex Harui aha...@adobe.com wrote: On

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread OmPrakash Muppirala
On Thu, Nov 14, 2013 at 12:19 PM, Peter Ent p...@adobe.com wrote: On 11/14/13 2:55 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Thu, Nov 14, 2013 at 11:45 AM, Alex Harui aha...@adobe.com wrote: On 11/14/13 10:57 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-14 Thread Alex Harui
On 11/14/13 12:37 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Thu, Nov 14, 2013 at 12:19 PM, Peter Ent p...@adobe.com wrote: On 11/14/13 2:55 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Thu, Nov 14, 2013 at 11:45 AM, Alex Harui aha...@adobe.com wrote: On

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread OmPrakash Muppirala
On Tue, Nov 12, 2013 at 8:27 PM, Alex Harui aha...@adobe.com wrote: Hi Om, Looks good. Some points to ponder: 1) Ideally, in a Pay-as-you-go philosophy, a rolloverIndex would not be in the ArraySelectionModel since, in theory, ArraySelectionModel should be reusable in mobile devices where

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread Alex Harui
On 11/13/13 8:17 AM, Peter Ent p...@adobe.com wrote: On 11/13/13 3:19 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Tue, Nov 12, 2013 at 8:27 PM, Alex Harui aha...@adobe.com wrote: Hi Om, Looks good. Some points to ponder: 1) Ideally, in a Pay-as-you-go philosophy, a

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread OmPrakash Muppirala
On Wed, Nov 13, 2013 at 11:37 AM, Alex Harui aha...@adobe.com wrote: On 11/13/13 8:17 AM, Peter Ent p...@adobe.com wrote: On 11/13/13 3:19 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Tue, Nov 12, 2013 at 8:27 PM, Alex Harui aha...@adobe.com wrote: Hi Om, Looks good.

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread Alex Harui
On 11/13/13 1:33 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: The usecase here is that there are n Lists (for each column) composed by the DataGrid component. If the users rollsover an on any list, the corresponding itemrenderers in each column must highlight themselves. So, keeping

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread OmPrakash Muppirala
On Nov 13, 2013 8:05 PM, Alex Harui aha...@adobe.com wrote: On 11/13/13 1:33 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: The usecase here is that there are n Lists (for each column) composed by the DataGrid component. If the users rollsover an on any list, the corresponding

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-13 Thread Alex Harui
On 11/13/13 8:26 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: I think I get it, but I guess I will need some pseudo code to understand completely. What exactly does 'hang it on a strand' man in this context? Thanks, Om I looked at the commit diffs again. I missed seeing earlier that

Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after dis

2013-11-12 Thread OmPrakash Muppirala
This is my first real contribution to the FlexJS project. Alex/Peter can you please review this and let me know if I am on the right track? Once you approve, I will start looking at the JS version of the same logic. Thanks, Om On Tue, Nov 12, 2013 at 6:07 PM, bigosma...@apache.org wrote:

Re: Code review please... Re: git commit: [flex-asjs] [refs/heads/develop] - Add functionality to AS version of DataGrid to highlight entire row when rolling over any column JS version to follow after

2013-11-12 Thread Alex Harui
Hi Om, Looks good. Some points to ponder: 1) Ideally, in a Pay-as-you-go philosophy, a rolloverIndex would not be in the ArraySelectionModel since, in theory, ArraySelectionModel should be reusable in mobile devices where there is no rollover. I honestly don't know what the right answer is.