Hi,
> Right now, the changes won't let the gutter and button overlap. I'm
> wondering if you allow that, if these tests will pass and you can still
> clip. Another possible option is to only run the clipping code path if
> there is more than one line of text.
Ended up being slightly more comple
Hi,
> Luck or not, if other folks have controlled the
> size of the Alert (which is allowed) and it "just worked" for them, with
> these changes, it now will not.
Just to be clear this is probably quite uncommon scenario ie setting the hight
to be smaller than than needed.
> I'm wondering if yo
On 5/22/14 9:56 AM, "Justin Mclean" wrote:
>Hi,
>
>> I think the textfield's gutter needs to be compensated for in this sort
>>of
>> fix. I'm wondering if it is as simple as allowing another 4 pixels in
>> height before clipping so the top and bottom gutters are essentially
>> ignored.
>
>That
Hi,
> I think the textfield's gutter needs to be compensated for in this sort of
> fix. I'm wondering if it is as simple as allowing another 4 pixels in
> height before clipping so the top and bottom gutters are essentially
> ignored.
That wouldn't fix the shader test. It's setting the Alert hei
In the other thread, I noted that the Alert in the Shader test is having
the bottom of the text clipped by the button. Maybe these emails are
still not getting delivered? Anyway, IMO, clipped a single line of text
would probably generate complaints from anyone else who has a similar
setup.
I als
On 22/05/14 16:52, Justin Mclean wrote:
I am still waiting feedback
I didn't see any here, and there's no discussion on Jira about the
method of fixing.
I see from the diff you basically clamp the height to that available;
this is certainly no worse as long text is cut off already, just not
Hi,
> Please fix the code or the tests (and any others in the full run that might
> be broken by this change), or revert.
I am still waiting feedback on this on this change before changing the base
images. Changing the base images will fix the test.
Thanks,
Justin
Please fix the code or the tests (and any others in the full run that might
be broken by this change), or revert. I don't want to veto this, but
intentionally breaking Mustella is not a good way to make a point about a
fix...
EdB
On Sat, May 17, 2014 at 5:11 PM, Justin Mclean wrote:
> Hi,
>
>
Hi,
Just checked in a fix that will causes some tests to fail. This fixes a bug
that was outstanding since Flex 2.0 days!
Here the tests that fail:
[java] components/Alert/Styles/Alert_Styles Alert_messageStyleName Failed
CompareBitmap(body:step 2) compare returned[object BitmapData]
