Re: checkin tests filing on Linux

2013-06-06 Thread Alex Harui
Interesting. There was so much work done to integrate the globalization classes that I'm surprised we didn't upgrade AC to use them. IMO, the results of Array.sort with the globalization classes is correct and localeCompare is doing a dumb sort. I haven't looked but maybe we documented how to

Re: checkin tests filing on Linux

2013-06-06 Thread Justin Mclean
Hi, Interesting. There was so much work done to integrate the globalization classes that I'm surprised we didn't upgrade AC to use them. It wouldn't be too hard to change. IMO, the results of Array.sort with the globalization classes is correct And that's where the issue is as it returns a

Re: checkin tests filing on Linux

2013-06-06 Thread Alex Harui
On 6/5/13 11:26 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Interesting. There was so much work done to integrate the globalization classes that I'm surprised we didn't upgrade AC to use them. It wouldn't be too hard to change. IMO, the results of Array.sort with the

Re: checkin tests filing on Linux

2013-06-06 Thread Justin Mclean
Hi, Different but valid? Looks invalid to me - basically they are left in the order they are passed in. cote, côte, coté, côté If changing the test to have the AC sort through the globalization classes allows that test to pass on all platforms, then I'd say that's the way to go. It doesn't

Re: checkin tests filing on Linux

2013-06-06 Thread Alex Harui
On 6/6/13 12:49 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, Different but valid? Looks invalid to me - basically they are left in the order they are passed in. cote, côte, coté, côté Ah, I didn't understand that the order was not changing. If you are sure of what the order should

Re: checkin tests filing on Linux

2013-06-05 Thread Alex Harui
On 6/5/13 1:54 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, I think the test is taking a bare low-level Flash array and sorting it, then taking an ArrayCollection and applying a sort to it, and the order in both should match. Yep I got that but exactly why should they match? One

Re: checkin tests filing on Linux

2013-06-05 Thread Justin Mclean
Hi, Interesting. I expected them to match because I thought we'd wired up the AC sort behavior to use the flash.globalization classes. If you step through this on the Mac it goes into localeCompare? On OSX it's calling spark.collections.Sort:internalSort which is using

checkin tests filing on Linux

2013-06-04 Thread Justin Mclean
Hi, I was looking at the MX sorting test and why it was failing on Linux and as far as I can can see I'm not sure it should even pass anywhere. Here's the test: TestCase testID=MXSort setup RunCode code=myCollator=new flash.globalization.Collator('en-US')

Re: checkin tests filing on Linux

2013-06-04 Thread Alex Harui
In your non-mustella test case, it looks like you are calling toString() on the collection.source instead of collection.toArray(). On 6/4/13 10:54 AM, Justin Mclean justinmcl...@gmail.com wrote: Hi, I was looking at the MX sorting test and why it was failing on Linux and as far as I can can see

Re: checkin tests filing on Linux

2013-06-04 Thread Justin Mclean
Hi, In your non-mustella test case, it looks like you are calling toString() on the collection.source instead of collection.toArray(). Well spotted thanks that now works except on Linus. I'm not sure what the test is actually trying to test (sort order obviously but it seems an odd way to go

Re: checkin tests filing on Linux

2013-06-04 Thread Alex Harui
On 6/4/13 2:20 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, In your non-mustella test case, it looks like you are calling toString() on the collection.source instead of collection.toArray(). Well spotted thanks that now works except on Linus. I'm not sure what the test is actually