Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-16 Thread Mihai Chira
Yay! Thank you. On 10 December 2015 at 17:52, Alex Harui wrote: > > > On 12/10/15, 1:00 AM, "Mihai Chira" wrote: > >>Finding "FAIL: .*Sort" in the old reports highlights about 21 lines, >>and in the new ones none. So I guess the sorting bugs have been fixed? >>Or should we wait until we restart

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-10 Thread Alex Harui
On 12/10/15, 1:00 AM, "Mihai Chira" wrote: >Finding "FAIL: .*Sort" in the old reports highlights about 21 lines, >and in the new ones none. So I guess the sorting bugs have been fixed? >Or should we wait until we restart mustella for a confirmation? I think you have resolved all of the sorting

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-10 Thread Mihai Chira
Finding "FAIL: .*Sort" in the old reports highlights about 21 lines, and in the new ones none. So I guess the sorting bugs have been fixed? Or should we wait until we restart mustella for a confirmation? On 8 December 2015 at 17:19, Alex Harui wrote: > Thanks for sticking with it. I have my fing

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-08 Thread Alex Harui
Thanks for sticking with it. I have my fingers crossed. -Alex On 12/8/15, 7:58 AM, "Mihai Chira" wrote: >Just pushed another commit. Locally all the mustella tests in the >spark/Collections/Sort/Other are now passing, fingers crossed that all >the other sort-related ones will also pass. >The l

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-08 Thread Mihai Chira
Just pushed another commit. Locally all the mustella tests in the spark/Collections/Sort/Other are now passing, fingers crossed that all the other sort-related ones will also pass. The lesson: moving from inheritance to composition can be super complicated! Events, the new class member using "this"

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-03 Thread Mihai Chira
In the end it's an improvement, but in the end 5 test cases are still failing. Right now I'm travelling, and won't be able to take another look until Saturday. Does someone else want to help out? On 3 December 2015 at 15:18, Alex Harui wrote: > Excellent! Thanks, -Alex > > On 12/3/15, 6:01 AM, "

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-03 Thread Alex Harui
Excellent! Thanks, -Alex On 12/3/15, 6:01 AM, "Mihai Chira" wrote: >About to commit and push a fix for this in the next hour. (It took me >so long because my HDD had bad sectors which caused lots of pain in >the last few days.) > >On 24 November 2015 at 18:03, Alex Harui wrote: >> >> >> On 11/

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-12-03 Thread Mihai Chira
About to commit and push a fix for this in the next hour. (It took me so long because my HDD had bad sectors which caused lots of pain in the last few days.) On 24 November 2015 at 18:03, Alex Harui wrote: > > > On 11/24/15, 8:41 AM, "Mihai Chira" wrote: > >>Yes, but the earliest I can do that i

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-11-24 Thread Alex Harui
On 11/24/15, 8:41 AM, "Mihai Chira" wrote: >Yes, but the earliest I can do that is on Monday. I hope that still works >regarding the release. (And I hope I'll manage to solve it, but we'll >see.) >On 24 Nov 2015 08:19, "Alex Harui" wrote: I don't know of any plans to cut an RC this week, so I

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-11-24 Thread Mihai Chira
Yes, but the earliest I can do that is on Monday. I hope that still works regarding the release. (And I hope I'll manage to solve it, but we'll see.) On 24 Nov 2015 08:19, "Alex Harui" wrote: > Hey Mihai, > > I think the Mustella runs are a bit more stable and we're trying to clean > up failures

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-11-23 Thread Alex Harui
Hey Mihai, I think the Mustella runs are a bit more stable and we're trying to clean up failures and get a release out. Can you find some time to look at the sort failures again? Thanks, -Alex On 7/18/15, 12:39 PM, "Mihai Chira" wrote: >Yep, it's pretty clear which ones are still failing. > >

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-23 Thread Mihai Chira
1. Good to know about these tools. I now made sure that the IntelliJ project is using the correct SDK (which I have rebuilt before also rebuilding the mustella SWF), and I get the same problem: I only reach the constructors of TestCase and mx.modules.ModuleLoader. I think it's that no one calls Uni

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Alex Harui
On 7/18/15, 3:05 PM, "Mihai Chira" wrote: >> The swf should hit breakpoints in the sort code. Is it not doing that? >I could only break the app on the constructors of UnitTester and >TestCase. Nothing in SortField or Sort (I didn't test the >constructors, just other methods that should have bee

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
> The swf should hit breakpoints in the sort code. Is it not doing that? I could only break the app on the constructors of UnitTester and TestCase. Nothing in SortField or Sort (I didn't test the constructors, just other methods that should have been called - even if the bug was still there, that i

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Alex Harui
flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem. Now I'm stuck because although I can run the swf that was generated at the previous step in debug mode in IntelliJ, the most furt

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
Now I'm stuck because although I can run the swf that was generated at the previous step in debug mode in IntelliJ, the most further breakpoint which I can catch is in the TestCase.as constructor. Which implies, to me, that the test case in the mxml file is defined and created, but not executed. Do

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-18 Thread Mihai Chira
Yep, it's pretty clear which ones are still failing. I'm looking, for instance, at SF_module_sparkButtonBar_global_tester.mxml, whose only test case should run perfectly. I made a sample app which does (seemingly) the same thing, and the Sort and SortField do return the correct locale value ("ru-R

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-17 Thread Alex Harui
I wasn’t able to reset mustella until just now so it might be hard to find your results in the 100’s of errors in build # 1533. Hopefully build # 1534 will be cleaner. FWIW, my magic incantation that resets mustella is to log into the server, open ApacheFlex/dependencies/FlashPlayer_Debug and cli

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-17 Thread Mihai Chira
Cool, thanks for the link. I'll take a look tonight or tomorrow at the results. On 16 Jul 2015 22:53, "Alex Harui" wrote: > The link at [1] is the build server that is currently down. It doesn’t > run mustella. > > Mustella tests are at http://flex-mustella.cloudapp.net and failures are > sent t

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Alex Harui
The link at [1] is the build server that is currently down. It doesn’t run mustella. Mustella tests are at http://flex-mustella.cloudapp.net and failures are sent to commits@ Every couple of days, we start getting weird failures that requires fiddling with the mustella server. It looks like we’

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Mihai Chira
At least one of the failures should now be fixed. If others are left, I'll tackle them in the next few days. How can I monitor the test results? The bookmark I have for the build server is this[1] and it doesn't seem to be working. Sorry if there was a url change that I didn't catch. [1] http://ap

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Mihai Chira
> changes. Can you take a look? on it

Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34854 FLEX-34884 Adding unit test to make sure that the changes in FLEX-34854 haven't changed anything about findItem.

2015-07-16 Thread Alex Harui
Hi Mihai, We have seen mustella test failures that appear to be related to your changes. Can you take a look? [java] = [java] Failed: [java] = [java] LangPacks/Japane