Re: [DISCUSS] Setup a bui...@flink.apache.org mailing list for travis builds

2019-08-28 Thread Kurt Young
one suggestion: we could also filter all notifications about *Cancelled* builds. Best, Kurt On Tue, Aug 27, 2019 at 10:53 AM jincheng sun wrote: > Great Job Jark :) > Best, Jincheng > > Kurt Young 于2019年8月26日周一 下午6:38写道: > > > Thanks for the updates, Jark! I have subscribed the ML and

Re: [DISCUSS] Best practice to run flink on kubernetes

2019-08-28 Thread Zhenghua Gao
Thanks Yang for bringing this up. I think option1 is very useful for early adopters. People do not know much about k8s and can easily set up on minikube to have a taste. For option2 and option3, i prefer option3 because i am familiar yarn and don't have much concept of k8s. And there is some

[jira] [Created] (FLINK-13887) ExecutionConfig#setDefaultInputDependencyConstraint should do NotNull check on params

2019-08-28 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-13887: --- Summary: ExecutionConfig#setDefaultInputDependencyConstraint should do NotNull check on params Key: FLINK-13887 URL: https://issues.apache.org/jira/browse/FLINK-13887 Project:

Re: [VOTE] FLIP-54: Evolve ConfigOption and Configuration

2019-08-28 Thread Zili Chen
The design looks good to me. +1 go ahead! Best, tison. Jark Wu 于2019年8月28日周三 下午6:08写道: > Hi Timo, > > The new changes looks good to me. > > +1 to the FLIP. > > > Cheers, > Jark > > On Wed, 28 Aug 2019 at 16:02, Timo Walther wrote: > > > Hi everyone, > > > > after some last minute changes

Re: [VOTE] FLIP-58: Flink Python User-Defined Function for Table API

2019-08-28 Thread Hequn Cheng
Hi Dian, +1 Thanks a lot for driving this. Best, Hequn On Wed, Aug 28, 2019 at 2:01 PM jincheng sun wrote: > Hi Dian, > > +1, Thanks for your great job! > > Best, > Jincheng > > Dian Fu 于2019年8月28日周三 上午11:04写道: > > > Hi all, > > > > I'd like to start a voting thread for FLIP-58 [1] since

[RESULT] [VOTE] flink-shaded 8.0, release candidate #1

2019-08-28 Thread Chesnay Schepler
|I'm happy to announce that we have unanimously approved this release.| |There are 3 approving votes, 3 of which are binding:| |* Aljoscha| |* Till | |* Chesnay| |There are no disapproving votes.| |Thanks everyone!| On 23/08/2019 21:05, Chesnay Schepler wrote: Hi everyone, Please review and

Re: [VOTE] Release flink-shaded 8.0, release candidate #1

2019-08-28 Thread Chesnay Schepler
+1 (binding) - asm/netty jars do not contain anything suspicions - ran Flink tests (including e2e tests) with new netty/asm versions - license files were updated accordingly On 28/08/2019 14:28, Till Rohrmann wrote: +1 (binding) Cheers, Till On Wed, Aug 28, 2019 at 11:53 AM Aljoscha Krettek

[jira] [Created] (FLINK-13886) Need to develop flink-connector-elasticsearch7

2019-08-28 Thread Leonid Ilyevsky (Jira)
Leonid Ilyevsky created FLINK-13886: --- Summary: Need to develop flink-connector-elasticsearch7 Key: FLINK-13886 URL: https://issues.apache.org/jira/browse/FLINK-13886 Project: Flink Issue

Re: [DISCUSS] FLIP-49: Unified Memory Configuration for TaskExecutors

2019-08-28 Thread Till Rohrmann
Thanks for the clarification. I have some more comments: - I would actually split the logic to compute the process memory requirements and storing the values into two things. E.g. one could name the former TaskExecutorProcessUtility and the latter TaskExecutorProcessMemory. But we can discuss

Re: [DISCUSS] FLIP-55: Introduction of a Table API Java Expression DSL

2019-08-28 Thread Seth Wiesman
I would prefer ‘lit()’ over ‘val()’ since val is a keyword in Scala. Assuming the intention is to make the dsl ergonomic for Scala developers. Seth > On Aug 28, 2019, at 7:58 AM, Timo Walther wrote: > > Hi David, > > thanks for your feedback. I was also skeptical about 1 char method names,

[jira] [Created] (FLINK-13885) Remove HighAvailabilityOptions#HA_JOB_DELAY which is no longer used

2019-08-28 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-13885: - Summary: Remove HighAvailabilityOptions#HA_JOB_DELAY which is no longer used Key: FLINK-13885 URL: https://issues.apache.org/jira/browse/FLINK-13885 Project: Flink

Re: [DISCUSS] Flink project bylaws

2019-08-28 Thread Chesnay Schepler
Yes, I'd also link it in the wiki. On 28/08/2019 15:27, Robert Metzger wrote: Thanks a lot for running the vote Becket! I have removed the "(draft)" from the wiki page :) Should we link the bylaws also from the Flink website? On Thu, Aug 22, 2019 at 6:23 PM Becket Qin wrote: Thanks for

Re: [DISCUSS] Flink project bylaws

2019-08-28 Thread Robert Metzger
Thanks a lot for running the vote Becket! I have removed the "(draft)" from the wiki page :) Should we link the bylaws also from the Flink website? On Thu, Aug 22, 2019 at 6:23 PM Becket Qin wrote: > Thanks for collecting the ideas of Bylaws changes. It is a good idea! > > Jiangjie (Becket)

[jira] [Created] (FLINK-13884) Set default restart-strategy.failure-rate.delay to 0s

2019-08-28 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-13884: - Summary: Set default restart-strategy.failure-rate.delay to 0s Key: FLINK-13884 URL: https://issues.apache.org/jira/browse/FLINK-13884 Project: Flink

[jira] [Created] (FLINK-13883) Remove Akka watch failure detector configuration

2019-08-28 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-13883: - Summary: Remove Akka watch failure detector configuration Key: FLINK-13883 URL: https://issues.apache.org/jira/browse/FLINK-13883 Project: Flink Issue

[jira] [Created] (FLINK-13882) Remove ProcessReaper

2019-08-28 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-13882: - Summary: Remove ProcessReaper Key: FLINK-13882 URL: https://issues.apache.org/jira/browse/FLINK-13882 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-55: Introduction of a Table API Java Expression DSL

2019-08-28 Thread Timo Walther
Hi David, thanks for your feedback. I was also skeptical about 1 char method names, I restored the `val()` method for now. If you read literature such as Wikipedia [1]: "literal is a notation for representing a fixed value in source code. Almost all programming languages have notations for

Re: [VOTE] Release flink-shaded 8.0, release candidate #1

2019-08-28 Thread Till Rohrmann
+1 (binding) Cheers, Till On Wed, Aug 28, 2019 at 11:53 AM Aljoscha Krettek wrote: > +1 (binding) > > - I verified the signature and checksum > - I eyeballed the list of resolved issues > - I checked the maven central artifices > > Aljoscha > > > On 23. Aug 2019, at 21:05, Chesnay Schepler

Re: [CODE-STYLE] Builder pattern

2019-08-28 Thread Piotr Nowojski
> For Piotr's comment 4. I. I agree with Klou that this sounds rather like a > problem of the builder's usage than a builder problem. I think such a > scenario can easily be solved by introducing a transfer object. It could be solved, but that would mean we have some kind of

Re: [VOTE] FLIP-54: Evolve ConfigOption and Configuration

2019-08-28 Thread Jark Wu
Hi Timo, The new changes looks good to me. +1 to the FLIP. Cheers, Jark On Wed, 28 Aug 2019 at 16:02, Timo Walther wrote: > Hi everyone, > > after some last minute changes yesterday, I would like to start a new > vote on FLIP-54. The discussion seems to have reached an agreement. Of >

Re: [VOTE] Release flink-shaded 8.0, release candidate #1

2019-08-28 Thread Aljoscha Krettek
+1 (binding) - I verified the signature and checksum - I eyeballed the list of resolved issues - I checked the maven central artifices Aljoscha > On 23. Aug 2019, at 21:05, Chesnay Schepler wrote: > > Hi everyone, > Please review and vote on the release candidate #1 for the version 8.0, as

Relaxed Contiguity suport in cep sql

2019-08-28 Thread 张万新
Hi all, I noticed that in flink 1.9.0 cep sql with blink planner, using "(A -> B)" to define a pattern A followed by pattern B is not supported, but it's supported in blink branch. I'd like to know why this feature is removed in 1.9.0 blink planner, and is there any plan to support it in the

Re: [DISCUSS] FLIP-49: Unified Memory Configuration for TaskExecutors

2019-08-28 Thread Yang Wang
Just add my 2 cents. Using environment variables to override the configuration for different taskmanagers is better. We do not need to generate dedicated flink-conf.yaml for all taskmanagers. A common flink-conf.yam and different environment variables are enough. By reducing the distributed

Re: Is there Go client for Flink?

2019-08-28 Thread Till Rohrmann
Hi, all client server communication goes through the REST API. Hence, one could write a Go client which uses this API. But currently, Flink only comes with the Java based client. Cheers, Till On Wed, Aug 28, 2019 at 12:09 AM Dagang Wei wrote: > Hi folks, > > Seems Flink only provides REST

[VOTE] FLIP-54: Evolve ConfigOption and Configuration

2019-08-28 Thread Timo Walther
Hi everyone, after some last minute changes yesterday, I would like to start a new vote on FLIP-54. The discussion seems to have reached an agreement. Of course this doesn't mean that we can't propose further improvements on ConfigOption's and Flink configuration in general in the future. It

[jira] [Created] (FLINK-13881) CEP within method should applied in every independent pattern

2019-08-28 Thread YufeiLiu (Jira)
YufeiLiu created FLINK-13881: Summary: CEP within method should applied in every independent pattern Key: FLINK-13881 URL: https://issues.apache.org/jira/browse/FLINK-13881 Project: Flink Issue

Re: [VOTE] Flink Project Bylaws

2019-08-28 Thread Becket Qin
Thanks for voting, Jincheng, Kostas and Marton! By now the vote counts as following: +1 (Binding): 16 (Aljoscha, Fabian, Kurt, Till, Timo, Max, Stephan, Gordon, Robert, Ufuk, Chesnay, Shaoxuan, Henry, Jincheng, Kostas, Marton) +0 (Binding): 1 (Thomas) +1 (Non-Binding): 11 (Hequn, Vino, Piotr,

Re: [VOTE] FLIP-58: Flink Python User-Defined Function for Table API

2019-08-28 Thread jincheng sun
Hi Dian, +1, Thanks for your great job! Best, Jincheng Dian Fu 于2019年8月28日周三 上午11:04写道: > Hi all, > > I'd like to start a voting thread for FLIP-58 [1] since that we have > reached an agreement on the design in the discussion thread [2], > > This vote will be open for at least 72 hours.