[jira] [Created] (FLINK-21346) Tasks on AZP should timeout more gracefully

2021-02-09 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-21346: --- Summary: Tasks on AZP should timeout more gracefully Key: FLINK-21346 URL: https://issues.apache.org/jira/browse/FLINK-21346 Project: Flink Issue Type: Improve

Re: Flink upset-kaka connector not working with Avro confluent

2021-02-09 Thread Svend Vanderveken
Hi Shamit, In this snippet: Table definition with upsert-kafka is below (not working), > > CREATE TABLE proposalLine (PROPOSAL_LINE_ID > bigint,LAST_MODIFIED_BY STRING ,PRIMARY KEY (PROPOSAL_LINE_ID) NOT ENFORCED > ) "WITH ('connector' = 'upsert-kafka', 'properties.bootstrap.serve

[jira] [Created] (FLINK-21345) NullPointerException LogicalCorrelateToJoinFromTemporalTableFunctionRule.scala:157

2021-02-09 Thread lynn1.zhang (Jira)
lynn1.zhang created FLINK-21345: --- Summary: NullPointerException LogicalCorrelateToJoinFromTemporalTableFunctionRule.scala:157 Key: FLINK-21345 URL: https://issues.apache.org/jira/browse/FLINK-21345 Proj

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Shengkai Fang
Hi, guys. I have updated the FLIP. It seems we have reached agreement. Maybe we can start the vote soon. If anyone has other questions, please leave your comments. Best, Shengkai Rui Li 于2021年2月9日 周二下午7:52写道: > Hi guys, > > The conclusion sounds good to me. > > On Tue, Feb 9, 2021 at 5:39 PM S

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Jark Wu
Hi Timo, 1) I'm fine with `Column`, but are we going to introduce new interfaces for `UniqueConstraint` and `WatermarkSpec`? If we want to introduce a new stack, it would be better to have a different name, otherwise, it's easy to use a wrong class for users. Best, Jark On Wed, 10 Feb 2021 at 09

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Rui Li
I see. Makes sense to me. Thanks Timo for the detailed explanation! On Tue, Feb 9, 2021 at 9:48 PM Timo Walther wrote: > Hi Rui, > > 1. It depends whether you would like to declare (unresolved) or use > (resolved) a schema. In catalogs and APIs, people would actually like to > declare a schema.

[jira] [Created] (FLINK-21344) Support switching from/to rocks db with heap timers

2021-02-09 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-21344: Summary: Support switching from/to rocks db with heap timers Key: FLINK-21344 URL: https://issues.apache.org/jira/browse/FLINK-21344 Project: Flink I

[jira] [Created] (FLINK-21343) Update documentation with possible migration strategies

2021-02-09 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-21343: Summary: Update documentation with possible migration strategies Key: FLINK-21343 URL: https://issues.apache.org/jira/browse/FLINK-21343 Project: Flink

[jira] [Created] (FLINK-21342) Various classes extending TestBases cannot be instantiated

2021-02-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21342: Summary: Various classes extending TestBases cannot be instantiated Key: FLINK-21342 URL: https://issues.apache.org/jira/browse/FLINK-21342 Project: Flink

[jira] [Created] (FLINK-21341) Update state reader to return InputFormat

2021-02-09 Thread Seth Wiesman (Jira)
Seth Wiesman created FLINK-21341: Summary: Update state reader to return InputFormat Key: FLINK-21341 URL: https://issues.apache.org/jira/browse/FLINK-21341 Project: Flink Issue Type: Improve

[jira] [Created] (FLINK-21340) CheckForbiddenMethodsUsage is not run and fails

2021-02-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21340: Summary: CheckForbiddenMethodsUsage is not run and fails Key: FLINK-21340 URL: https://issues.apache.org/jira/browse/FLINK-21340 Project: Flink Issue

[jira] [Created] (FLINK-21339) ExceptionUtilsITCases is not run and fails

2021-02-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21339: Summary: ExceptionUtilsITCases is not run and fails Key: FLINK-21339 URL: https://issues.apache.org/jira/browse/FLINK-21339 Project: Flink Issue Type

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Timo Walther
Hi Rui, 1. It depends whether you would like to declare (unresolved) or use (resolved) a schema. In catalogs and APIs, people would actually like to declare a schema. Because the schema might reference objects from other catalogs etc. However, whenever the schema comes out of the framework it

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Rui Li
Hi Timo, Thanks for the FLIP. It looks good to me overall. I have two questions. 1. When should we use a resolved schema and when to use an unresolved one? 2. The FLIP mentions only resolved tables/views can be stored into a catalog. Does that mean the getTable method should also return a resolved

[jira] [Created] (FLINK-21338) Relax test naming constraints

2021-02-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21338: Summary: Relax test naming constraints Key: FLINK-21338 URL: https://issues.apache.org/jira/browse/FLINK-21338 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Releasing Apache Flink 1.12.2

2021-02-09 Thread Yuan Mei
Thanks very much for your replies! I've been reaching out to the owners of the issues/blockers mentioned above. By now, we have Blocker Issues: - https://issues.apache.org/jira/browse/FLINK-21013: fixed - https://issues.apache.org/jira/browse/FLINK-21030: estimate to finish by t

[jira] [Created] (FLINK-21337) ComparableInputTypeStrategyTests is not running

2021-02-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21337: Summary: ComparableInputTypeStrategyTests is not running Key: FLINK-21337 URL: https://issues.apache.org/jira/browse/FLINK-21337 Project: Flink Issue

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Rui Li
Hi guys, The conclusion sounds good to me. On Tue, Feb 9, 2021 at 5:39 PM Shengkai Fang wrote: > Hi, Timo, Jark. > > I am fine with the new option name. > > Best, > Shengkai > > Timo Walther 于2021年2月9日 周二下午5:35写道: > > > Yes, `TableEnvironment#executeMultiSql()` can be future work. > > > > @Rui,

Re: Activate bloom filter in RocksDB State Backend via Flink configuration

2021-02-09 Thread Jun Qin
Thanks Till and Yun Tang. I’ve created https://issues.apache.org/jira/browse/FLINK-21336 and I will work on it. Thanks Jun > On Feb 9, 2021, at 7:52 AM, Yun Tang wrote: > > Hi Jun, > > Some predefined options would also activate bloom filt

[jira] [Created] (FLINK-21336) Activate bloom filter in RocksDB State Backend via Flink configuration

2021-02-09 Thread Jun Qin (Jira)
Jun Qin created FLINK-21336: --- Summary: Activate bloom filter in RocksDB State Backend via Flink configuration Key: FLINK-21336 URL: https://issues.apache.org/jira/browse/FLINK-21336 Project: Flink

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Timo Walther
Hi Jark, thanks for your feedback. Let me answer some of your comments: 1) Since we decided to build an entire new stack, we can also introduce better names for columns, constraints, and watermark spec. My goal was to shorten the names during this refactoring. Therefore, `TableSchema` becomes

Re: [DISCUSS] FLIP-164: Improve Schema Handling in Catalogs

2021-02-09 Thread Jark Wu
Hi Timo, The messy TableSchema confuses many developers. It's great to see we can finally come up with a clean interface hierarchy and still backward compatible. Thanks for preparing the nice FLIP. It looks good to me. I have some minor comments: 1) Should `ResolvedSchema#getColumn(int)` returns

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Shengkai Fang
Hi, Timo, Jark. I am fine with the new option name. Best, Shengkai Timo Walther 于2021年2月9日 周二下午5:35写道: > Yes, `TableEnvironment#executeMultiSql()` can be future work. > > @Rui, Shengkai: Are you also fine with this conclusion? > > Thanks, > Timo > > On 09.02.21 10:14, Jark Wu wrote: > > I'm fin

[jira] [Created] (FLINK-21335) READEME should use "mvn install" instead of "mvn package" to compile Flink

2021-02-09 Thread Dong Lin (Jira)
Dong Lin created FLINK-21335: Summary: READEME should use "mvn install" instead of "mvn package" to compile Flink Key: FLINK-21335 URL: https://issues.apache.org/jira/browse/FLINK-21335 Project: Flink

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Timo Walther
Yes, `TableEnvironment#executeMultiSql()` can be future work. @Rui, Shengkai: Are you also fine with this conclusion? Thanks, Timo On 09.02.21 10:14, Jark Wu wrote: I'm fine with `table.multi-dml-sync`. My previous concern about "multi" is that DML in CLI looks like single statement. But we c

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Jark Wu
I'm fine with `table.multi-dml-sync`. My previous concern about "multi" is that DML in CLI looks like single statement. But we can treat CLI as a multi-line accepting statements from opening to closing. Thus, I'm fine with `table.multi-dml-sync`. So the conclusion is `table.multi-dml-sync` (false

[jira] [Created] (FLINK-21334) Run kubernetes pyflink application test fails with Connection reset by peer on setup

2021-02-09 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-21334: -- Summary: Run kubernetes pyflink application test fails with Connection reset by peer on setup Key: FLINK-21334 URL: https://issues.apache.org/jira/browse/FLINK-21334

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-09 Thread Timo Walther
Hi everyone, I understand Rui's concerns. `table.dml-sync` should not apply to regular `executeSql`. Actually, this option makes only sense when executing multi statements. Once we have a `TableEnvironment.executeMultiSql()` this config could be considered. Maybe we can find a better generic

[jira] [Created] (FLINK-21333) Introduce stopping with savepoint state

2021-02-09 Thread Robert Metzger (Jira)
Robert Metzger created FLINK-21333: -- Summary: Introduce stopping with savepoint state Key: FLINK-21333 URL: https://issues.apache.org/jira/browse/FLINK-21333 Project: Flink Issue Type: Sub-t