Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Robert Metzger
> > Maybe we could leverage sonar cloud infrastructure for this. They already > have built in rules for deprecation warnings [1]. Also they have a free > offering for public open-source repositories [2]. > Cool, I didn't know this. There are already quite a lot of Apache Projects there: https://so

[jira] [Created] (FLINK-23392) Benchmarks should exclude startup/shutdown time

2021-07-14 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-23392: Summary: Benchmarks should exclude startup/shutdown time Key: FLINK-23392 URL: https://issues.apache.org/jira/browse/FLINK-23392 Project: Flink Issue

Re: [RESULT] [VOTE] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-07-14 Thread Yu Li
Good to know the result and thanks for driving this, Wenhao. Minor: according to the Flink bylaw [1] and recent announcement [2], Yuan Mei's vote is binding. Best Regards, Yu [1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Bylaws#FlinkBylaws-Actions [2] https://s.apache.org/99bg2 O

Re: [VOTE] Release 1.12.5, release candidate #1

2021-07-14 Thread Jingsong Li
Hi Till and Flinkers working for the FLINK-23233, Thanks for the effort! RC2 is on the way. Best, Jingsong On Tue, Jul 13, 2021 at 8:35 PM Till Rohrmann wrote: > Hi everyone, > > FLINK-23233 has been merged. We can continue with the release process. > > Cheers, > Till > > On Wed, Jul 7, 2021

[jira] [Created] (FLINK-23391) KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

2021-07-14 Thread Xintong Song (Jira)
Xintong Song created FLINK-23391: Summary: KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure Key: FLINK-23391 URL: https://issues.apache.org/jira/browse/FLINK-23391 Project: Flink

[jira] [Created] (FLINK-23390) FlinkKafkaInternalProducerITCase.testResumeTransactionAfterClosed

2021-07-14 Thread Xintong Song (Jira)
Xintong Song created FLINK-23390: Summary: FlinkKafkaInternalProducerITCase.testResumeTransactionAfterClosed Key: FLINK-23390 URL: https://issues.apache.org/jira/browse/FLINK-23390 Project: Flink

[jira] [Created] (FLINK-23389) AWS Glue Schema Registry JSON support for Apache Flink

2021-07-14 Thread Kexin Hui (Jira)
Kexin Hui created FLINK-23389: - Summary: AWS Glue Schema Registry JSON support for Apache Flink Key: FLINK-23389 URL: https://issues.apache.org/jira/browse/FLINK-23389 Project: Flink Issue Type:

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Martijn Visser
I was referring to the proposal to migrate all existing tests to JUnit 5 via one giant commit (as stated in step 3 from the voting email in the link I sent) On Wed, 14 Jul 2021 at 19:20, Chesnay Schepler wrote: > I don't believe this case was *explicitly *addressed in either the vote > or discus

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread David Morávek
> > For implementing this in practice, we could also extend our CI pipeline a > bit, and count the number of deprecation warnings while compiling Flink. > We would hard-code the current number of deprecations and fail the build if > that number increases. Maybe we could leverage sonar cloud infra

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Chesnay Schepler
I don't believe this case was /explicitly /addressed in either the vote or discussion thread. Please link the specific post if it was indeed mentioned. On 14/07/2021 19:13, Martijn Visser wrote: With regards to JUnit 5, there was a specific proposal and vote on how to deal with that migration

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Martijn Visser
With regards to JUnit 5, there was a specific proposal and vote on how to deal with that migration [1] Best regards, Martijn [1] https://lists.apache.org/thread.html/r89a2675bce01ccfdcfc47f2b0af6ef1afdbe4bad96d8c679cf68825e%40%3Cdev.flink.apache.org%3E On Wed, 14 Jul 2021 at 17:31, Chesnay Sc

[jira] [Created] (FLINK-23388) Non-static Scala case classes cannot be serialised

2021-07-14 Thread Toby Miller (Jira)
Toby Miller created FLINK-23388: --- Summary: Non-static Scala case classes cannot be serialised Key: FLINK-23388 URL: https://issues.apache.org/jira/browse/FLINK-23388 Project: Flink Issue Type:

Re: [RESULT][VOTE] FLIP-147: Support Checkpoint After Tasks Finished

2021-07-14 Thread Yun Gao
Hi Till, Very thanks for the review and comments! 1) First I think in fact we could be able to do the computation outside of the main thread, and the current implementation mainly due to the computation is in general fast and we initially want to have a simplified first version. The main req

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Chesnay Schepler
If someone started preparing a junit5 migration PR they will run into merge conflicts if everyone now starts replacing these instances at will. There are also some options on the table on how to actually do the migration; we can use hamcrest of course, or create a small wrapper in our test uti

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Stephan Ewen
@Chesnay - can you elaborate on this? In the classes I worked with so far, it was a 1:1 replacement of "org.junit.Assert.assertThat()" to "org.hamcrest.MatcherAssert.assertThat()". What other migration should happen there? On Wed, Jul 14, 2021 at 11:13 AM Chesnay Schepler wrote: > It may be bett

[jira] [Created] (FLINK-23387) WindowRankITCase.testEventTimeTumbleWindowWithoutRankNumber fails on azure

2021-07-14 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-23387: Summary: WindowRankITCase.testEventTimeTumbleWindowWithoutRankNumber fails on azure Key: FLINK-23387 URL: https://issues.apache.org/jira/browse/FLINK-23387 Pr

[jira] [Created] (FLINK-23386) Running 'Resuming Savepoint (rocks, scale down, rocks timers) end-to-end test failed with TimeoutException when stopping with savepoint

2021-07-14 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-23386: Summary: Running 'Resuming Savepoint (rocks, scale down, rocks timers) end-to-end test failed with TimeoutException when stopping with savepoint Key: FLINK-23386 URL: htt

[jira] [Created] (FLINK-23385) org.apache.flink.table.api.TableException when using REGEXP_EXTRACT

2021-07-14 Thread Jira
Maciej Bryński created FLINK-23385: -- Summary: org.apache.flink.table.api.TableException when using REGEXP_EXTRACT Key: FLINK-23385 URL: https://issues.apache.org/jira/browse/FLINK-23385 Project: Flin

Re: [RESULT][VOTE] FLIP-147: Support Checkpoint After Tasks Finished

2021-07-14 Thread Till Rohrmann
Hi everyone, I am a bit late to the voting party but let me ask three questions: 1) Why do we execute the trigger plan computation in the main thread if we cannot guarantee that all tasks are still running when triggering the checkpoint? Couldn't we do the computation in a different thread in ord

[jira] [Created] (FLINK-23384) Use upper case name for all BuiltInFunctionDefinitions

2021-07-14 Thread Timo Walther (Jira)
Timo Walther created FLINK-23384: Summary: Use upper case name for all BuiltInFunctionDefinitions Key: FLINK-23384 URL: https://issues.apache.org/jira/browse/FLINK-23384 Project: Flink Issue

[jira] [Created] (FLINK-23383) FlinkEnvironmentContext#setUp is called twice

2021-07-14 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-23383: Summary: FlinkEnvironmentContext#setUp is called twice Key: FLINK-23383 URL: https://issues.apache.org/jira/browse/FLINK-23383 Project: Flink Issue T

[jira] [Created] (FLINK-23382) Performance regression on 13.07.2021

2021-07-14 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-23382: -- Summary: Performance regression on 13.07.2021 Key: FLINK-23382 URL: https://issues.apache.org/jira/browse/FLINK-23382 Project: Flink Issue Type: Bug

Flink 1.14. Bi-weekly 2021-07-206

2021-07-14 Thread Johannes Moser
Hi, Here's an update from last weeks Bi-weekly. For sure the page is up to date [1]. *Feature freeze date* The feature freeze date is getting closer (only ~4 weeks left) and having a look at the features list there's still a lot to do. We went through all features and it looks like it will be t

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Robert Metzger
For implementing this in practice, we could also extend our CI pipeline a bit, and count the number of deprecation warnings while compiling Flink. We would hard-code the current number of deprecations and fail the build if that number increases. We could actually extend this and run a curated list

[jira] [Created] (FLINK-23381) Provide backpressure (currently job fails if a limit hit)

2021-07-14 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-23381: - Summary: Provide backpressure (currently job fails if a limit hit) Key: FLINK-23381 URL: https://issues.apache.org/jira/browse/FLINK-23381 Project: Flink

Re: [DISCUSS] FLIP-183: Dynamic buffer size adjustment

2021-07-14 Thread Piotr Nowojski
Hi Steven, As downstream/upstream nodes are decoupled, if downstream nodes adjust first it's buffer size first, there will be a lag until this updated buffer size information reaches the upstream node.. It is a problem, but it has a quite simple solution that we described in the FLIP document: >

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Chesnay Schepler
It may be better to not do that to ease the migration to junit5, where we have to address exactly these usages. On 14/07/2021 09:57, Till Rohrmann wrote: I actually found myself recently, whenever touching a test class, replacing Junit's assertThat with Hamcrest's version which felt quite tedio

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Stephan Ewen
@Chesnay - Good question. I think we can be pragmatic there. If you upgrade Jackson, pick a class that uses it and look for the common methods. If everything is fine there, it is probably fine overall. If one or two deprecated method usages are overlooked, no problem, that's not an issue. If a comm

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Chesnay Schepler
How do you propose to do this in practice? Let's say I bump jackson, how would I find all new usages of deprecated APIs? Build it locally and grep the maven output for jackson? On 14/07/2021 10:51, Yangze Guo wrote: +1 for fixing deprecation warnings when bumping/changing dependencies. Not on

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Yangze Guo
+1 for fixing deprecation warnings when bumping/changing dependencies. Not only for the dependencies, we also use the deprecated API of Flink itself in `flink-examples` and the document, e.g. the #writeAsText. I think it would be good to do a clean-up for usability. WDYT? Best, Yangze Guo On Wed

[VOTE] Release 1.13.2, release candidate #2

2021-07-14 Thread Yun Tang
Hi everyone, Please review and vote on the release candidate #2 for the version 1.13.2, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],

Re: [NOTICE] flink-runtime now scala-free

2021-07-14 Thread Yun Tang
Great news, thanks for Chesnay's work! Best Yun Tang From: Martijn Visser Sent: Wednesday, July 14, 2021 16:05 To: dev@flink.apache.org Subject: Re: [NOTICE] flink-runtime now scala-free This is a great achievement, thank you for driving this! On Tue, 13 Jul 20

[jira] [Created] (FLINK-23379) interval left join null value result out of order

2021-07-14 Thread waywtdcc (Jira)
waywtdcc created FLINK-23379: Summary: interval left join null value result out of order Key: FLINK-23379 URL: https://issues.apache.org/jira/browse/FLINK-23379 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-23380) The parameter contains "#" and content after "#" cannot be recognized

2021-07-14 Thread Jacob.Q.Cao (Jira)
Jacob.Q.Cao created FLINK-23380: --- Summary: The parameter contains "#" and content after "#" cannot be recognized Key: FLINK-23380 URL: https://issues.apache.org/jira/browse/FLINK-23380 Project: Flink

Re: [NOTICE] flink-runtime now scala-free

2021-07-14 Thread Martijn Visser
This is a great achievement, thank you for driving this! On Tue, 13 Jul 2021 at 18:20, Chesnay Schepler wrote: > Hello everyone, > > I just merged the last PR for FLINK-14105, with which flink-runtime is > now officially scala-free. *fireworks* > > > What does that mean in practice? > >

Re: [DISCUSS] Address deprecation warnings when upgrading dependencies

2021-07-14 Thread Till Rohrmann
I think this suggestion makes a lot of sense, Stephan. +1 for fixing deprecation warnings when bumping/changing dependencies. I actually found myself recently, whenever touching a test class, replacing Junit's assertThat with Hamcrest's version which felt quite tedious. Cheers, Till On Tue, Jul 1

[jira] [Created] (FLINK-23378) ContinuousProcessingTimeTrigger最后一个定时器无法触发

2021-07-14 Thread frey (Jira)
frey created FLINK-23378: Summary: ContinuousProcessingTimeTrigger最后一个定时器无法触发 Key: FLINK-23378 URL: https://issues.apache.org/jira/browse/FLINK-23378 Project: Flink Issue Type: Bug Affects Versio