Re:Re: [VOTE] FLIP-287: Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID

2023-06-18 Thread Yuepeng Pan
+1 (non-binding) Thanks, Roc 在 2023-06-19 10:55:05,"Zhu Zhu" 写道: >+1 (binding) > >Thanks, >Zhu > >Tzu-Li (Gordon) Tai 于2023年6月17日周六 11:32写道: >> >> +1 (binding) >> >> On Fri, Jun 16, 2023, 09:53 Jing Ge wrote: >> >> > +1(binding) >> > >> > Best Regards, >> > Jing >> > >> > On Fri, Jun 16,

Re: [VOTE] FLIP-287: Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID

2023-06-18 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Tzu-Li (Gordon) Tai 于2023年6月17日周六 11:32写道: > > +1 (binding) > > On Fri, Jun 16, 2023, 09:53 Jing Ge wrote: > > > +1(binding) > > > > Best Regards, > > Jing > > > > On Fri, Jun 16, 2023 at 10:10 AM Lijie Wang > > wrote: > > > > > +1 (binding) > > > > > > Thanks for

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-18 Thread John Roesler
Hi Becket, Thanks for the reply! I’d like to continue the conversation about compatibility outside of this FLIP thread, but for now, I can accept your decision. It’s certainly an improvement. Thanks again, John On Sun, Jun 18, 2023, at 21:42, Becket Qin wrote: > Hi John, > > Completely agree

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-18 Thread Becket Qin
Hi John, Completely agree with all you said. Can we consider only dropping deprecated APIs in major releases across the > board? I understand that Experimental and PublicEvolving APIs are by > definition less stable, but it seems like this should be reflected in the > required deprecation period

[jira] [Created] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread Jane Chan (Jira)
Jane Chan created FLINK-32374: - Summary: ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting Key: FLINK-32374 URL: https://issues.apache.org/jira/browse/FLINK-32374

Re: [NOTICE] Experimental Java 17 support now available on master

2023-06-18 Thread Kurt Ostfeld
I think there is some confusion: Chesnay, not me, recently checked in changes into master so that Flink will build + test + run with experimental support for Java 17 but with Kryo 2.x as-is so this will error with Java records. Chesnay created this particular email thread related to this work.

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-18 Thread Aitozi
Hi all, Sorry for the late reply, I have a discussion with Lincoln offline, mainly about the naming of the hints option. Thanks Lincoln for the valuable suggestions. Let me answer the last email inline. >For `JavaAsyncTableFunc0` in flip, can you use a scenario like RPC call as an example?

Re: [NOTICE] Experimental Java 17 support now available on master

2023-06-18 Thread Jing Ge
Hi Kurt, Thanks for your contribution. I am a little bit confused about the email title, since your PR[1] is not merged into the master yet. I guess, with "Experimental Java 17 support", you meant it is available on your branch which is based on the master. If I am not mistaken, there is no vote