Re: Flink and Flink shaded dependency

2023-09-13 Thread Martijn Visser
Hi Jing, Flink Shaded exists so that Flinks internal usage of commonly used packages such as Guava, Jackson inside of Flink don't clash with different versions that users might use when creating a Flink application. When I did the upgrade of Flink Shaded, we already ran into a bunch of problems be

[jira] [Created] (FLINK-33080) The checkpoint storage configured in the job level by config option will not take effect

2023-09-13 Thread Junrui Li (Jira)
Junrui Li created FLINK-33080: - Summary: The checkpoint storage configured in the job level by config option will not take effect Key: FLINK-33080 URL: https://issues.apache.org/jira/browse/FLINK-33080 Pr

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Ahmed Hamdy
Hi Rui, I have gone through the thread. +1 (non-binding) Best Regards Ahmed Hamdy On Wed, 13 Sept 2023 at 03:53, Rui Fan <1996fan...@gmail.com> wrote: > Hi all, > > Thanks for all the feedback about the FLIP-334: > Decoupling autoscaler and kubernetes and > support the Standalone Autoscaler[1].

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread ConradJam
best idea +1 (non-binding) Ahmed Hamdy 于2023年9月13日周三 15:23写道: > Hi Rui, > I have gone through the thread. > +1 (non-binding) > > Best Regards > Ahmed Hamdy > > > On Wed, 13 Sept 2023 at 03:53, Rui Fan <1996fan...@gmail.com> wrote: > > > Hi all, > > > > Thanks for all the feedback about the FLIP-

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Matt Wang
Thank you for driving this FLIP, +1 (non-binding) -- Best, Matt Wang Replied Message | From | ConradJam | | Date | 09/13/2023 15:28 | | To | | | Subject | Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler | best idea +1 (non-binding)

Re: [DISCUSS] FLINK-25927: Make flink-connector-base dependency usage consistent across all connectors

2023-09-13 Thread Hang Ruan
Hi, all. I would like to help to do some work about this issue. Because some classes in flink-connector-base are supposed to be used inside the user jar directly, FLINK-25927[1] has been reverted by FLINK-26701[2]. And the final solution is as follows. - package flink-connector-base into flink-di

RE: Re: [DISCUSS] FLIP-229: Prometheus Sink Connector

2023-09-13 Thread Lorenzo Nicora
Hello I was working with Karthi and took over development. I have a working version already. I also updated the FLIP (now FLIP-312, it was renumbered due to a clash) Please, let me know how to proceed with this. Happy to answer any questions about the FLIP Regards Lorenzo [1] https://cwiki.apach

[jira] [Created] (FLINK-33081) Move parallelism override logic into scale method

2023-09-13 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33081: -- Summary: Move parallelism override logic into scale method Key: FLINK-33081 URL: https://issues.apache.org/jira/browse/FLINK-33081 Project: Flink Issue Type: Imp

Re: Future of classical remoting in Pekko

2023-09-13 Thread Ferenc Csaky
The target release date for 1.18 is the end of Sept [1], but I'm not sure everything will come together by then. Maybe it will pushed by a couple days. I'm happy to help out, even making the Flink related changes when we're at that point. [1] https://cwiki.apache.org/confluence/display/FLINK/1.

[jira] [Created] (FLINK-33082) Azure Pipelines 4 is not responding on AZP

2023-09-13 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33082: --- Summary: Azure Pipelines 4 is not responding on AZP Key: FLINK-33082 URL: https://issues.apache.org/jira/browse/FLINK-33082 Project: Flink Issue Type:

[jira] [Created] (FLINK-33083) SupportsReadingMetadata is not applied when loading a CompiledPlan

2023-09-13 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33083: Summary: SupportsReadingMetadata is not applied when loading a CompiledPlan Key: FLINK-33083 URL: https://issues.apache.org/jira/browse/FLINK-33083 Project: F

[jira] [Created] (FLINK-33084) Migrate globalJobParameter in ExecutionConfig to configuration instance

2023-09-13 Thread Junrui Li (Jira)
Junrui Li created FLINK-33084: - Summary: Migrate globalJobParameter in ExecutionConfig to configuration instance Key: FLINK-33084 URL: https://issues.apache.org/jira/browse/FLINK-33084 Project: Flink

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Gyula Fóra
+1 (binding) Gyula On Wed, 13 Sep 2023 at 09:33, Matt Wang wrote: > Thank you for driving this FLIP, > > +1 (non-binding) > > > -- > > Best, > Matt Wang > > > Replied Message > | From | ConradJam | > | Date | 09/13/2023 15:28 | > | To | | > | Subject | Re: [VOTE] FLIP-334: Decoupling

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Maximilian Michels
+1 (binding) On Wed, Sep 13, 2023 at 12:28 PM Gyula Fóra wrote: > > +1 (binding) > > Gyula > > On Wed, 13 Sep 2023 at 09:33, Matt Wang wrote: > > > Thank you for driving this FLIP, > > > > +1 (non-binding) > > > > > > -- > > > > Best, > > Matt Wang > > > > > > Replied Message > > | Fro

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Ferenc Csaky
Looking forward to this! +1 (non-binding) Cheers, Ferenc --- Original Message --- On Wednesday, September 13th, 2023 at 12:33, Maximilian Michels wrote: > > > +1 (binding) > > On Wed, Sep 13, 2023 at 12:28 PM Gyula Fóra gyula.f...@gmail.com wrote: > > > +1 (binding) > > > > Gyu

Re: Flink and Flink shaded dependency

2023-09-13 Thread Jing Ge
Hi Martijn, Thanks for your reply with details. Appreciate it. > Flink-Shaded is usually only updated whenever a > new Flink minor version is released and only at the beginning of the > release cycle, so that there's enough time to stabilize Flink. This is the information I am looking for. It

[jira] [Created] (FLINK-33085) Improve the error message when the invalidate lookupTableSource without primary key is used as temporal join table

2023-09-13 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-33085: - Summary: Improve the error message when the invalidate lookupTableSource without primary key is used as temporal join table Key: FLINK-33085 URL: https://issues.apache.org/jira/

Re: Flink and Flink shaded dependency

2023-09-13 Thread Martijn Visser
Hi Jing, A PR to update the readme sounds like a good plan. I think it depends on what are the expected updates for a flink-shaded 16.2, since that version doesn't exist. Best regards, Martijn On Wed, Sep 13, 2023 at 1:48 PM Jing Ge wrote: > Hi Martijn, > > Thanks for your reply with details

Re: Flink and Flink shaded dependency

2023-09-13 Thread Jing Ge
Hi Martijn, For example, bump up guava from 30.1.1-jre to 32.1.2-jre. Best regards, Jing On Wed, Sep 13, 2023 at 2:37 PM Martijn Visser wrote: > Hi Jing, > > A PR to update the readme sounds like a good plan. > > I think it depends on what are the expected updates for a flink-shaded > 16.2, si

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

2023-09-13 Thread Chen Zhanghao
Hi Jing, Thanks for the suggestion. Endpoint is indeed a more professional word in the networking world but I think location is more suited here for two reasons: 1. The term here is for uniquely identifying the TaskManager where the task is deployed while providing the host machine info as w

Re: Flink and Flink shaded dependency

2023-09-13 Thread Sergey Nuyanzin
Hi Jing, If I remember correctly, bumping of guava to another major version usually leads to package rename since the major version number is a part of the package name... Not 100% sure however this could be the reason for some potential breaking changes (we also faced that with connectors while t

回复: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Chen Zhanghao
Thanks for driving this. +1 (non-binding) Best, Zhanghao Chen 发件人: Rui Fan <1996fan...@gmail.com> 发送时间: 2023年9月13日 10:52 收件人: dev 主题: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler Hi all, Thanks for all the feedback

Re: [DISCUSS] FLIP-361: Improve GC Metrics

2023-09-13 Thread Gyula Fóra
Thanks for all the feedback, I will start the vote on this. Gyula On Wed, Sep 6, 2023 at 11:11 AM Xintong Song wrote: > > > > I added the average time metric to the FLIP document. I also included it > > for the aggregate (total) across all collectors. But maybe it doesn't > make > > too much se

[VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Gyula Fóra
Hi All! Thanks for all the feedback on FLIP-361: Improve GC Metrics [1][2] I'd like to start a vote for it. The vote will be open for at least 72 hours unless there is an objection or insufficient votes. Cheers, Gyula [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-361%3A+Improve+GC+

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Rui Fan
+1(binding) Best, Rui On Wed, Sep 13, 2023 at 9:16 PM Gyula Fóra wrote: > Hi All! > > Thanks for all the feedback on FLIP-361: Improve GC Metrics [1][2] > > I'd like to start a vote for it. The vote will be open for at least 72 > hours unless there is an objection or insufficient votes. > > Che

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Feng Jin
Thanks for driving this, looking forward to this feature. +1 (non-binding) Best, Feng On Wed, Sep 13, 2023 at 9:11 PM Chen Zhanghao wrote: > Thanks for driving this. +1 (non-binding) > > Best, > Zhanghao Chen > > 发件人: Rui Fan <1996fan...@gmail.com> > 发送时间: 202

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Wed, 13 Sept 2023 at 14:22, Rui Fan <1996fan...@gmail.com> wrote: > +1(binding) > > Best, > Rui > > On Wed, Sep 13, 2023 at 9:16 PM Gyula Fóra wrote: > > > Hi All! > > > > Thanks for all the feedback on FLIP-361: Improve GC Metrics [1][2] > > > > I'd

回复: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Chen Zhanghao
+1 (unbinding). Looking forward to it Best, Zhanghao Chen 发件人: Gyula Fóra 发送时间: 2023年9月13日 21:16 收件人: dev 主题: [VOTE] FLIP-361: Improve GC Metrics Hi All! Thanks for all the feedback on FLIP-361: Improve GC Metrics [1][2] I'd like to start a vote for it. The vo

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread ConradJam
+1 (non-binding) gc metrics help with autoscale tuning features Chen Zhanghao 于2023年9月13日周三 22:16写道: > +1 (unbinding). Looking forward to it > > Best, > Zhanghao Chen > > 发件人: Gyula Fóra > 发送时间: 2023年9月13日 21:16 > 收件人: dev > 主题: [VOTE] FLIP-361: Improve GC Metr

Re: Flink and Flink shaded dependency

2023-09-13 Thread Martijn Visser
Hi Jing, Like Sergey said, making that change would break all connectors that used Flink Shaded in the released versions, given that Guava is part of the package name. I think that was the case for Kafka, Pulsar, JDBC, PubSub, HBase, Cassandra and maybe even more. We shouldn't do this upgrade. Be

Re: Flink and Flink shaded dependency

2023-09-13 Thread Jing Ge
Hi Sergey, Hi Martijn, Thanks for the information and suggestions. It is rational. Since on one hand, we should not do the upgrade according to all your thoughts, and on the other hand, Guava 30.1.1-jre has known CVEs[1] and the next closest version that has no CVEs is 32.0.1-jre. Without the upg

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Samrat Deb
+1 (non binding ) Best, Samrat On Wed, 13 Sep 2023 at 7:08 PM, Feng Jin wrote: > Thanks for driving this, looking forward to this feature. > > > +1 (non-binding) > > Best, > Feng > > On Wed, Sep 13, 2023 at 9:11 PM Chen Zhanghao > wrote: > > > Thanks for driving this. +1 (non-binding) > > > >

[VOTE] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread Archit Goyal
Hi everyone, Thanks for reviewing the FLIP-355 Add parent dir of files to classpath using yarn.provided.lib.dirs : https://cwiki.apache.org/confluence/display/FLINK/FLIP+355%3A+Add+parent+dir+of+files+to+classpath+using+yarn.provided.lib.dirs Following is the discussion thread : https://lists.ap

Re: [VOTE] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread Venkatakrishnan Sowrirajan
Thanks for driving this FLIP, Archit. +1 (non-binding) Regards Venkata krishnan On Wed, Sep 13, 2023 at 10:47 AM Archit Goyal wrote: > Hi everyone, > > Thanks for reviewing the FLIP-355 Add parent dir of files to classpath > using yarn.provided.lib.dirs : > > https://urldefense.com/v3/__https:

Re: [DISCUSS] FLIP-361: Improve GC Metrics

2023-09-13 Thread Venkatakrishnan Sowrirajan
Hi Gyula, Thanks for driving this FLIP. The proposal looks good to me. Only one minor suggestion I have is, can we also include the % GC time spent wrt the overall CPU time especially useful in the cases of TM which helps in easily identifying issues related to GC. Thoughts? Regards Venkata kris

Re: [DISCUSS] FLIP-361: Improve GC Metrics

2023-09-13 Thread Gyula Fóra
Hi Venkata, Unfortunately the GC CPU Usage , percentage or otherwise, is not something that the JVM GC beans expose. So I am afraid we cannot easily add that. Regards Gyula On Wed, Sep 13, 2023 at 7:59 PM Venkatakrishnan Sowrirajan wrote: > Hi Gyula, > > Thanks for driving this FLIP. > > The p

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Samrat Deb
+1 ( non binding) These improved GC metrics will be a great addition. Bests, Samrat On Wed, 13 Sep 2023 at 7:58 PM, ConradJam wrote: > +1 (non-binding) > gc metrics help with autoscale tuning features > > Chen Zhanghao 于2023年9月13日周三 22:16写道: > > > +1 (unbinding). Looking forward to it > > > >

Re: Flink and Flink shaded dependency

2023-09-13 Thread Sergey Nuyanzin
Thanks for raising this I would suggest trying to double check whether it actually impacts Flink or not. For instance from one side Calcite between 1.22.0..1.31.0 has a critical CVE-2022-39135 [1] from another side Flink does not use this functionality and is not impacted by this. Regarding guav

Re: Flink and Flink shaded dependency

2023-09-13 Thread Jing Ge
Hi Sergey, Thanks for doing the analysis and providing the great insight. I did my own analysis and got the same conclusion. I just wanted to use this example to kick off a discussion and check if there is a common guideline or concept in the community to handle such cases, since it seems any bump

Re: [DISCUSS] Flink annotation strategy/consensus

2023-09-13 Thread Becket Qin
> > Does it make sense to clearly define that APIs without annotation are > internal APIs and should be used outside of Flink. And deprecate @Internal? We can do this. Although I think it is OK to keep the @Internal annotation in case extra clarity is needed sometimes. Thanks, Jiangjie (Becket)

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread Dong Lin
Thank you Rui for the proposal. +1 (binding) On Wed, Sep 13, 2023 at 10:52 AM Rui Fan <1996fan...@gmail.com> wrote: > Hi all, > > Thanks for all the feedback about the FLIP-334: > Decoupling autoscaler and kubernetes and > support the Standalone Autoscaler[1]. > This FLIP was discussed in [2]. >

[jira] [Created] (FLINK-33086) Protect failure enrichment against unhandled exceptions

2023-09-13 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33086: -- Summary: Protect failure enrichment against unhandled exceptions Key: FLINK-33086 URL: https://issues.apache.org/jira/browse/FLINK-33086 Project: F

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Matt Wang
+1 (non-binding) Thanks for driving this FLIP -- Best, Matt Wang Replied Message | From | Xintong Song | | Date | 09/14/2023 09:54 | | To | | | Subject | Re: [VOTE] FLIP-361: Improve GC Metrics | +1 (binding) Best, Xintong On Thu, Sep 14, 2023 at 2:40 AM Samrat Deb wrote:

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Xintong Song
+1 (binding) Best, Xintong On Thu, Sep 14, 2023 at 2:40 AM Samrat Deb wrote: > +1 ( non binding) > > These improved GC metrics will be a great addition. > > Bests, > Samrat > > On Wed, 13 Sep 2023 at 7:58 PM, ConradJam wrote: > > > +1 (non-binding) > > gc metrics help with autoscale tuning

Re: [VOTE] FLIP-334: Decoupling autoscaler and kubernetes and support the Standalone Autoscaler

2023-09-13 Thread liu ron
+1(non-binding) Best, Ron Dong Lin 于2023年9月14日周四 09:01写道: > Thank you Rui for the proposal. > > +1 (binding) > > On Wed, Sep 13, 2023 at 10:52 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hi all, > > > > Thanks for all the feedback about the FLIP-334: > > Decoupling autoscaler and kubernetes

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Dong Lin
Thanks for the FLIP! +1(binding) On Wed, Sep 13, 2023 at 9:16 PM Gyula Fóra wrote: > Hi All! > > Thanks for all the feedback on FLIP-361: Improve GC Metrics [1][2] > > I'd like to start a vote for it. The vote will be open for at least 72 > hours unless there is an objection or insufficient vot

Re: [VOTE] FLIP-361: Improve GC Metrics

2023-09-13 Thread Venkatakrishnan Sowrirajan
+1 (non-binding) On Wed, Sep 13, 2023, 6:55 PM Matt Wang wrote: > +1 (non-binding) > > > Thanks for driving this FLIP > > > > > -- > > Best, > Matt Wang > > > Replied Message > | From | Xintong Song | > | Date | 09/14/2023 09:54 | > | To | | > | Subject | Re: [VOTE] FLIP-361: Improve

Re: [VOTE] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread Dong Lin
Thanks Archit for the FLIP. +1 (binding) Regards, Dong On Thu, Sep 14, 2023 at 1:47 AM Archit Goyal wrote: > Hi everyone, > > Thanks for reviewing the FLIP-355 Add parent dir of files to classpath > using yarn.provided.lib.dirs : > > https://cwiki.apache.org/confluence/display/FLINK/FLIP+355%3

Re: [VOTE] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread Becket Qin
+1 (binding) Thanks for the FLIP, Archit. Cheers, Jiangjie (Becket) Qin On Thu, Sep 14, 2023 at 10:31 AM Dong Lin wrote: > Thanks Archit for the FLIP. > > +1 (binding) > > Regards, > Dong > > On Thu, Sep 14, 2023 at 1:47 AM Archit Goyal > > wrote: > > > Hi everyone, > > > > Thanks for revie

Re: Future of classical remoting in Pekko

2023-09-13 Thread He Pin
Thanks, The PR[1] is ready now, would you like to help review it, thanks. 1. https://github.com/apache/incubator-pekko/pull/643 On 2023/09/13 09:20:48 Ferenc Csaky wrote: > The target release date for 1.18 is the end of Sept [1], but I'm not sure > everything will come together by then. Maybe it

Re: [VOTE] FLIP-355: Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread Yang Wang
+1 (binding) Best, Yang Becket Qin 于2023年9月14日周四 11:01写道: > +1 (binding) > > Thanks for the FLIP, Archit. > > Cheers, > > Jiangjie (Becket) Qin > > > On Thu, Sep 14, 2023 at 10:31 AM Dong Lin wrote: > > > Thanks Archit for the FLIP. > > > > +1 (binding) > > > > Regards, > > Dong > > > > On Thu

Re:[DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-13 Thread Wencong Liu
Dear Dong, I have thoroughly reviewed the proposal for FLIP-331 and believe it would be a valuable addition to Flink. However, I do have a few questions that I would like to discuss: 1. The FLIP-331 proposed the EndOfStreamWindows that is implemented by TimeWindow with maxTimestamp = (Long.MA

[VOTE] FLIP-357: Deprecate Iteration API of DataStream

2023-09-13 Thread Wencong Liu
Hi dev, I'd like to start a vote on FLIP-357. Discussion thread: https://lists.apache.org/thread/shf77phc0wzlbj06jsfj3nclxnm2mrv5 FLIP: https://cwiki.apache.org/confluence/display/FLINK/FLIP-357%3A+Deprecate+Iteration+API+of+DataStream Best regards, Wencong Liu

Re: [VOTE] FLIP-357: Deprecate Iteration API of DataStream

2023-09-13 Thread Dong Lin
Thanks Wencong for the FLIP. +1 (binding) On Thu, Sep 14, 2023 at 12:36 PM Wencong Liu wrote: > Hi dev, > > > I'd like to start a vote on FLIP-357. > > > Discussion thread: > https://lists.apache.org/thread/shf77phc0wzlbj06jsfj3nclxnm2mrv5 > FLIP: > https://cwiki.apache.org/confluence/display/F

[DISCUSS] FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-09-13 Thread Chen Zhanghao
Hi Devs, Dewei (cced) and I would like to start a discussion on FLIP-367: Support Setting Parallelism for Table/SQL Sources [1]. Currently, Flink Table/SQL jobs do not expose fine-grained control of operator parallelism to users. FLIP-146 [2] brings us support for setting parallelism for sinks