- Force push your branch to update the PR
Sorry for this noise!
Thank you,
FG
--
Francesco Guardiani | Software Engineer
france...@ververica.com
<https://www.ververica.com/>
Follow us @VervericaData
--
Join Flink Forward <https://flink-forward.org/> - The Apache Flink
Con
Francesco Guardiani created FLINK-27201:
---
Summary: Remove CollectTableSink
Key: FLINK-27201
URL: https://issues.apache.org/jira/browse/FLINK-27201
Project: Flink
Issue Type: Sub-task
Francesco Guardiani created FLINK-27200:
---
Summary: Replace CollectionTableSource and CollectionTableSink
with new table stack alternatives
Key: FLINK-27200
URL: https://issues.apache.org/jira/browse/FLINK
Francesco Guardiani created FLINK-27198:
---
Summary: Cleanup tests testing legacy TableSink/TableSource
Key: FLINK-27198
URL: https://issues.apache.org/jira/browse/FLINK-27198
Project: Flink
Francesco Guardiani created FLINK-27197:
---
Summary: Port ArrowTableSource and PythonInputFormatTableSource to
DynamicTableSource
Key: FLINK-27197
URL: https://issues.apache.org/jira/browse/FLINK-27197
Francesco Guardiani created FLINK-27196:
---
Summary: Remove old format interfaces
Key: FLINK-27196
URL: https://issues.apache.org/jira/browse/FLINK-27196
Project: Flink
Issue Type: Sub
Francesco Guardiani created FLINK-27185:
---
Summary: Run the assertj conversion script to convert assertions
in connectors and formats
Key: FLINK-27185
URL: https://issues.apache.org/jira/browse/FLINK-27185
Francesco Guardiani created FLINK-27043:
---
Summary: Remove CSV connector test usages
Key: FLINK-27043
URL: https://issues.apache.org/jira/browse/FLINK-27043
Project: Flink
Issue Type
Francesco Guardiani created FLINK-26988:
---
Summary: Better error reporting when format fails
Key: FLINK-26988
URL: https://issues.apache.org/jira/browse/FLINK-26988
Project: Flink
Issue
Francesco Guardiani created FLINK-26952:
---
Summary: Remove old CSV connector
Key: FLINK-26952
URL: https://issues.apache.org/jira/browse/FLINK-26952
Project: Flink
Issue Type: Sub-task
Francesco Guardiani created FLINK-26950:
---
Summary: Remove TableSink and TableSource interfaces
Key: FLINK-26950
URL: https://issues.apache.org/jira/browse/FLINK-26950
Project: Flink
Sorry I replied on the wrong thread, i repost my answer here :)
As there was already a discussion in the doc, I'll just summarize my
opinions here on the proposed execution of this FLIP.
I think we should rather avoid exposing internal details, which I consider
Calcite to be part of, but rather r
As there was already a discussion in the doc, I'll just summarize my
opinions here on the proposed execution of this FLIP.
I think we should rather avoid exposing internal details, which I consider
Calcite to be part of, but rather reuse what we already have to define an
AST from Table API, which
Francesco Guardiani created FLINK-26782:
---
Summary: Remove PlannerExpression and related
Key: FLINK-26782
URL: https://issues.apache.org/jira/browse/FLINK-26782
Project: Flink
Issue
Francesco Guardiani created FLINK-26704:
---
Summary: Remove string expression DSL
Key: FLINK-26704
URL: https://issues.apache.org/jira/browse/FLINK-26704
Project: Flink
Issue Type: Sub
> > >
> > > > It's not really a bugfix. But it might help developers with their
> > > > backports.
> > > >
> > > > Matthias
> > > >
> > > > [1] https://github.com/apache/flink/pull/17871
> > > >
Congratulations, Yuan!
On Mon, Mar 14, 2022 at 3:51 PM yanfei lei wrote:
> Congratulations, Yuan!
>
>
>
> Zhilong Hong 于2022年3月14日周一 19:31写道:
>
> > Congratulations, Yuan!
> >
> > Best,
> > Zhilong
> >
> > On Mon, Mar 14, 2022 at 7:22 PM Konstantin Knauf
> > wrote:
> >
> > > Congratulations, Yu
Francesco Guardiani created FLINK-26582:
---
Summary: Run the assertj conversion script to convert assertions
in flink-table
Key: FLINK-26582
URL: https://issues.apache.org/jira/browse/FLINK-26582
to the build system.
> >
> > Seth
> >
> > On Wed, Mar 9, 2022 at 9:45 AM Francesco Guardiani <
> > france...@ververica.com>
> > wrote:
> >
> > > Hi all,
> > > I've been spending some time prototyping a scalafmt conf, which does
> 主题: Re: [DISCUSS] Enable scala formatting check
> > >
> > >
> > >
> > > +1 I've never written any Scala in Flink, but this makes a lot of sense
> > to
> > > me. Converging on a smaller set of tools and simplifying the build is
> &
Francesco Guardiani created FLINK-26553:
---
Summary: Enable scalafmt for scala codebase
Key: FLINK-26553
URL: https://issues.apache.org/jira/browse/FLINK-26553
Project: Flink
Issue Type
confusing for new users. Last but
> not
> > >> least, I believe the impact on existing users will be minimal (since
> it
> > can
> > >> be changed by changing one flag).
> > >>
> > >> Best regards,
> > >>
> > >> Martijn
>
Francesco Guardiani created FLINK-26551:
---
Summary: Make the legacy behavior disabled by default
Key: FLINK-26551
URL: https://issues.apache.org/jira/browse/FLINK-26551
Project: Flink
Francesco Guardiani created FLINK-26549:
---
Summary: INSERT INTO with VALUES leads to wrong type inference
with nested types
Key: FLINK-26549
URL: https://issues.apache.org/jira/browse/FLINK-26549
Francesco Guardiani created FLINK-26520:
---
Summary: Implement SEARCH operator
Key: FLINK-26520
URL: https://issues.apache.org/jira/browse/FLINK-26520
Project: Flink
Issue Type
Francesco Guardiani created FLINK-26519:
---
Summary: Remove FlinkTypeFactory.INSTANCE singleton
Key: FLINK-26519
URL: https://issues.apache.org/jira/browse/FLINK-26519
Project: Flink
Congratulations Martjin!
On Fri, Mar 4, 2022 at 8:38 AM Ingo Bürk wrote:
> Congrats, Martijn!
>
> On 03.03.22 16:49, Robert Metzger wrote:
> > Hi everyone,
> >
> > On behalf of the PMC, I'm very happy to announce Martijn Visser as a new
> > Flink committer.
> >
> > Martijn is a very active Flink
Francesco Guardiani created FLINK-26463:
---
Summary: TableEnvironmentITCase should use MiniCluster
Key: FLINK-26463
URL: https://issues.apache.org/jira/browse/FLINK-26463
Project: Flink
:
* mvn spotless:check will check both java and scala
* mvn spotless:apply will format both java and scala
WDYT?
FG
--
Francesco Guardiani | Software Engineer
france...@ververica.com
<https://www.ververica.com/>
Follow us @VervericaData
--
Join Flink Forward <https://flink-forward.o
Francesco Guardiani created FLINK-26422:
---
Summary: Update Chinese documentation with the new TablePipeline
docs
Key: FLINK-26422
URL: https://issues.apache.org/jira/browse/FLINK-26422
Project
Hi all,
I'm +1 with what everything you said Marios.
I'm gonna add another argument on top of that: the "legacy-cast-behavior"
has also a broken type inference, leading to incorrect results or further
errors down in the pipeline[1]. For example, take this:
SELECT COALESCE(CAST('a' AS INT), 0) ...
Francesco Guardiani created FLINK-26280:
---
Summary: Add a flag to disable uid generation
Key: FLINK-26280
URL: https://issues.apache.org/jira/browse/FLINK-26280
Project: Flink
Issue
Francesco Guardiani created FLINK-26252:
---
Summary: Refactor MiniClusterExtension
Key: FLINK-26252
URL: https://issues.apache.org/jira/browse/FLINK-26252
Project: Flink
Issue Type: Bug
Francesco Guardiani created FLINK-26249:
---
Summary: Run BuiltInFunctionITCase tests in parallel
Key: FLINK-26249
URL: https://issues.apache.org/jira/browse/FLINK-26249
Project: Flink
> In the theory aspect, incremental data should be carefully considered for
streaming data. In this situation, the data flow from target_table to
target_table
will be a loop, and the incremental data with one key will keep going
through
the loop. It looks very strange.
This is the same concern I
Francesco Guardiani created FLINK-26131:
---
Summary: CompiledPlan should implement Executable
Key: FLINK-26131
URL: https://issues.apache.org/jira/browse/FLINK-26131
Project: Flink
Issue
Francesco Guardiani created FLINK-26128:
---
Summary: Improve Table, Expressions and related classes
Javadocs/Scaladocs
Key: FLINK-26128
URL: https://issues.apache.org/jira/browse/FLINK-26128
Francesco Guardiani created FLINK-26127:
---
Summary: Cleanup usage of deprecated table methods in doc
Key: FLINK-26127
URL: https://issues.apache.org/jira/browse/FLINK-26127
Project: Flink
Francesco Guardiani created FLINK-26125:
---
Summary: Doc overhaul for the CAST behaviour
Key: FLINK-26125
URL: https://issues.apache.org/jira/browse/FLINK-26125
Project: Flink
Issue Type
Francesco Guardiani created FLINK-26090:
---
Summary: Remove pre FLIP-84 methods
Key: FLINK-26090
URL: https://issues.apache.org/jira/browse/FLINK-26090
Project: Flink
Issue Type: Bug
Francesco Guardiani created FLINK-26089:
---
Summary: Introduce TablePipeline
Key: FLINK-26089
URL: https://issues.apache.org/jira/browse/FLINK-26089
Project: Flink
Issue Type: Sub-task
Francesco Guardiani created FLINK-26071:
---
Summary: TableEnvironment#compilePlan should fail
Key: FLINK-26071
URL: https://issues.apache.org/jira/browse/FLINK-26071
Project: Flink
Issue
Francesco Guardiani created FLINK-26060:
---
Summary: Make Python specific exec nodes unsupported
Key: FLINK-26060
URL: https://issues.apache.org/jira/browse/FLINK-26060
Project: Flink
Francesco Guardiani created FLINK-26054:
---
Summary: Enable maven-enforcer to disable table-planner and
table-runtime as dependencies
Key: FLINK-26054
URL: https://issues.apache.org/jira/browse/FLINK-26054
Francesco Guardiani created FLINK-26053:
---
Summary: Fix parser generator warnings
Key: FLINK-26053
URL: https://issues.apache.org/jira/browse/FLINK-26053
Project: Flink
Issue Type: Bug
Francesco Guardiani created FLINK-25986:
---
Summary: Add FLIP-190 new API methods to python
Key: FLINK-25986
URL: https://issues.apache.org/jira/browse/FLINK-25986
Project: Flink
Issue
Francesco Guardiani created FLINK-25942:
---
Summary: Use jackson jdk8/time modules for Duration ser/de
Key: FLINK-25942
URL: https://issues.apache.org/jira/browse/FLINK-25942
Project: Flink
Francesco Guardiani created FLINK-25918:
---
Summary: Use FileEnumerator to implement filter pushdown of
filepath metadata
Key: FLINK-25918
URL: https://issues.apache.org/jira/browse/FLINK-25918
I propose to remove it.
>>>
>>> Fully agree on the template part, what's good to know is that a
>>> connector template/archetype is part of the goals for the external
>>> connector repository.
>>>
>>> Best regards,
>>>
>>&g
Francesco Guardiani created FLINK-25897:
---
Summary: Update project configuration gradle doc to 7.x version
Key: FLINK-25897
URL: https://issues.apache.org/jira/browse/FLINK-25897
Project: Flink
Francesco Guardiani created FLINK-25895:
---
Summary: Add ExecNodeGraph ser/de
Key: FLINK-25895
URL: https://issues.apache.org/jira/browse/FLINK-25895
Project: Flink
Issue Type: Sub-task
Hi,
I agree with the concern about having this connector in the main repo. But
I think in general it doesn't harm to have a sample connector to show how
to develop a custom connector, and I think that the Twitter connector can
be a good candidate for such a template. It needs rework for sure, as i
Thanks Chesnay for this!
FG
On Mon, Jan 24, 2022 at 11:20 AM David Morávek wrote:
> That's a great news Chesnay, thanks for driving this! This should unblock
> some ongoing Flink efforts +1
>
> Best,
> D.
>
> On Mon, Jan 24, 2022 at 10:58 AM Chesnay Schepler
> wrote:
>
> > Hello everyone,
> >
Francesco Guardiani created FLINK-25809:
---
Summary: Introduce test infra for building FLIP-190 tests
Key: FLINK-25809
URL: https://issues.apache.org/jira/browse/FLINK-25809
Project: Flink
Francesco Guardiani created FLINK-25791:
---
Summary: Make ObjectIdentifier json representation simpler
Key: FLINK-25791
URL: https://issues.apache.org/jira/browse/FLINK-25791
Project: Flink
Francesco Guardiani created FLINK-25779:
---
Summary: Define ConfigOption for properties map in Kinesis
Key: FLINK-25779
URL: https://issues.apache.org/jira/browse/FLINK-25779
Project: Flink
Francesco Guardiani created FLINK-25778:
---
Summary: Define ConfigOption for properties map in Kafka
Key: FLINK-25778
URL: https://issues.apache.org/jira/browse/FLINK-25778
Project: Flink
Francesco Guardiani created FLINK-25777:
---
Summary: Generate documentation for Table factories (formats and
connectors)
Key: FLINK-25777
URL: https://issues.apache.org/jira/browse/FLINK-25777
Francesco Guardiani created FLINK-25588:
---
Summary: Add jdk8 and datetime module to jackson shaded
Key: FLINK-25588
URL: https://issues.apache.org/jira/browse/FLINK-25588
Project: Flink
+1 with a separate repo and +1 with the flink-storage name
On Fri, Jan 7, 2022 at 8:40 AM Jingsong Li wrote:
> Hi everyone,
>
> Vote for create a separate sub project for FLIP-188 thread is here:
> https://lists.apache.org/thread/wzzhr27cvrh6w107bn464m1m1ycfll1z
>
> Best,
> Jingsong
>
>
> On Fri
Francesco Guardiani created FLINK-25526:
---
Summary: Deprecate TableSinkFactory, TableSourceFactory and
TableFormatFactory
Key: FLINK-25526
URL: https://issues.apache.org/jira/browse/FLINK-25526
Francesco Guardiani created FLINK-25518:
---
Summary: Harden JSON Serialization utilities
Key: FLINK-25518
URL: https://issues.apache.org/jira/browse/FLINK-25518
Project: Flink
Issue Type
Hi Jing,
Thanks for the FLIP. I'm not very knowledgeable about the topic, but going
through both the FLIP and the discussion here, I wonder, does it makes
sense for a lookup join to use hash distribution whenever is possible by
default?
The point you're explaining here:
> Many Lookup table sourc
Francesco Guardiani created FLINK-25428:
---
Summary: Expose complex types CAST to String
Key: FLINK-25428
URL: https://issues.apache.org/jira/browse/FLINK-25428
Project: Flink
Issue Type
Francesco Guardiani created FLINK-25300:
---
Summary: Remove CEIL and FLOOR call with one argument for integral
values
Key: FLINK-25300
URL: https://issues.apache.org/jira/browse/FLINK-25300
Francesco Guardiani created FLINK-25299:
---
Summary: Improve LIKE operator efficiency
Key: FLINK-25299
URL: https://issues.apache.org/jira/browse/FLINK-25299
Project: Flink
Issue Type
Francesco Guardiani created FLINK-25282:
---
Summary: Move runtime dependencies from table-planner to
table-runtime
Key: FLINK-25282
URL: https://issues.apache.org/jira/browse/FLINK-25282
Project
t; SQL much, is there an agreed upon deprecation/removal plan for the legacy
> type system yet?
>
> Cheers,
>
> Konstantin
>
> On Wed, Dec 8, 2021 at 6:02 PM Francesco Guardiani <
> france...@ververica.com>
> wrote:
>
> > Hi all,
> > In case you haven
t; version. Typically use case are like
> >>>> a group of people managing some streaming platform, which will provide
> >>>> Flink as an execution engine
> >>>> to their users. Alibaba has more than 40K online streaming SQL jobs,
> and
>
Francesco Guardiani created FLINK-25229:
---
Summary: Introduce flink-table-api-bridge-common
Key: FLINK-25229
URL: https://issues.apache.org/jira/browse/FLINK-25229
Project: Flink
Issue
Francesco Guardiani created FLINK-25228:
---
Summary: Introduce flink-table-test-utils
Key: FLINK-25228
URL: https://issues.apache.org/jira/browse/FLINK-25228
Project: Flink
Issue Type
in by #17897 <https://github.com/apache/flink/pull/17897> to
flink-parquet and flink-orc.
Thanks,
FG
--
Francesco Guardiani | Software Engineer
france...@ververica.com
<https://www.ververica.com/>
Follow us @VervericaData
--
Join Flink Forward <https://flink-forward.org/>
Francesco Guardiani created FLINK-25158:
---
Summary: Fix formatting for true, false and null to uppercase
Key: FLINK-25158
URL: https://issues.apache.org/jira/browse/FLINK-25158
Project: Flink
Francesco Guardiani created FLINK-25156:
---
Summary: DISTINCT is not handled correctly by CastRules
Key: FLINK-25156
URL: https://issues.apache.org/jira/browse/FLINK-25156
Project: Flink
Francesco Guardiani created FLINK-25157:
---
Summary: Introduce NULL type to string cast rule
Key: FLINK-25157
URL: https://issues.apache.org/jira/browse/FLINK-25157
Project: Flink
Issue
Hi Till,
Thanks for starting this discussion, I think it's very beneficial for the
community to have stable APIs, in particular to develop connectors and
formats.
A couple of comments:
> I would suggest that we document these guarantees prominently under
/docs/dev/api_stability.
I think it woul
Congrats Ingo!
On Thu, Dec 2, 2021 at 4:58 PM Nicolaus Weidner <
nicolaus.weid...@ververica.com> wrote:
> Congrats Ingo!
> The PMC probably realized that it's simply too much work to review and
> merge all your PRs, so now you can/have to do part of that work yourself
> ;-)
>
> Best,
> Nico
>
> O
Congrats Matthias!
On Thu, Dec 2, 2021 at 4:53 PM Nicolaus Weidner <
nicolaus.weid...@ververica.com> wrote:
> Congrats Matthias, well deserved!
>
> Best,
> Nico
>
> On Thu, Dec 2, 2021 at 4:48 PM Fabian Paul wrote:
>
> > Congrats and well deserved.
> >
> > Best,
> > Fabian
> >
> > On Thu, Dec 2,
Francesco Guardiani created FLINK-25131:
---
Summary: Update sql client to ship flink-table-planner-loader
instead of flink-table-planner
Key: FLINK-25131
URL: https://issues.apache.org/jira/browse/FLINK-25131
Francesco Guardiani created FLINK-25130:
---
Summary: Update flink-table-uber to ship
flink-table-planner-loader instead of flink-table-planner
Key: FLINK-25130
URL: https://issues.apache.org/jira/browse/FLINK
Francesco Guardiani created FLINK-25129:
---
Summary: Update docs and examples to use
flink-table-planner-loader instead of flink-table-planner
Key: FLINK-25129
URL: https://issues.apache.org/jira/browse/FLINK
Francesco Guardiani created FLINK-25128:
---
Summary: Introduce flink-table-planner-loader
Key: FLINK-25128
URL: https://issues.apache.org/jira/browse/FLINK-25128
Project: Flink
Issue
Francesco Guardiani created FLINK-25114:
---
Summary: Remove flink-scala dependency from flink-table-runtime
Key: FLINK-25114
URL: https://issues.apache.org/jira/browse/FLINK-25114
Project: Flink
Francesco Guardiani created FLINK-25113:
---
Summary: Cleanup from Parquet and Orc the partition key handling
logic
Key: FLINK-25113
URL: https://issues.apache.org/jira/browse/FLINK-25113
Project
Francesco Guardiani created FLINK-25090:
---
Summary: Run the assertj conversion script to convert assertions
Key: FLINK-25090
URL: https://issues.apache.org/jira/browse/FLINK-25090
Project: Flink
Francesco Guardiani created FLINK-25079:
---
Summary: Add assertj assertions for table types
Key: FLINK-25079
URL: https://issues.apache.org/jira/browse/FLINK-25079
Project: Flink
Issue
Francesco Guardiani created FLINK-25075:
---
Summary: Remove reflection to instantiate PlannerExpressionParser
Key: FLINK-25075
URL: https://issues.apache.org/jira/browse/FLINK-25075
Project: Flink
ing,
ending up modifying the compiled plan. So I guess flink should write it back in
the original
plan file, perhaps doing a backup of the previous one? Can you please clarify
this aspect?
Except these considerations, the proposal looks good to me and I'm eagerly
waiting to see
it in p
Francesco Guardiani created FLINK-25061:
---
Summary: Add assertj as dependency in flink-parent
Key: FLINK-25061
URL: https://issues.apache.org/jira/browse/FLINK-25061
Project: Flink
Francesco Guardiani created FLINK-25060:
---
Summary: Replace DataType.projectFields with Projection type
Key: FLINK-25060
URL: https://issues.apache.org/jira/browse/FLINK-25060
Project: Flink
Francesco Guardiani created FLINK-25052:
---
Summary: Port row to row cast logic to CastRule
Key: FLINK-25052
URL: https://issues.apache.org/jira/browse/FLINK-25052
Project: Flink
Issue
Francesco Guardiani created FLINK-25051:
---
Summary: Port raw <-> binary logic to CastRule
Key: FLINK-25051
URL: https://issues.apache.org/jira/browse/FLINK-25051
Project: Flink
Francesco Guardiani wrote:
> Hi all,
>
> Given I see generally consensus around having a convention and using
> assertj, I propose to merge these 2 PRs:
>
> * Add the explanation of this convention in our code quality guide:
> https://github.com/apache/flink-web/pull/482
> * A
+1 with what both Ingo and Matthias sad, personally, I cannot wait to start
using some of
the APIs introduced in Java 9. And I'm pretty sure that's the same for our
users as well.
On Tuesday, 23 November 2021 13:35:07 CET Ingo Bürk wrote:
> Hi everyone,
>
> continued support for Java 8 can als
n.
>> >
>> > Best,
>> > D.
>> >
>> > On Tue, Nov 16, 2021 at 9:37 AM Till Rohrmann
>> > wrote:
>> >
>> > > Using JUnit5 with assertJ is fine with me if the community agrees.
>> Having
>> > > guides for best p
t; to cast "abc"
> to an integer, which means we don't know the correct value.
>
> But still, I'm ok to change the behavior, but just not now. It will really
> create a big mess after
> users upgrade their SQL jobs. I'm either fine to do it in some really big
>
Hi all,
tl;dr:
I think Timo pretty much said it all. As described in the issue, my
proposal is:
* Let's switch the default behavior of CAST to fail
* Let's add TRY_CAST to have the old behavior
* Let's add a rule (disabled by default) that wraps every CAST in a TRY, in
order to keep the old beha
Francesco Guardiani created FLINK-24924:
---
Summary: TO_TIMESTAMP and TO_DATE should fail
Key: FLINK-24924
URL: https://issues.apache.org/jira/browse/FLINK-24924
Project: Flink
Issue
+1 with Ingo proposal, the goal of the template should be to help developer
to do a self check of his/her PR quality, not to define whether something
is done or not. It's up to the committer to check that the "definition of
done" is fulfilled.
> The Definition of Done as suggested:
This checklist
at it's worth, I recently rewrote all of the tests in
> flink-training
> >> to use assertj, removing a mixture of junit4 assertions and hamcrest in
> >> the
> >> process. I chose assertj because I found it to be more expressive and
> made
> >> the tests mo
1 - 100 of 141 matches
Mail list logo