Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-25 Thread Junrui Lee
+1 Best, Junrui weijie guo 于2023年7月24日周一 10:25写道: > +1 for this. > > Best regards, > > Weijie > > > liu ron 于2023年7月24日周一 09:58写道: > > > +1 > > > > Best, > > Ron > > > > Yuxin Tan 于2023年7月21日周五 16:21写道: > > > > > +1 > > > > > > Best, > > > Yuxin > > > > > > > > > Jing Ge 于2023年7月21日周五

Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-23 Thread weijie guo
+1 for this. Best regards, Weijie liu ron 于2023年7月24日周一 09:58写道: > +1 > > Best, > Ron > > Yuxin Tan 于2023年7月21日周五 16:21写道: > > > +1 > > > > Best, > > Yuxin > > > > > > Jing Ge 于2023年7月21日周五 15:41写道: > > > > > +1 > > > > > > NIT: the release in the FLIP is still empty, it should be 2.0 > >

Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-23 Thread liu ron
+1 Best, Ron Yuxin Tan 于2023年7月21日周五 16:21写道: > +1 > > Best, > Yuxin > > > Jing Ge 于2023年7月21日周五 15:41写道: > > > +1 > > > > NIT: the release in the FLIP is still empty, it should be 2.0 > > > > Best regards, > > Jing > > > > On Fri, Jul 21, 2023 at 6:03 AM Xintong Song > > wrote: > > > > > +1

Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-21 Thread Yuxin Tan
+1 Best, Yuxin Jing Ge 于2023年7月21日周五 15:41写道: > +1 > > NIT: the release in the FLIP is still empty, it should be 2.0 > > Best regards, > Jing > > On Fri, Jul 21, 2023 at 6:03 AM Xintong Song > wrote: > > > +1 > > > > Best, > > > > Xintong > > > > > > > > On Fri, Jul 21, 2023 at 10:53 AM

Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-21 Thread Jing Ge
+1 NIT: the release in the FLIP is still empty, it should be 2.0 Best regards, Jing On Fri, Jul 21, 2023 at 6:03 AM Xintong Song wrote: > +1 > > Best, > > Xintong > > > > On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu wrote: > > > Hi devs, > > > > I would like to start a discussion on

Re: [DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-20 Thread Xintong Song
+1 Best, Xintong On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu wrote: > Hi devs, > > I would like to start a discussion on FLIP-343: Remove parameter in > WindowAssigner#getDefaultTrigger() [1]. > > > The method getDefaultTrigger() in WindowAssigner takes a > StreamExecutionEnvironment >

[DISCUSS][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-20 Thread Wencong Liu
Hi devs, I would like to start a discussion on FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger() [1]. The method getDefaultTrigger() in WindowAssigner takes a StreamExecutionEnvironment parameter, but this parameter is not actually used for any subclasses of WindowAssigner.