> I took a quick skim on the PRs and I noticed that only a few of them are
actually in mergeable shapes (i.e., properly rebased and passing CI).
Although TravisCI is quite unstable, Flink executes multiple tests with
different configurations so you'll want to instead look at which tests are
passin
Hi, all
Thanks to the reviewers’ hard working.
When a new issue or pull request, the issue provider hope can be reviewed
quickly. So we usually “@somebody”, it’s only a request for quick review.
Maybe we can identify whether this issue is indeed necessary or its obvious
problem, so as to decide
+1. Nice to be pinged if required, but relying on specific people to review
simply does not scale.
Popping up one level, occasionally the fact that people tag other people is
because the PRs are left unreviewed for a while (or they believe the PRs
will not be reviewed unless they explicitly ping o
I agree with Aljoscha that tagging the PRs helps me to get notified about
PRs where I could be of help. But I also think that it should not be the
ultimate responsibility of the tagged person(s) to review the code.
Everyone should feel empowered to do so. And also the tagging does not free
oneself
I was wondering how this relates to the shepherding of PRs we have
discussed in the past. If I make a PR for an issue reported from a specific
committer, doesn't tagging them make sense?
Has the shepherding of PRs been tried out?
On Tue, Jan 24, 2017 at 12:17 PM, Aljoscha Krettek
wrote:
> It se
It seems I'm in a bit of a minority here but I like the @R tags. There are
simply to many pull request for someone to keep track of all of them and if
someone things that a certain person would be good for reviewing a change
then tagging them helps them notice the PR.
I think the tag should not me
Hi Haohui,
reviewing pull requests is a great way of contributing to the community!
I am not aware of specific instructions for the review process. The are
some dos and don'ts on our "contribute code" page [1] that should be
considered. Apart from that, I think the best way to start is to become
I totally agree with all of your ideas.
Best wishes，
SunJincheng.
Stephan Ewen 于2017年1月16日 周一19:42写道：
> Hi!
>
>
>
> I have seen that recently many pull requests designate reviews by writing
>
> "@personA review please" or so.
>
>
>
> I am personally quite strongly against that, I thi
uce obviously outdated ones and add them
> > to a cleanup list https://issues.apache.org/jira/browse/FLINK-5384
> >
> >
> > -Original Message-
> > From: Alexey Demin [mailto:diomi...@gmail.com]
> > Sent: Monday, January 16, 2017 5:05 PM
> > T
/jira/browse/FLINK-5384
>
>
> -Original Message-
> From: Alexey Demin [mailto:diomi...@gmail.com]
> Sent: Monday, January 16, 2017 5:05 PM
> To: dev@flink.apache.org
> Subject: Re: [DISCUSS] (Not) tagging reviewers
>
> Hi all
>
> View from my prospective:
Subject: Re: [DISCUSS] (Not) tagging reviewers
Hi all
View from my prospective:
in middle of summer - 150 PR
in middle of autumn - 180
now 206.
This is mix of bugfixes and improvements.
I understand that work on new features important, but when small and trivial
fixes stay in states of PR more
Thanks for the comments.
@Paris - Ufuk has it right, tagging as a reminder (or just because it helps
with referring to the comment from a specific reviewer) makes total sense
to me, I would keep doing that.
On Mon, Jan 16, 2017 at 1:36 PM, Ufuk Celebi wrote:
> On 16 January 2017 at 12:59:04, P
Hi all
View from my prospective:
in middle of summer - 150 PR
in middle of autumn - 180
now 206.
This is mix of bugfixes and improvements.
I understand that work on new features important, but when small and
trivial fixes stay in states of PR more then 2-3 month,
then all users think about changi
On 16 January 2017 at 12:59:04, Paris Carbone (par...@kth.se) wrote:
> > Though, when someone has started reviewing a PR and shows interest
> it probably makes sense to finish doing so. Wouldn’t tagging
> be acceptable there?
> In those case tagging triggers direct notifications, so that
> pe
I also agree with all the points, especially when it comes to new PRs.
Though, when someone has started reviewing a PR and shows interest it probably
makes sense to finish doing so. Wouldn’t tagging be acceptable there?
In those case tagging triggers direct notifications, so that people already
Thanks for bringing this up Stephan.
I completely agree with you.
Cheers, Fabian
2017-01-16 12:42 GMT+01:00 Stephan Ewen :
> Hi!
>
> I have seen that recently many pull requests designate reviews by writing
> "@personA review please" or so.
>
> I am personally quite strongly against that, I thin
Hi!
I have seen that recently many pull requests designate reviews by writing
"@personA review please" or so.
I am personally quite strongly against that, I think it hurts the community
work:
- The same few people get usually "designated" and will typically get
overloaded and often not do the
17 matches
Mail list logo
