[DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-26 Thread Gary Yao
Hi community, In the past releases, we have been working on refactoring Flink's scheduler with the goal of making the scheduler extensible [1]. We have rolled out most of the intended refactoring in Flink 1.10, and we think it is now time to leverage our newly introduced abstractions to implement

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-26 Thread Yangze Guo
Thanks for driving this discussion, Zhu Zhu & Gary. I found that the image link in this FLIP is not working well. When I open that link, Google doc told me that I have no access privilege. Could you take a look at that issue? Best, Yangze Guo On Fri, Mar 27, 2020 at 1:38 AM Gary Yao wrote: > >

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-26 Thread Zhu Zhu
Thanks for reporting this Yangze. I have update the permission to those images. Everyone are able to view them now. Thanks, Zhu Zhu Yangze Guo 于2020年3月27日周五 上午11:25写道: > Thanks for driving this discussion, Zhu Zhu & Gary. > > I found that the image link in this FLIP is not working well. When I

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-27 Thread Yangze Guo
Thanks for updating! +1 for supporting the pipelined region scheduling. Although we could not prevent resource deadlock in all scenarios, it is really a big step. The design generally LGTM. One minor thing I want to make sure. If I understand correctly, the blocking edge will not be consumable b

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-27 Thread Zhu Zhu
To Yangze, >> the blocking edge will not be consumable before the upstream is finished. Yes. This is how we define a BLOCKING result partition, "Blocking partitions represent blocking data exchanges, where the data stream is first fully produced and then consumed". >> I'm also wondering could we

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-27 Thread Xintong Song
Gary & Zhu Zhu, Thanks for preparing this FLIP, and a BIG +1 from my side. The trade-off between resource utilization and potential deadlock problems has always been a pain. Despite not solving all the deadlock cases, this FLIP is definitely a big improvement. IIUC, it has already covered all the

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-27 Thread Till Rohrmann
Thanks for creating this FLIP Zhu Zhu and Gary! +1 for adding pipelined region scheduling. Concerning the extended SlotProvider interface I have an idea how we could further improve it. If I am not mistaken, then you have proposed to introduce the two timeouts in order to distinguish between batc

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-29 Thread Zhu Zhu
Thanks for the comments! To Xintong, It's a bit strange since the in page links work as expected. Would you take another try? To Till, - Regarding the idea to improve to SlotProvider interface I think it is a good idea and thanks a lot! In the current design we make slot requests for batch jobs t

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-29 Thread Yangze Guo
Hi, Zhu Zhu, Thanks for the explanation and information. I also agree that it out of the scope of this FLIP and glad to see that we are moving forward to a more extensible scheduler! Best, Yangze Guo On Mon, Mar 30, 2020 at 1:31 AM Zhu Zhu wrote: > > Thanks for the comments! > > To Xintong, > I

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-29 Thread Xintong Song
@ZhuZhu The links work for me now. Someone might have fixed them. Never mind. Thank you~ Xintong Song On Mon, Mar 30, 2020 at 1:31 AM Zhu Zhu wrote: > Thanks for the comments! > > To Xintong, > It's a bit strange since the in page links work as expected. Would you take > another try? > > To

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-30 Thread Gary Yao
> > The links work for me now. Someone might have fixed them. Never mind. > Actually, I fixed the links after seeing your email. Thanks for reporting. Best, Gary On Mon, Mar 30, 2020 at 3:48 AM Xintong Song wrote: > @ZhuZhu > > The links work for me now. Someone might have fixed them. Never mi

Re: [DISCUSS] FLIP-119: Pipelined Region Scheduling

2020-03-30 Thread Zhu Zhu
Thanks for the nice suggestion Till. The section 'Bulk Slot Allocation' is updated. Thanks, Zhu Zhu Gary Yao 于2020年3月30日周一 下午3:38写道: > > > > The links work for me now. Someone might have fixed them. Never mind. > > > > Actually, I fixed the links after seeing your email. Thanks for reporting. >