Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-10-24 Thread Matthias Pohl
Hi Gyula, thanks for joining the discussion. Yeah, I might have gone a bit too far with it. I guess I was eager to create separate implementations to make use of the two different interfaces/purposes on a class level to allow more purpose-centric testing. I am fine with cutting it back and having

Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-10-23 Thread Gyula Fóra
I am a bit confused by the split in the CompletedJobStore / JobDetailsStore. Seems like JobDetailsStore is simply a view on top of CompletedJobStore: - Maybe we should not call it a store? Is it storing anything? - Why couldn't the cleanup triggering be the responsibility of the

Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-09-29 Thread Matthias Pohl
Thanks for sharing your thoughts, Shammon FY. I kind of see your point. Initially, I didn't put much thought into splitting up the interface into two because the dispatcher would have been the only component dealing with the two interfaces. Having two interfaces wouldn't have added much value (in

Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-09-17 Thread Shammon FY
Hi Matthias, Thanks for initiating this discussion, and +1 for overall from my side. It's really strange to have two different places to store completed jobs, this also brings about the complexity of Flink. I agree with using a unified instance to store the completed job information. In terms of

Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-09-08 Thread Gyula Fóra
Hi Matthias! Thank you for the detailed proposal, overall I am in favor of making this unification to simplify the logic and make the integration for external components more straightforward. I will try to read through the proposal more carefully next week and provide some detailed feedback. +1

Re: [DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-09-08 Thread Matthias Pohl
Just a bit more elaboration on the question that we need to answer here: Do we want to expose the internal ArchivedExecutionGraph data structure through JSON? - The JSON approach allows the user to have (almost) full access to the information (that would be otherwise derived from the REST API).

[DISCUSS] FLIP-360: Merging ExecutionGraphInfoStore and JobResultStore into a single component

2023-09-04 Thread Matthias Pohl
Hi everyone, I want to open the discussion on FLIP-360 [1]. The goal of this FLIP is to combine the two very similar components ExecutionGraphInfoStore and JobResultStore into a single component. The benefit of this effort would be to expose the metadata of a globally-terminated job even in cases