Hi devs,
I would like to start a discussion on FLIP-381: Deprecate configuration
getters/setters that return/set complex Java objects[1].
Currently, the job configuration in FLINK is spread out across different
components, which leads to inconsistencies and confusion. To address this
issue, it is
Thanks Junrui for driving this proposal!
ConfigOption is easy to use for flink users, easy to manage options
for flink platform maintainers, and easy to maintain for flink developers
and flink community.
So big +1 for this proposal!
Best,
Rui
On Thu, Nov 2, 2023 at 10:10 AM Junrui Lee wrote:
Thanks Junrui for creating the FLIP and kicking off this discussion.
The community has been constantly striving to unify and simplify the
configuration layer of Flink. Some progress has already been made,
such as FLINK-29379. However, the compatibility of public interfaces
poses an obstacle to com
Thanks Junrui for driving this proposal!
I believe this is helpful for the new Process Function API. Because we
don't need to move some related class/components from flink-core to a pure
API module (maybe, called flink-core-api) after this. Even though the FLIP
related to new API is in preparation
Thanks Junrui for driving this.
Making configurations simple and consistent has great benefits for both
users and devs. +1 for the proposal.
Best,
Lijie
weijie guo 于2023年11月2日周四 16:49写道：
> Thanks Junrui for driving this proposal!
>
> I believe this is helpful for the new Process Function API.
Thanks Junrui for driving the proposal.
+1 for this proposal. I believe this change will enhance the usability of
Flink configuration for both users and developers, while also ensuring
consistency across various types of configurations.
Best,
Yuxin
Lijie Wang 于2023年11月3日周五 10:59写道：
> Thanks J
Thanks Junrui for driving the proposal.
+1 from my side. This FLIP will help to make the configuration clearer for
users.
ps: We should also delete the private field `storage` as its getter and
setter are deleted and it is marked as `@Deprecated`. This is not written
in the FLIP.
Best,
Hang
Yux
Hi Hang,
Thank you for your feedback. Regarding your suggestion to delete the
private field 'storage', I want to clarify that in this FLIP, we are only
deprecating the getter and setter methods for CheckpointConfig#storage.
Therefore, we cannot directly remove the 'storage' field at this moment.
H
Thanks Junrui for your effort!
Making all configuration code paths lead to ConfigOption is a more standardized
approach to configuring Flink applications.
+1 for this proposal.
Best,
Wencong Liu
At 2023-11-02 10:10:14, "Junrui Lee" wrote:
>Hi devs,
>
>I would like to start a disc
Hi Junrui,
Thanks for bringing the proposal to our attention. It looks overall great.
I am just a little bit confused with the content of Flip with the following
questions:
1. How many complex java classes will be deprecated?
2. After reading the section title "Deprecate following classes, field
Hi Jing,
Thank you for your feedback on the proposal. I appreciate your input and
understand your concerns.
Regarding your questions, the complex Java class that will be deprecated is
org.apache.flink.api.common.restartstrategy.RestartStrategies and and its
internal classes, which include:
- Res
Hi Junrui,
Thanks for updating the FLIP! It looks good and clear now. Appreciate it!
Best regards,
Jing
On Sun, Nov 5, 2023 at 7:35 PM Junrui Lee wrote:
> Hi Jing,
>
> Thank you for your feedback on the proposal. I appreciate your input and
> understand your concerns.
>
> Regarding your questi
12 matches
Mail list logo
