[DISCUSS] FLIP-84: Improve & Refactor API of Table Module

2019-10-30 Thread Terry Wang
Hi everyone, TableEnvironment has provided two `Table sqlQuery(String sql)` and `void sqlUpdate(String sql)` interfaces to create a table(actually a view here) or describe an update action from one sql string. But with more use cases come up, there are some fatal shortcomings in current API de

Re: [DISCUSS] FLIP-84: Improve & Refactor API of Table Module

2019-10-30 Thread Kurt Young
Thanks Terry for bringing this up. TableEnv's interface is really critical not only to users, but also for components built upon it like SQL CLI. Your proposal solved some pain points we currently have, so +1 to the proposal. I left some comments in the document. Best, Kurt On Thu, Oct 31, 2019

Re: [DISCUSS] FLIP-84: Improve & Refactor API of Table Module

2019-11-04 Thread Kurt Young
cc @Fabian here, thought you might be interesting to review this. Best, Kurt On Thu, Oct 31, 2019 at 1:39 PM Kurt Young wrote: > Thanks Terry for bringing this up. TableEnv's interface is really critical > not only > to users, but also for components built upon it like SQL CLI. Your > proposal

Re: [DISCUSS] FLIP-84: Improve & Refactor API of Table Module

2019-11-05 Thread Jark Wu
Hi Terry, I would suggest to change the title a bit. For example, "Improve & Refactor TableEnvironment APIs". Or more specifically, "Improve & Refactor TableEnvironment execute/sqlQuery/sqlUpdate.. APIs" Currently, the title is a little wide (there are so many APIs in table module) . Make the tit