Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Gabor Somogyi
Now I see the difference. All in all the main reason of this discussion is that I've found many super old Hadoop workarounds/unused configs/not working solutions. I think it would be beneficial for the community to remove/fix them somehow. There are 4-7 years old issues inside... This is a good ex

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Gyula Fóra
In any case these configs are related to supporting some very very old Hadoop versions. Which are likely broken anyways. I think we can also vote on removing support for some of these keys together with discussing (and voting on) the minimum supported hadoop version. In other words I think we shou

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Gyula Fóra
Chesnay, I think as Gabor said, we have removed modules and functionality in the past which basically made some old configuration keys useless (effectively removed). In this particular case we don't need to remove the static constants that store this config key, we can simply ignore them. This wou

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Chesnay Schepler
d) The japicmp plugin is about programmatic API compatibility, which doesn't cover Mesos support. On 16/06/2022 12:59, Gabor Somogyi wrote: OK, I see your point. Just a question here. Mesos is deprecated in 1.13 here: https://issues.apache.org/jira/browse/FLINK-22352 and now I don't see any Me

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Chesnay Schepler
a) Nothing in there was @Public afaict b) even if a) weren't the case, we voted on it c) there was an appreciable benefit in dropping Mesos, since it paved the way for Scala-free Flink On 16/06/2022 12:59, Gabor Somogyi wrote: OK, I see your point. Just a question here. Mesos is deprecated in

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Gabor Somogyi
OK, I see your point. Just a question here. Mesos is deprecated in 1.13 here: https://issues.apache.org/jira/browse/FLINK-22352 and now I don't see any Mesos related classes in 1.16-SNAPSHOT. No matter from which angle I take a look at it this is breaking change. What makes the 2 cases different?

Re: [DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Chesnay Schepler
The japicm-plugin did exactly what it was supposed to be doing. We can't remove these fields because they are part of a @Public class and hence have to remain until Flink 2.0. Adding an exclusion for @Deprecated is a bad idea because it makes it way to easy to break the API. On 16/06/2022 1

[DISCUSS] How to delete deprecated configs/functions

2022-06-16 Thread Gabor Somogyi
Hi All, I've just tried to delete long time deprecated configs and faced some inconveniences. My main intention is to understand what was the idea when japicmp-maven-plugin introduced related configs/functions marked with @Deprecated annotation. When I've removed the mentioned configs from source