Re: [DISCUSS] Introducing Builder in FlinkKafkaProducer

2019-03-04 Thread Piotr Nowojski
Definitely we could go one step further. Having one common way to initialise connectors (I think this definitely would need a Builder pattern) might be even better, but it’s also much larger change with more things that need to be considered. Like what about type safety of configuration

Re: [DISCUSS] Introducing Builder in FlinkKafkaProducer

2019-03-04 Thread Aljoscha Krettek
I think before doing anything quick here we should look at this more holistically: How do the different connectors work, i.e. how do you construct them? Can we find a way to unify that, maybe using a Builder pattern? And then should we make a plan of getting the connectors there, possibly with

Re: [DISCUSS] Introducing Builder in FlinkKafkaProducer

2019-03-04 Thread Piotr Nowojski
Hi, This would definitely be beneficial. And yes, we would have to keep the current constructors for at least one release marked as @Deprecated. Piotrek > On 4 Mar 2019, at 08:49, Александр wrote: > > Hi, devs. I recently joined the community and I'm trying to understand the > project module

[DISCUSS] Introducing Builder in FlinkKafkaProducer

2019-03-03 Thread Александр
Hi, devs. I recently joined the community and I'm trying to understand the project module by module. I've noticed that in FlinkKafkaProducer (