Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-15 Thread Till Rohrmann
I'd be fine with these changes. Thanks for the summary Xintong. Cheers, Till On Wed, Jan 15, 2020 at 11:09 AM Xintong Song wrote: > Thank you all for the well discussion. > > If there's no further concerns or objections, I would like to conclude this > thread into the following action items. >

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-15 Thread Xintong Song
Thank you all for the well discussion. If there's no further concerns or objections, I would like to conclude this thread into the following action items. - Change default value of "taskmanager.memory.jvm-overhead.min" to 192MB. - Change default value of "taskmanager.memory.jvm-metaspace.si

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-15 Thread Xintong Song
There's more idea from offline discussion with Andrey. If we decide to make metaspace 96MB, we can also make process.size 1568MB (1.5G + 32MB). According to the spreadsheet , 1.5GB process size and 64MB

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Xintong Song
Thanks for the discussion, Stephan, Till and Andrey. +1 for the managed fraction (0.4) and process.size (1.5G). *JVM overhead min 196 -> 192Mb (128 + 64)* > small correction for better power 2 alignment of sizes > Sorry, this was a typo (and the same for the jira comment which is copy-pasted). It

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Andrey Zagrebin
Hi all, Stephan, Till and me had another offline discussion today. Here is the outcome of our brainstorm. *managed fraction 0.4* just confirmed what we already discussed here. *process.size = 1536Mb (1,5Gb)* We agreed to have process.size in the default settings with the explanation of flink.siz

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Stephan Ewen
I like the idea of having a larger default "flink.size" in the config.yaml. Maybe we don't need to double it, but something like 1280m would be okay? On Tue, Jan 14, 2020 at 3:47 PM Andrey Zagrebin wrote: > Hi all! > > Great that we have already tried out new FLIP-49 with the bigger jobs. > > I

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Andrey Zagrebin
Hi all! Great that we have already tried out new FLIP-49 with the bigger jobs. I am also +1 for the JVM metaspace and overhead changes. Regarding 0.3 vs 0.4 for managed memory, +1 for having more managed memory for Rocksdb limiting case. In general, this looks mostly to be about memory distribu

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Till Rohrmann
+1 for the JVM metaspace and overhead changes. On Tue, Jan 14, 2020 at 11:19 AM Till Rohrmann wrote: > I guess one of the most important results of this experiment is to have a > good tuning guide available for users who are past the initial try-out > phase because the default settings will be k

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-14 Thread Till Rohrmann
I guess one of the most important results of this experiment is to have a good tuning guide available for users who are past the initial try-out phase because the default settings will be kind of a compromise. I assume that this is part of the outstanding FLIP-49 documentation task. If we limit Ro

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-13 Thread Xintong Song
Thanks for the feedback, Stephan and Kurt. @Stephan Regarding managed memory fraction, - It makes sense to keep the default value 0.4, if we assume rocksdb memory is limited by default. - AFAIK, currently rocksdb by default does not limit its memory usage. And I'm positive to change it. - Persona

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-13 Thread Kurt Young
HI Xingtong, IIRC during our tpc-ds 10T benchmark, we have suffered by JM's metaspace size and full gc which caused by lots of classloadings of source input split. Could you check whether changing the default value from 128MB to 64MB will make it worse? Correct me if I misunderstood anything, als

Re: [Discuss] Tuning FLIP-49 configuration default values.

2020-01-13 Thread Stephan Ewen
Hi all! Thanks a lot, Xintong, for this thorough analysis. Based on your analysis, here are some thoughts: +1 to change default JVM metaspace size from 128MB to 64MB +1 to change default JVM overhead min size from 128MB to 196MB Concerning the managed memory fraction, I am not sure I would chang

[Discuss] Tuning FLIP-49 configuration default values.

2020-01-09 Thread Xintong Song
Hi all, As described in FLINK-15145 [1], we decided to tune the default configuration values of FLIP-49 with more jobs and cases. After spending time analyzing and tuning the configurations, I've come with several findings. To be brief, I would suggest the following changes, and for more details