[Proposal] Code Reviewer List

2018-06-08 Thread Yaz Sh
Hi Flink Community, I am working with Flink for last couple of months and still learning it. Recently, I have started as a contributor in Flink to perform some minor changes and I am very excited to start working on bigger tasks. Questions I always have in mind, when I make a PR, are “Who shoul

Re: [Proposal] Code Reviewer List

2018-06-09 Thread Chesnay Schepler
Hello, These kind of lists are imo misguided as they setup false expectations. They imply that "If I ping person X at time Y I will get a fast review", which is just not true. Thus, allow me to answer your questions: “Who should I tag in my PR for code review?” You shouldn't tag anyone in PR

Re: [Proposal] Code Reviewer List

2018-06-09 Thread Fabian Hueske
Hi Yazdan, First of all, thank you for contributing to Flink! As Chesnay said, many of the Flink committers try to review pull requests in a timely manner. However, everybody has to put time aside to review a PR. Many committers are either working on features themselves or review PRs in their fre