The bot now warns if a pull request has been linked to an unassigned Jira
ticket. (It also puts a warning if no docs, no zh-docs have been touched,
or if a pom.xml file has been touched)
On Mon, Apr 15, 2019 at 3:11 PM Robert Metzger wrote:
> I will add such a feature to the bot!
>
> On Mon,
I will add such a feature to the bot!
On Mon, Mar 25, 2019 at 7:41 PM Stephan Ewen wrote:
> +1 to an enhancement to the Flink bot as a simple first step.
>
> The first step could be as simple as adding a red warning message as a
> comment to the PR whenever a PR touches a POM file.
> That needs
+1 to an enhancement to the Flink bot as a simple first step.
The first step could be as simple as adding a red warning message as a
comment to the PR whenever a PR touches a POM file.
That needs special attention for various reasons, including (but not only)
license checks and file updates.
On
Hi Aljoscha,
Thanks for bringing this up. The release-1.8 we have been prepared 4 times
RC, and in addition to one performance issue, all of the rest are NOTICE
issues. We really need to pay attention on this.
I agree with Ufuk, improve the `flink-bot` is a good idea. And the
committer who merge
Hi Aljoscha,
Thanks for bringing this up. The release-1.8 we have been prepared 4 times
RC, and in addition to one performance issue, all of the rest are NOTICE
issues. We really need to pay attention on this.
I think improve the `flink-bot
Bowen Li 于2019年3月24日周日 下午2:04写道：
> Hi,
>
> I agree
Hi,
I agree with Ufuk that we can start with something simple, achievable, yet
effective, like using flink-bot. The wiki that explains licensing of Flink
is very good but hard to be found and noticed by new contributors, do we
have plan to move it to a more discoverable place like
There are definitely license checking tools around that can generate
NOTICE files etc. I don't have the details, but Robert should have
some input here. I don't know whether they would fit our setup and how
we would integrate them or whether INFRA can get them for is.
Note that simple things can
Realistically you can't automatically infer from changes to any pom
/whether /and /what /we have to change in the notice files.
Doing this on the XML level requires a view over the entire project to
detect dependency changes in parent modules / dependency management and
packaging changes in
That sounds good! Are there any tools for this, though?
> On 19. Mar 2019, at 07:15, Ufuk Celebi wrote:
>
> Hey Aljoscha,
>
> thanks for bringing this up. I think that we should either integrate
> checks for this into our CI/CD environment (using existing tools) or
> add a conditional check
Hey Aljoscha,
thanks for bringing this up. I think that we should either integrate
checks for this into our CI/CD environment (using existing tools) or
add a conditional check for this into flink-bot in case a pom.xml was
modified. Otherwise it will be easy to forget in the future.
– Ufuk
On
Hi All,
Please remember to add newly added dependencies to the NOTICE file of
flink-dist (which will then end up in NOTICE-binary and so on). Discovering
this late will cause delays in releases, as it is doing now.
There is a handy guide that Chesnay and Till worked on that explains licensing
11 matches
Mail list logo
