[SURVEY] Dropping non Credit-based Flow Control

2019-10-02 Thread Piotr Nowojski
Hi, In Flink 1.5 we have introduced Credit-based Flow Control [1] in the network stack. Back then we were aware about potential downsides of it [2] and we decided to keep the old model in the code base ( configurable by setting `taskmanager.network.credit-model: false` ). Now, that we are abou

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-09 Thread zhijiang
Nowojski Send Time:2019年10月2日(星期三) 17:01 To:dev Subject:[SURVEY] Dropping non Credit-based Flow Control Hi, In Flink 1.5 we have introduced Credit-based Flow Control [1] in the network stack. Back then we were aware about potential downsides of it [2] and we decided to keep the old model in the code

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-10 Thread Biao Liu
t; It can reduce much overhead of maintaining non credit-based code path, so > +1 from my side to drop it. > > Best, > Zhijiang > -- > From:Piotr Nowojski > Send Time:2019年10月2日(星期三) 17:01 > To:dev > Subj

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-19 Thread Zhu Zhu
t; > > Best, > > Zhijiang > > ------------------ > > From:Piotr Nowojski > > Send Time:2019年10月2日(星期三) 17:01 > > To:dev > > Subject:[SURVEY] Dropping non Credit-based Flow Control > > > > Hi, >

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-20 Thread SHI Xiaogang
oducts. > > > It can reduce much overhead of maintaining non credit-based code path, > so > > > +1 from my side to drop it. > > > > > > Best, > > > Zhijiang > > > -- > >

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-23 Thread Nico Kruber
s the proper time to do it motivated >> by >>>> [3]. >>>> The credit-based mode is as default from Flink 1.5 and it has been >>>> verified to be stable and reliable in many versions. In Alibaba we are >>>> always using the default credit-based mod

Re: [SURVEY] Dropping non Credit-based Flow Control

2019-10-24 Thread Piotr Nowojski
proper time to do it motivated >>> by >>>>> [3]. >>>>> The credit-based mode is as default from Flink 1.5 and it has been >>>>> verified to be stable and reliable in many versions. In Alibaba we are >>>>> always using the default credit-ba