[RESULT] [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Tzu-Li (Gordon) Tai
I'm happy to announce that we have unanimously approved this release. There are 10 approving votes, 4 of which are binding: * Qingsheng Ren (binding) * Martijn Visser (binding) * Xianxun Ye * Mystic Lama * Leonard Xu (binding) * Ahmed Hamdy * Samrat Deb * Tzu-Li (Gordon) Tai (binding) * Sergey Nuy

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Tzu-Li (Gordon) Tai
Thanks for the catch on the docs and fixing it, Xianxun and Mason! On Mon, Oct 30, 2023 at 12:36 PM Mason Chen wrote: > I submitted PR to fix it since I was looking at the Kafka code already: > https://github.com/apache/flink-connector-kafka/pull/63 > > On Mon, Oct 30, 2023 at 12:19 PM Mason Che

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Mason Chen
I submitted PR to fix it since I was looking at the Kafka code already: https://github.com/apache/flink-connector-kafka/pull/63 On Mon, Oct 30, 2023 at 12:19 PM Mason Chen wrote: > +1 (non-binding) > > * Verified hashes and signatures > * Verified no binaries > * Verified poms point to 3.0.1 > *

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Mason Chen
+1 (non-binding) * Verified hashes and signatures * Verified no binaries * Verified poms point to 3.0.1 * Reviewed web PR * Built from source * Verified git tag @Xianxun, good catch. The datastream docs should be automatically updated via the doc shortcode. However, it seems that the sql connecto

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Sergey Nuyanzin
+1 (non-binding) * Verified hashes and checksums * Built from source * Checked release tag * Reviewed the web PR On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai wrote: > +1 (binding) > > - Hashes and checksums > - Build succeeds against 1.18.0: mvn clean install -Dflink.version=1.18.0 > - Ve

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Tzu-Li (Gordon) Tai
+1 (binding) - Hashes and checksums - Build succeeds against 1.18.0: mvn clean install -Dflink.version=1.18.0 - Verified that memory leak issue is fixed for idle topics. Tested against Flink 1.18.0 cluster. Thanks, Gordon On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb wrote: > +1 (non-binding) >

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Samrat Deb
+1 (non-binding) - Verified signatures - Verified Checksum - Build with Java 8 /11 - build success - Started MSK cluster and EMR cluster with flink, successfully ran some examples to read and write data to MSK. - Checked release tag exists Bests, Samrat On Mon, Oct 30, 2023 at 3:47 PM Ahmed Ham

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-30 Thread Ahmed Hamdy
+1 (non-binding) - Verified Singatures - Verified Checksum - Build source successfully - Checked release tag exists - Reviewed the web PR Best Regards Ahmed Hamdy On Sun, 29 Oct 2023 at 08:02, Leonard Xu wrote: > +1 (binding) > > - Verified signatures > - Verified hashsums > - Checked Github re

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-29 Thread Leonard Xu
+1 (binding) - Verified signatures - Verified hashsums - Checked Github release tag - Built from source code succeeded - Checked release notes - Reviewed the web PR Best, Leonard > 2023年10月29日 上午11:34，mystic lama 写道： > > +1 (non-binding) > > - verified signatures > - build with Java 8 and

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-28 Thread mystic lama
+1 (non-binding) - verified signatures - build with Java 8 and Java 11 - build success Minor observation - RAT check flagged that README.md is missing ASL On Fri, 27 Oct 2023 at 23:40, Xianxun Ye wrote: > +1(non-binding) > > - Started a local Flink 1.18 cluster, read and wrote with Kafka and U

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-27 Thread Xianxun Ye
+1(non-binding) - Started a local Flink 1.18 cluster, read and wrote with Kafka and Upsert Kafka connector successfully to Kafka 2.2 cluster One minor question: should we update the dependency manual of these two documentations[1][2]? [1] https://nightlies.apache.org/flink/flink-docs-master/d

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-26 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven via mvn clean install -Pcheck-convergence -Dflink.version=1.18.0 - Verified licenses - Verified web PR - Started a cluster and the Flink SQL client, successful

Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-25 Thread Qingsheng Ren
+1 (binding) - Verified signature and checksum - Verified that no binary exists in the source archive - Built from source with Java 8 using -Dflink.version=1.18 - Started a local Flink 1.18 cluster, submitted jobs with SQL client reading from and writing (with exactly-once) to Kafka 3.2.3 cluster

[VOTE] Apache Flink Kafka connector version 3.0.1, RC1

2023-10-25 Thread Tzu-Li (Gordon) Tai
Hi everyone, Please review and vote on release candidate #1 for version 3.0.1 of the Apache Flink Kafka Connector, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This release contains important changes for the following: - Supports Fl