Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Dian Fu
Hi Dawid, Thanks for your reply. I'm also in favor of "col" as a column expression in the Python Table API. Regarding to use "$" in the Java/Scala Table API, I'm fine with it. So +1 from my side. Thanks, Dian > 在 2020年2月11日,下午9:48,Aljoscha Krettek 写道: > > +1 > > Best, > Aljoscha > > On

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Aljoscha Krettek
+1 Best, Aljoscha On 11.02.20 11:17, Jingsong Li wrote: Thanks Dawid for your explanation, +1 for vote. So I am big +1 to accepting java.lang.Object in the Java DSL, without scala implicit conversion, a lot of "lit" look unfriendly to users. Best, Jingsong Lee On Tue, Feb 11, 2020 at 6:07

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Jingsong Li
Thanks Dawid for your explanation, +1 for vote. So I am big +1 to accepting java.lang.Object in the Java DSL, without scala implicit conversion, a lot of "lit" look unfriendly to users. Best, Jingsong Lee On Tue, Feb 11, 2020 at 6:07 PM Dawid Wysakowicz wrote: > Hi, > > To answer some of the

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Dawid Wysakowicz
Hi, To answer some of the questions: @Jingsong We use Objects in the java API to make it possible to use raw Objects without the need to wrap them in literals. If an expression is passed it is used as is. If anything else is used, it is assumed to be an literal and is wrapped into a literal.

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-11 Thread Dian Fu
Hi Dawid, Thanks for driving this feature. The design looks very well for me overall. I have only one concern: $ is not allowed to be used in the identifier of Python and so we have to come out with another symbol when aligning this feature in the Python Table API. I noticed that there are

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-10 Thread Jark Wu
+1 for this. I have some minor comments: - I'm +1 to use $ in both Java and Scala API. - I'm +1 to use lit(), Spark also provides lit() function to create a literal value. - Is it possible to have `isGreater` instead of `isGreaterThan` and `isGreaterOrEqual` instead of `isGreaterThanOrEqualTo` in

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-10 Thread Jingsong Li
Hi Dawid, Thanks for driving. - adding $ in scala api looks good to me. - Just a question, what should be expected to java.lang.Object? literal object or expression? So the Object is the grammatical sugar of literal? Best, Jingsong Lee On Mon, Feb 10, 2020 at 9:40 PM Timo Walther wrote: > +1

Re: [VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-10 Thread Timo Walther
+1 for this. It will also help in making a TableEnvironment.fromElements() possible and reduces technical debt. One entry point of TypeInformation less in the API. Regards, Timo On 10.02.20 08:31, Dawid Wysakowicz wrote: Hi all, I wanted to resurrect the thread about introducing a Java

[VOTE] FLIP-55: Introduction of a Table API Java Expression DSL

2020-02-09 Thread Dawid Wysakowicz
Hi all, I wanted to resurrect the thread about introducing a Java Expression DSL. Please see the updated flip page[1]. Most of the flip was concluded in previous discussion thread. The major changes since then are: * accepting java.lang.Object in the Java DSL * adding $ interpolation for a