Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Yaz Sh
Thanks for the fix! /Yaz On Thu, Aug 9, 2018 at 9:10 AM Till Rohrmann wrote: > Thanks for reporting this problem Yaz. I just pushed a commit which should > update the links accordingly once the Flink documentation gets rebuilt > (over night). Tomorrow it should be fixed. > > Cheers, > Till > >

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Till Rohrmann
Thanks for reporting this problem Yaz. I just pushed a commit which should update the links accordingly once the Flink documentation gets rebuilt (over night). Tomorrow it should be fixed. Cheers, Till On Thu, Aug 9, 2018 at 2:53 PM Yaz Sh wrote: > Great Job on Release 1.6! > > I just checked

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Yaz Sh
Great Job on Release 1.6! I just checked it out and still I can see v.1.6-SNAPSHOT on the title of https://ci.apache.org/projects/flink/flink-docs-release-1.6/ and when I click on any options, it redirects me to master docs

[RESULT] [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Till Rohrmann
I'm happy to announce that we have unanimously approved the 1.6.0 release. There are 7 approving votes, 4 of which are binding: - Piotrek (non-binding) - Chesnay (binding) - Aljoscha (binding) - Dawid (non-binding) - Timo (binding) - Vino (non-binding) - Till (binding) There are no disapproving

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Till Rohrmann
I hereby close the vote. The result will be announced in a separate thread. On Thu, Aug 9, 2018 at 11:47 AM Till Rohrmann wrote: > +1 > > - Checked checksums and signatures > - Verified that no unwanted binaries are contained in source release > - Checked LICENSE and NOTICE file > - Checked

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread Till Rohrmann
+1 - Checked checksums and signatures - Verified that no unwanted binaries are contained in source release - Checked LICENSE and NOTICE file - Checked that all newly added dependencies have a compatible license - Checked that a local cluster can be started and stopped without exceptions in the

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-09 Thread vino yang
+1 - checkout 1.6 source code and successfully run `mvn clean package -DskipTests` - searched '1.5' and '1.5.2' in all modules pom file and successfully verified flink version was changed - successfully run table and sql test locally Thanks, vino. Timo Walther 于2018年8月9日周四 上午3:24写道: > +1 > >

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Timo Walther
+1 - successfully run `mvn clean verify` locally - successfully run end-to-end tests locally (except for SQL Client end-to-end test) Found a bug in the class loading of SQL JAR files. This is not a blocker but a bug that we should fix soon. As an easy workaround user should not use

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Dawid Wysakowicz
+1 - verified compilation, tests - verified checksum and gpg files - verified sbt templates (g8, quickstart) - run assemblies on local cluster - I could not execute the nightly-tests.sh though. The tests that were failing most often are:     - test_streaming_file_sink.sh     -

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Aljoscha Krettek
+1 - verified checksum and gpg files - verified LICENSE and NOTICE: NOTICE didn't change from 1.5, LICENSE had one unnecessary part removed Side comment: I'm not sure whether the "Verify that the LICENSE and NOTICE file is correct for the binary and source releases" part is valid anymore

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Chesnay Schepler
+1 - verified source release contains no binaries - verified correct versions in source release - verified compilation, tests and E2E-tests pass (on travis) - verified checksum and gpg files New dependencies (excluding dependencies where we simply depend on a different version now):

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Till Rohrmann
Thanks for reporting these problems Chesnay. The usage string in `standalone-job.sh` is out dated and should be updated. The same applies to the typo. When calling `standalone-job.sh start --job-classname foobar.Job` please make sure that the user code jar is contained in the classpath (e.g.

Re: [VOTE] Release 1.6.0, release candidate #4

2018-08-08 Thread Piotr Nowojski
+1 from my side I’ve spent some time playing around with various examples (batching, streaming and SQL) on EMR 6 nodes cluster with yarn deployment, with different configuration options (number of task managers/memory/Flip6/credit base flow control/metrics) and everything looks now fine (after

[VOTE] Release 1.6.0, release candidate #4

2018-08-07 Thread Till Rohrmann
Hi everyone, Please review and vote on the release candidate #4 for the version 1.6.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *