Re: Master not building and how to notice it faster in the future

2015-02-12 Thread Robert Metzger
Searching for "travis build notifications apache" on Google reveals actually a commit from our repo: http://mail-archives.apache.org/mod_mbox/flink-commits/201406.mbox/%3c8be204a6869f4380b0de3135373c0...@git.apache.org%3E Tajo also tried this: https://issues.apache.org/jira/browse/TAJO-834 But I d

Re: Master not building and how to notice it faster in the future

2015-02-12 Thread Robert Metzger
No, I think this won't work because travis only sends emails to accounts associated with the repository. In this case its the apache/flink github repository and nobody of us is actually part of the organization. See http://docs.travis-ci.com/user/notifications/: > The most common cause for not re

Re: Master not building and how to notice it faster in the future

2015-02-12 Thread Ufuk Celebi
I just found out that we can simply activate email notifications for build failures. Can we allow bu...@travis-ci.org to send to dev@f.a.o? On Wed, Jan 21, 2015 at 9:41 PM, Robert Metzger wrote: > I'm actually quite happy with the travis setup. Since most of the > contributors/committers have t

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Robert Metzger
I'm actually quite happy with the travis setup. Since most of the contributors/committers have travis activated for their forks, its very convenient to run tests on travis, without polluting any public apache infrastructure. Also, it would add another big dependency to a (perceived) unstable apache

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Henry Saputra
Would it be better to use Github Jenkins plugin [1] to connect to ASF Jenkins cluster? [1] https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin [2] http://events.linuxfoundation.org/sites/events/files/slides/Jenkins_at_ASF_2014.pdf On Tue, Jan 20, 2015 at 2:57 PM, Robe

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Ufuk Celebi
Thanks for the nice script. I've just installed it :-) On 21 Jan 2015, at 13:57, Max Michels wrote: > I've created a pre-push hook that does what I described (and a bit > more). It does only enforce a check for the remote flink master branch > and doesn't disturb you on your pushes. > > https:/

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Max Michels
I've created a pre-push hook that does what I described (and a bit more). It does only enforce a check for the remote flink master branch and doesn't disturb you on your pushes. https://gist.github.com/mxm/4d1e26b901c66a682e4a Just put the the file in the .git/hooks/ directory of your repository

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Max Michels
@Robert The pre-push hook only resides in your local repository. It cannot be pushed. Thus, we cannot enforce this check but it certainly helps to prevent mistakes. As Ufuk mentioned, you can then even skip the check with the --no-verify option if you're really sure. On Wed, Jan 21, 2015 at 11:45

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Ufuk Celebi
On 21 Jan 2015, at 11:40, Robert Metzger wrote: > Is the git hook something we can control for everybody? I thought its more > like a personal thing everybody can set up if wanted? > > I'm against enforcing something like this for every committer. I don't want > to wait for 15 minutes for pushi

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Robert Metzger
Is the git hook something we can control for everybody? I thought its more like a personal thing everybody can set up if wanted? I'm against enforcing something like this for every committer. I don't want to wait for 15 minutes for pushing a typo fix to the documentation. On Wed, Jan 21, 2015 at

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Ufuk Celebi
On 21 Jan 2015, at 10:40, Till Rohrmann wrote: > I like both approaches because maven won't necessarily find all problems if > executed locally. Especially concurrency problems seem to occur more often > on travis than on my local machine. I agree with Till. Let's add a git hook to catch most o

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Till Rohrmann
I like both approaches because maven won't necessarily find all problems if executed locally. Especially concurrency problems seem to occur more often on travis than on my local machine. Greets, Till On Wed, Jan 21, 2015 at 9:59 AM, Max Michels wrote: > Hi Robert, > > I like your solution usin

Re: Master not building and how to notice it faster in the future

2015-01-21 Thread Max Michels
Hi Robert, I like your solution using Travis and Google App Engine. However, I think there's a much simpler solution which can prevent commiters from pushing not even compiling or test-failing code to the master in the first place. Commiters could simply install a git pre-push hook in their git r

Re: Master not building and how to notice it faster in the future

2015-01-20 Thread Ufuk Celebi
On 21 Jan 2015, at 00:19, Robert Metzger wrote: > I think its just a missing import. Yes. > Maybe we can use Google AppEngine for that. It seems that their free > offering is sufficient for our purpose: > https://cloud.google.com/pricing/#app-engine. It also allows sending emails. > I guess it

Re: Master not building and how to notice it faster in the future

2015-01-20 Thread Robert Metzger
I think its just a missing import. Maybe we can use Google AppEngine for that. It seems that their free offering is sufficient for our purpose: https://cloud.google.com/pricing/#app-engine. It also allows sending emails. I guess its hard to get the token for the "apache" user. Maybe there is is a

Re: Master not building and how to notice it faster in the future

2015-01-20 Thread Ufuk Celebi
On 20 Jan 2015, at 23:57, Robert Metzger wrote: > There are certainly ways to fix this. Right now, the best approach is > probably setting up a REST 2 e-mail service somewhere which is mailing to > our dev@ list ( > http://docs.travis-ci.com/user/notifications/#Webhook-notification). That sound

Master not building and how to notice it faster in the future

2015-01-20 Thread Robert Metzger
Hi, it seems that our master is currently not building. See: https://travis-ci.org/apache/flink/jobs/47689754 We need to come up with a good solution to notify dev@flink when builds on Travis are failing. We also had unstable builds recently due to too short akka timeouts and it took some time t