FW: Maven and java version variables

2023-10-25 Thread David Radley
resolve another conflict? Kind regards, David. From: David Radley Date: Monday, 23 October 2023 at 12:25 To: dev@flink.apache.org Subject: [EXTERNAL] Maven and java version variables Hi, I have an open pr in the backlog that improves the pom.xml by introducing some Maven variables. The pr is https

RE: Maven and java version variables

2023-10-25 Thread David Radley
Hi Matthias, That sounds reasonable, Kind regards, David From: Matthias Pohl Date: Monday, 23 October 2023 at 16:41 To: dev@flink.apache.org Subject: [EXTERNAL] Re: Maven and java version variables Hi David, The change that caused the conflict in your PR is caused by FLINK-33291 [1]. I was

Re: Maven and java version variables

2023-10-23 Thread Matthias Pohl
Hi David, The change that caused the conflict in your PR is caused by FLINK-33291 [1]. I was thinking about adding links to the comments to make the navigation to the corresponding resources easier as you rightfully mentioned. I didn't do it in the end because I was afraid that documentation might

Re: Maven and java version variables

2023-10-23 Thread Alexander Fedulov
(under "Prepare for the release") As for CI: https://github.com/apache/flink/blob/78b5ddb11dfd2a3a00b58079fe9ee29a80555988/tools/ci/maven-utils.sh#L84 https://github.com/apache/flink/blob/9b63099964b36ad9d78649bb6f5b39473e0031bd/tools/azure-pipelines/build-apache-repo.yml#L39 https://github.com/ap

Re: Maven and java version variables

2023-10-23 Thread Jing Ge
Hi David, Please check [1] in the section Verify Java and Maven Version. Thanks! Best regards, Jing [1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release On Mon, Oct 23, 2023 at 1:25 PM David Radley wrote: > Hi, > > I have an open pr in the backlog that improves the

Maven and java version variables

2023-10-23 Thread David Radley
Hi, I have an open pr in the backlog that improves the pom.xml by introducing some Maven variables. The pr is https://github.com/apache/flink/pull/23469 It has been reviewed but not merged. In the meantime another pom change has been added that caused a conflict. I have amended the code in my pr