Re: PR review request for sql-gateway feature

2024-07-22 Thread Shengkai Fang
Hi Dongoo, You are right that plan advisor doesn't have ability to block user request. Actually, we add a new REST API in the gateway side to validate the users request is legal or not in our inner branch. Therefore, user can validate their statements before execution or execute their statement

Re: PR review request for sql-gateway feature

2024-07-22 Thread Dongwoo Kim
Hi Shengkai, Thank you for introducing an interesting concept of plan advice. After reviewing the FLIP, I thought that plan advice cannot fully replace the original intention of the OperationValidator. Similar to the pluggable ResourceValidator[1] in flink k8s operator, the OperationValidator

Re: PR review request for sql-gateway feature

2024-07-19 Thread Shengkai Fang
Hi Dongwoo, Thanks for your proposal! I think the idea about OperationValidator is similar to the plan advice[1], which can give advice if the statement has problems. I wonder if it would be more beneficial to develop the concept within the existing infrastructure, rather than introducing a new

Re: PR review request for sql-gateway feature

2024-07-18 Thread Dongwoo Kim
Hi Martijn, Thanks for the guidance on making a FLIP. Before proceeding, I’d like to gather some initial thoughts from the community to see if we agree on the usefulness of this feature. Could anyone share their opinions on the custom query operation validator for Flink SQL Gateway? Thanks in

Re: PR review request for sql-gateway feature

2024-07-18 Thread Martijn Visser
Hi Dongwoo, I think this should first have been a FLIP [1], given that it proposes to make something pluggable with custom interfaces. Best regards, Martijn [1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals On Thu, Jul 18, 2024 at 2:50 PM Dongwoo Kim wrote: >

PR review request for sql-gateway feature

2024-07-18 Thread Dongwoo Kim
Hi devs, A month ago, I created a jira issue and pr for a custom query operation validator in Flink SQL Gateway to block unsafe queries. Since there has been no feedback yet, I would appreciate it if someone could review it or provide some feedback. I'm curious if this feature can be added and if