Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-15 Thread Xuannan Su
they are going to be removed for v2, it would be good to > explicitly document the thinking and impact of the deprecations and > consequent removals, > Kind regards, David. > > From: Xuannan Su > Date: Tuesday, 14 May 2024 at 02:08 > To: dev@flink.apache.org > Su

RE: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-15 Thread David Radley
: Improve Runtime Configuration for Flink 2.0 Hi all, Thank you for all the comments and suggestions! If there are no further comments, I'd like to close the discussion and start the voting in two days. Best regards, Xuannan On Mon, May 13, 2024 at 3:10 PM Jeyhun Karimov wrote: > > Hi X

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-13 Thread Xuannan Su
Hi all, Thank you for all the comments and suggestions! If there are no further comments, I'd like to close the discussion and start the voting in two days. Best regards, Xuannan On Mon, May 13, 2024 at 3:10 PM Jeyhun Karimov wrote: > > Hi Xuannan, > > Thanks a lot for the update. The FLIP

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-13 Thread Jeyhun Karimov
Hi Xuannan, Thanks a lot for the update. The FLIP looks good to me. +1 for it. Regards, Jeyhun On Mon, May 13, 2024 at 4:45 AM Xuannan Su wrote: > Hi Jeyhun, > > Thanks for the comment! > > Yes, we intended to remove the StreamPiplineOptions in 2.0. I updated > the FLIP to include the

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-12 Thread Xuannan Su
Hi Jeyhun, Thanks for the comment! Yes, we intended to remove the StreamPiplineOptions in 2.0. I updated the FLIP to include the information. Best regards, Xuannan On Sun, May 12, 2024 at 9:16 PM Jeyhun Karimov wrote: > > Hi Xuannan, > > Thanks for driving this FLIP! > I have a minor comment.

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-12 Thread Jeyhun Karimov
Hi Xuannan, Thanks for driving this FLIP! I have a minor comment. Do we plan to remove StreamPipelineOptions in 2.0, as it only contains deprecated options? Regards, Jeyhun On Sat, May 11, 2024 at 4:40 AM Rui Fan <1996fan...@gmail.com> wrote: > Thanks Xuannan for the update! > > LGTM, +1 for

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-10 Thread Rui Fan
Thanks Xuannan for the update! LGTM, +1 for this proposal. Best, Rui On Sat, May 11, 2024 at 10:20 AM Xuannan Su wrote: > Hi Rui, > > Thanks for the suggestion! > > I updated the description of > taskmanager.network.memory.max-overdraft-buffers-per-gate and > hard-coded it to 20. > > Best

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-10 Thread Xuannan Su
Hi Rui, Thanks for the suggestion! I updated the description of taskmanager.network.memory.max-overdraft-buffers-per-gate and hard-coded it to 20. Best regards, Xuannan On Mon, May 6, 2024 at 11:28 AM Rui Fan <1996fan...@gmail.com> wrote: > > Thanks Xuannan for driving this proposal! > > >

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-10 Thread Junrui Lee
Thanks Xuannan for driving this! +1 for this proposal. Best, Junrui Rui Fan <1996fan...@gmail.com> 于2024年5月6日周一 11:27写道: > Thanks Xuannan for driving this proposal! > > > taskmanager.network.memory.max-overdraft-buffers-per-gate will be removed > and hard-coded to either 10 or 20. > >

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-10 Thread Xuannan Su
Hi Xintong, Thanks for the suggestion! I updated the FLIP to include a list of related tasks. Best regards, Xuannan On Mon, Apr 29, 2024 at 3:40 PM Xintong Song wrote: > > Thanks for driving this effort, Xuannan. > > +1 for the proposed changes. > > Just one suggestion: Some of the proposed

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-05 Thread Rui Fan
Thanks Xuannan for driving this proposal! > taskmanager.network.memory.max-overdraft-buffers-per-gate will be removed and hard-coded to either 10 or 20. Currently, it's a public option. Could we determine the value of the overdraft buffer in the current FLIP? I vote 20 as the hard code value

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-05-05 Thread Yuxin Tan
Thanks for the effort, Xuannan. +1 for the proposal. Best, Yuxin Xintong Song 于2024年4月29日周一 15:40写道: > Thanks for driving this effort, Xuannan. > > +1 for the proposed changes. > > Just one suggestion: Some of the proposed changes involve not solely > changing the configuration options, but

Re: [DISCUSSION] FLIP-450: Improve Runtime Configuration for Flink 2.0

2024-04-29 Thread Xintong Song
Thanks for driving this effort, Xuannan. +1 for the proposed changes. Just one suggestion: Some of the proposed changes involve not solely changing the configuration options, but are bound to changing / removal of certain features. E.g., the removal of hash-blocking shuffle and legacy hybrid