Re: Re: [DISCUSS] Update our EditorConfig file

2020-06-13 Thread Yun Gao
+1 for have a editorconfig file that is more consistent with Flink's code sytle. From my own experience, whenever I open the Flink repo for the first time, I have to manually change the continuation indent to 4 and disable the wildcard imports. I also think that it should be more nice to new d

Re: [DISCUSS] Update our EditorConfig file

2020-06-12 Thread Robert Metzger
It seems that nobody cares about the file, as it has been basically never touched after its creation in late 2015. I would be fine adding the changes you are proposing to the codebase. On Thu, Jun 11, 2020 at 4:47 AM tison wrote: > > is anyone actually using our .editorconfig file? > > I think

Re: [DISCUSS] Update our EditorConfig file

2020-06-10 Thread tison
> is anyone actually using our .editorconfig file? I think IDEA already takes this file into consideration. So far it works well for me. Best, tison. Jingsong Li 于2020年6月11日周四 上午10:26写道: > +1 looks more friendly to Flink newbies. > > Best, > Jingsong Lee > > On Wed, Jun 10, 2020 at 8:38 PM Al

Re: [DISCUSS] Update our EditorConfig file

2020-06-10 Thread Jingsong Li
+1 looks more friendly to Flink newbies. Best, Jingsong Lee On Wed, Jun 10, 2020 at 8:38 PM Aljoscha Krettek wrote: > Hi, > > is anyone actually using our .editorconfig file? IntelliJ has a plugin > for this that is actually quite powerful. > > I managed to write a .editorconfig file that I qui