+1 for have a editorconfig file that is more consistent with Flink's code sytle.
From my own experience, whenever I open the Flink repo for the first time, I have to manually change the continuation indent to 4 and disable the wildcard imports. I also think that it should be more nice to new developers if the above manual configuration could be omitted. Best, Yun ------------------Original Mail ------------------ Sender:Robert Metzger <rmetz...@apache.org> Send Date:Fri Jun 12 21:57:50 2020 Recipients:dev <dev@flink.apache.org> Subject:Re: [DISCUSS] Update our EditorConfig file It seems that nobody cares about the file, as it has been basically never touched after its creation in late 2015. I would be fine adding the changes you are proposing to the codebase. On Thu, Jun 11, 2020 at 4:47 AM tison <wander4...@gmail.com> wrote: > > is anyone actually using our .editorconfig file? > > I think IDEA already takes this file into consideration. So far it works > well for me. > > Best, > tison. > > > Jingsong Li <jingsongl...@gmail.com> 于2020年6月11日周四 上午10:26写道： > > > +1 looks more friendly to Flink newbies. > > > > Best, > > Jingsong Lee > > > > On Wed, Jun 10, 2020 at 8:38 PM Aljoscha Krettek <aljos...@apache.org> > > wrote: > > > > > Hi, > > > > > > is anyone actually using our .editorconfig file? IntelliJ has a plugin > > > for this that is actually quite powerful. > > > > > > I managed to write a .editorconfig file that I quite like: > > > https://github.com/aljoscha/flink/commits/new-editorconfig. For me to > > > use that, we would either need to update our Flink file to what I did > > > there or remove the "root = true" part from the file to allow me to > > > place my custom .editorconfig in the directory above. > > > > > > It's probably a lost cause to find consensus on what settings we should > > > have in that file but it could be helpful if we all used the same > > > settings. For what it's worth, this will format code in such a way that > > > it pleases our (very lenient) checkstyle rules. > > > > > > What do you think? > > > > > > Best, > > > Aljoscha > > > > > > > > > -- > > Best, Jingsong Lee > > >
