Re: StreamingFileSink's DefaultRollingPolicy

2023-03-09 Thread yuxia
-- 发件人: "Lee, Keith" 收件人: "dev" 发送时间: 星期二, 2023年 3 月 07日 下午 10:39:44 主题: StreamingFileSink's DefaultRollingPolicy Hi, StreamingFileSink’s DefaultRollingPolicy does not always roll in progress parts to pending parts on checkpoints. Is this by design? It seems counter intuit

Re: StreamingFileSink's DefaultRollingPolicy

2023-03-09 Thread Lee, Keith
Hi Ram, You are right, the effect of DefaultRollingPolicy not always rolling on checkpoint leads to unusable non-latest savepoints. My question is, should DefaultRollingPolicy be changed so that it always roll on checkpoint to provide a better user experience? I'd imagine most StreamingFileSink

Re: StreamingFileSink's DefaultRollingPolicy

2023-03-08 Thread ramkrishna vasudevan
chments unless you can confirm the sender and know > the content is safe. > > Yes, it's by design. > > > I don't think we should change DefaultRollingPolicy. Can't > `OnCheckpointRollingPolicy` meet your requirements? > > > Best regards, > Yuxia > > >

RE: Re: StreamingFileSink's DefaultRollingPolicy

2023-03-08 Thread Lee, Keith
> > 收件人: "dev" mailto:de...@flink.apache.org>> > 发送时间: 星期二, 2023年 3 月 07日 下午 10:39:44 > 主题: StreamingFileSink's DefaultRollingPolicy > > Hi, > > StreamingFileSink’s DefaultRollingPolicy does not always roll in progress > parts to pending parts o

Re: StreamingFileSink's DefaultRollingPolicy

2023-03-08 Thread Lee, Keith
ollingPolicy. Can't `OnCheckpointRollingPolicy` meet your requirements? Best regards, Yuxia - 原始邮件 - 发件人: "Lee, Keith" mailto:lee...@amazon.co.uk.inva>LID> 收件人: "dev" mailto:dev@flink.apache.org>> 发送时间: 星期二, 2023年 3 月 07日 下午 10:39:44 主题: StreamingFileS

Re: StreamingFileSink's DefaultRollingPolicy

2023-03-07 Thread yuxia
Yes, it's by design. I don't think we should change DefaultRollingPolicy. Can't `OnCheckpointRollingPolicy` meet your requirements? Best regards, Yuxia - 原始邮件 - 发件人: "Lee, Keith" 收件人: "dev" 发送时间: 星期二, 2023年 3 月 07日 下午 10:39:44 主题: Streaming

StreamingFileSink's DefaultRollingPolicy

2023-03-07 Thread Lee, Keith
Hi, StreamingFileSink’s DefaultRollingPolicy does not always roll in progress parts to pending parts on checkpoints. Is this by design? It seems counter intuitive to me that part files are not finished on checkpoint by default. https://github.com/ueshin/apache-flink/blob/master/flink-streaming-