Re: TestBaseUtils refactoring

@Anton - I agree, that class is pretty ugly and mostly leftover code. +1 for tearing it apart (and dropping as much code of it as possible in the process) On Thu, Jan 26, 2017 at 4:37 AM, Jark Wu wrote: > Hi Anton, > > Thanks for bringing up this discussion. > > I think TestBaseUtils is a util

Re: TestBaseUtils refactoring

hi, all UT and CT have clear boundary and consensus of opinion: 1. UT and CT separated. surefire plugin have two different execution for CT and UT 2. Temporary file creating and destroy should be unified with TemporaryFolder. FLINK-5546 has change the java.io .tmpdir to ta

Re: TestBaseUtils refactoring

Hi Anton, Thanks for bringing up this discussion. I think TestBaseUtils is a util class not a base class to extend. All the methods in TestBaseUtils are static, that means we can use any method directly without extend it. Thanks, Jark > 在 2017年1月26日，上午7:46，Anton Solovev 写道： > > Hello guys,

TestBaseUtils refactoring

Hello guys, I think there is a sense to tear apart TestBaseUtils into a number of util classes which it keeps them. Because some test classes can't extend this base test class, but need in its result checkers Best, Anton