Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread wei yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34200/ --- (Updated 七月 27, 2016, 2:19 a.m.) Review request for Flume. Changes --- p

[jira] [Commented] (FLUME-2960) Support Wildcards in directory name in TaildirSource

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394174#comment-15394174 ] Mike Percy commented on FLUME-2960: --- I believe there was a bug found with it in some ver

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34200/#review143547 --- flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcp

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Balázs Donát Bessenyei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34200/#review143546 --- wei yang, can you please rebase this patch on trunk? also, the te

Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource

2016-07-26 Thread Denes Arvay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50378/#review143526 --- flume-ng-sources/flume-taildir-source/src/main/java/org/apache/fl

[jira] [Commented] (FLUME-2960) Support Wildcards in directory name in TaildirSource

2016-07-26 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393941#comment-15393941 ] Attila Simon commented on FLUME-2960: - Only a minor correction that you actually turne

[jira] [Commented] (FLUME-2960) Support Wildcards in directory name in TaildirSource

2016-07-26 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393926#comment-15393926 ] Attila Simon commented on FLUME-2960: - Yes indeed. That is what I wrote. I would go fo

Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource

2016-07-26 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50378/#review143531 --- flume-ng-sources/flume-taildir-source/src/main/java/org/apache/fl

[jira] [Commented] (FLUME-2954) make raw data appearing in log messages explicit

2016-07-26 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393824#comment-15393824 ] Attila Simon commented on FLUME-2954: - After checking each of the log statements I col

[jira] [Updated] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread yangwei (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yangwei updated FLUME-2689: --- Attachment: (was: flume-2689-trunk.patch) > reloading conf file leads syslogTcpSource not receives any eve

[jira] [Updated] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread yangwei (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yangwei updated FLUME-2689: --- Attachment: flume-2689-trunk.patch flume-2689-trunk.patch patch based on trunk > reloading co

[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393543#comment-15393543 ] Mike Percy commented on FLUME-2689: --- Yes, please base the patch on trunk. > reloading c

[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread yangwei (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393536#comment-15393536 ] yangwei commented on FLUME-2689: Hi Mike Percy, the patch is based on 1.5.2. Do I need to

Jenkins build became unstable: Flume-trunk-hbase-1 #185

2016-07-26 Thread Apache Jenkins Server
See

Re: Review Request 50438: FLUME-2961:Make TaildirSource work with multiline

2016-07-26 Thread qiao wen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50438/ --- (Updated 七月 26, 2016, 9:02 a.m.) Review request for Flume. Summary (updated)

[jira] [Updated] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Percy updated FLUME-2689: -- Assignee: yangwei Hi [~wy96f], I'm assigning this JIRA to you. > reloading conf file leads syslogTcpSou

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy
> On July 26, 2016, 1:48 a.m., Mike Percy wrote: > > Thanks for updating the patch, tinawenqiao. I will try to let Donat take > > another look if he has time before I do a final review pass. > > > > Regards, Mike Oops, I am sorry, I mean Wei Yang. I mixed up this patch with another patch curr

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34200/#review143498 --- Thanks for updating the patch, tinawenqiao. I will try to let Dona

[jira] [Updated] (FLUME-2961) Make TaildirSource work with multiline

2016-07-26 Thread tinawenqiao (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tinawenqiao updated FLUME-2961: --- Description: TaidirSource defaults to LINE, this has issue when multiline log events like stack trace

Re: Review Request 50438: Make TaildirSource work with multiline

2016-07-26 Thread qiao wen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50438/ --- (Updated 七月 26, 2016, 8:35 a.m.) Review request for Flume. Repository: flume-

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread wei yang
> On 七月 20, 2016, 1:59 p.m., Balázs Donát Bessenyei wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java, > > line 39 > > > > > > Can you please expand this import? Thanks for the review

Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread wei yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34200/ --- (Updated 七月 26, 2016, 8:30 a.m.) Review request for Flume. Changes --- E

Review Request 50438: Make TaildirSource work with multiline

2016-07-26 Thread qiao wen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50438/ --- Review request for Flume. Repository: flume-git Description --- Make Tai

[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393422#comment-15393422 ] Mike Percy commented on FLUME-2689: --- I think you probably just forgot to hit "Submit" on

[jira] [Updated] (FLUME-2961) Make TaildirSource work with multiline

2016-07-26 Thread tinawenqiao (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tinawenqiao updated FLUME-2961: --- Attachment: FLUME-2961_1.patch > Make TaildirSource work with multiline >

[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread yangwei (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393416#comment-15393416 ] yangwei commented on FLUME-2689: I had updated it on the review board:) > reloading conf

[jira] [Commented] (FLUME-2959) flume-checkstyle module should be consistent with flume-ng prefix convention

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393413#comment-15393413 ] Mike Percy commented on FLUME-2959: --- Thanks for the patch, Lior. Some review feedback:

[jira] [Created] (FLUME-2961) Make TaildirSource work with multiline

2016-07-26 Thread tinawenqiao (JIRA)
tinawenqiao created FLUME-2961: -- Summary: Make TaildirSource work with multiline Key: FLUME-2961 URL: https://issues.apache.org/jira/browse/FLUME-2961 Project: Flume Issue Type: Improvement

[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393409#comment-15393409 ] Mike Percy commented on FLUME-2689: --- Thanks for the new patch [~wy96f]. Can you please u

[jira] [Commented] (FLUME-2953) Make TaildirSource work with recursive directory

2016-07-26 Thread tinawenqiao (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393407#comment-15393407 ] tinawenqiao commented on FLUME-2953: According to Mike Percy's suggestion, I rebase my

[jira] [Commented] (FLUME-2890) Typo in Twitter source warning

2016-07-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393400#comment-15393400 ] ASF subversion and git services commented on FLUME-2890: Commit 5a

[jira] [Commented] (FLUME-2890) Typo in Twitter source warning

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393399#comment-15393399 ] Mike Percy commented on FLUME-2890: --- +1, thanks for taking a look, Lior. > Typo in Twit

Re: Labels on issues blocking the Flume 1.7.0 release

2016-07-26 Thread Mike Percy
Hi Donat, Seems ok. Thanks for telling us what you're up to. Best, Mike On Fri, Jul 22, 2016 at 7:00 AM, Balazs Donat Bessenyei wrote: > Hello All, > > Some fellow collaborators (@denes, @sati) and I would like to help out > with the 1.7.0 release. > In order to do that, we started triaging and

[jira] [Commented] (FLUME-2844) ChannelCounter of SpillableMemoryChannel doesn't register actually.

2016-07-26 Thread Mike Percy (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393379#comment-15393379 ] Mike Percy commented on FLUME-2844: --- I think Denes means http://reviews.apache.org More